[issue19602] Use specific asserts in tkinter tests

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: LGTM. -- nosy: +ezio.melotti stage: patch review -> commit review ___ Python tracker ___ ___ Python-bu

[issue19591] Use specific asserts in ctype tests

2013-11-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8dbb78be2496 by Serhiy Storchaka in branch '2.7': Issue #19591: Use specific asserts in ctype tests. http://hg.python.org/cpython/rev/8dbb78be2496 -- ___ Python tracker

[issue19603] Use specific asserts in test_decr

2013-11-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- keywords: +patch Added file: http://bugs.python.org/file32658/test_descr_asserts.patch ___ Python tracker ___ ___

[issue19604] Use specific asserts in array tests

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: LGTM. -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue19594] Use specific asserts in unittest tests

2013-11-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset f32353baecc3 by Serhiy Storchaka in branch '3.3': Issue #19594: Use specific asserts in unittest tests. http://hg.python.org/cpython/rev/f32353baecc3 New changeset aacb0bd969e5 by Serhiy Storchaka in branch 'default': Issue #19594: Use specific asse

[issue19603] Use specific asserts in test_decr

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: I left a few comments on rietveld. -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list

[issue19600] Use specific asserts in distutils tests

2013-11-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5a0236f3f972 by Serhiy Storchaka in branch '3.3': Issue #19600: Use specific asserts in distutils tests. http://hg.python.org/cpython/rev/5a0236f3f972 New changeset 6a3501aab559 by Serhiy Storchaka in branch 'default': Issue #19600: Use specific ass

[issue10712] 2to3 fixer for deprecated unittest method names

2013-11-16 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue19627] python open built-in function - "updating" is not defined

2013-11-16 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue17618] base85 encoding

2013-11-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: Updated patch with suggested API changes, + docs. -- Added file: http://bugs.python.org/file32659/base85.patch ___ Python tracker ___ __

[issue19605] Use specific asserts in datetime tests

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: LGTM (I left a comment on rietveld). -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-lis

[issue19606] Use specific asserts in http.cookiejar tests

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: LGTM (I left a comment on rietveld). -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-lis

[issue19603] Use specific asserts in test_decr

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Updated patch addresses Ezio's comments. -- Added file: http://bugs.python.org/file32660/test_descr_asserts_2.patch ___ Python tracker ___ ___

[issue19607] Use specific asserts in weakref tests

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: LGTM (I left a comment on rietveld). -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-lis

[issue19608] devguide needs pictures

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: Plain ASCII-art might also be enough, but without specific indication of what kind of pictures you want and where you want them I'm going to close this. -- status: open -> pending ___ Python tracker

[issue17618] base85 encoding

2013-11-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: Updated patch incorporating Serhiy's self-review from 6 months ago (grr). -- Added file: http://bugs.python.org/file32661/base85-2.patch ___ Python tracker

[issue19383] nturl2path test coverage

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: The assertions have their arguments in the wrong order, it should be (actual, expected). In the code of the module there are also some examples in the comments, e.g.: # path is something like host/path/on/remote/host # convert this to \\host\path\on\remote\hos

[issue19382] tabnanny unit tests

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: I left a few comments on rietveld. -- nosy: +ezio.melotti type: -> enhancement ___ Python tracker ___ ___

[issue19362] Documentation for len() fails to mention that it works on sets

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: I think it's better to do: -Return the number of items of a sequence or mapping. +Return the number of items of a sequence or container. While it's true that most sequences are clearly containers (e.g. lists), the same is not so evident for other types like bytes

[issue19412] Add docs for test.support.requires_docstrings decorator

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: I was bitten by this in #19535. See the third point about test_contextlib in msg203071. I would expect support.requires_docstring to skip the test if -OO is used and the docstrings are missing. -- ___ Python tracker

[issue19454] devguide: Document what a "platform support" is

2013-11-16 Thread Ezio Melotti
Changes by Ezio Melotti : -- stage: -> needs patch type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue13248] deprecated in 3.2/3.3, should be removed in 3.4

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: The attached patch removes assertDictContainsSubset(). -- Added file: http://bugs.python.org/file32662/issue13248.diff ___ Python tracker ___

[issue17457] Unittest discover fails with namespace packages and builtin modules

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: I left a couple of comments on rietveld. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue19238] Misleading explanation of fill and align in format_spec

2013-11-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2b0690c9a026 by Ezio Melotti in branch '2.7': #19238: fix typo in documentation. http://hg.python.org/cpython/rev/2b0690c9a026 New changeset 7e3f8026ed30 by Ezio Melotti in branch '3.3': #19238: fix typo in documentation. http://hg.python.org/cpytho

[issue19238] Misleading explanation of fill and align in format_spec

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for noticing! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18326] Mention 'keyword only' for list.sort, improve glossary.

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: I think v2 is enough, but v3 is fine with me if people think v3 it's better. -- ___ Python tracker ___ ___

[issue19371] timing test too tight

2013-11-16 Thread Ezio Melotti
Changes by Ezio Melotti : -- stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing

[issue19594] Use specific asserts in unittest tests

2013-11-16 Thread Ezio Melotti
Changes by Ezio Melotti : -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue19600] Use specific asserts in distutils tests

2013-11-16 Thread Ezio Melotti
Changes by Ezio Melotti : -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue13633] Handling of hex character references in HTMLParser.handle_charref

2013-11-16 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +eli.bendersky, r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue19618] test_sysconfig_module fails on Ubuntu 12.04

2013-11-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: Please add system/os/py-version info. On my Win7-64 machine, C:\Programs\Python34>python -m test -v test_sysconfig C:\Programs\Python34>python -m distutils.tests.test_sysconfig both pass (and run slightly different sets of tests). -- nosy: +terry.reedy

[issue19618] test_sysconfig_module fails on Ubuntu 12.04

2013-11-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: Sorry, about system comment. Got here by link on mail list and read message, not title. Py version is still relevant, as one should try latest releases before reporting. -- ___ Python tracker

[issue19296] Compiler warning when compiling dbm module

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: I get the same warning on Fedora 19. However, the signature of dbmopen_impl is generated by argument clinic, so it isn't simply a matter of patching the signature in place. I'm also inclined to consider the *platform* header to be wrong, since the dbm_open API r

[issue19282] dbm.open should be a context manager

2013-11-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset c2f1bb56760d by Nick Coghlan in branch 'default': Close #19282: Native context management in dbm http://hg.python.org/cpython/rev/c2f1bb56760d -- nosy: +python-dev resolution: -> fixed stage: patch review -> committed/rejected status: open

[issue19282] dbm.open should be a context manager

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: Thanks Claudiu! Additional tweaks in the committed version: - added a paragraph to the docs about the with statement support and moved the versionchanged note there - changed the example in the docs to use a with statement - added a basic test that the dumbdbm i

[issue19282] dbm.open should be a context manager

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: I also changed the signature of the enter/exit methods to just use PyObject * (rather than dbmobject *), since that allowed a bunch of casts to be removed and eliminated a couple of compiler warnings about type mismatches. -- ___

[issue18842] Add float.is_finite is_nan is_infinite to match Decimal methods

2013-11-16 Thread Steven D'Aprano
Steven D'Aprano added the comment: On Sat, Nov 16, 2013 at 04:33:36PM +, Serhiy Storchaka wrote: > > Should we add these methods to other concrete Number subclasses (as Fraction > and complex)? Seems like a good idea to me. Is it worth making them part of the Number ABC, or is that too mu

[issue19282] dbm.open should be a context manager

2013-11-16 Thread Claudiu.Popa
Claudiu.Popa added the comment: Cool, thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue7475] codecs missing: base64 bz2 hex zlib hex_codec ...

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: Attached patch restores the aliases for the binary and text transforms, adds a test to ensure they exist and restores the "Aliases" column to the relevant tables in the documentation. It also updates the relevant section in the What's New document. I also tweak

<    1   2