[issue19075] Add sorting algorithm visualization to turtledemo

2013-11-16 Thread Jason Yeo
Jason Yeo added the comment: > Nothing much AFAIK, except that someone must be willing to maintain the code. I wrote the code, I guess I should be the one maintaining this. I am new to this, what must I look out for if I want to maintain this? -- __

[issue19553] PEP 453: "make install" and "make altinstall" integration

2013-11-16 Thread Ned Deily
Changes by Ned Deily : -- keywords: +patch Added file: http://bugs.python.org/file32646/issue19553.patch ___ Python tracker ___ ___ Py

[issue19553] PEP 453: "make install" and "make altinstall" integration

2013-11-16 Thread Ned Deily
Ned Deily added the comment: Here's a patch for review. It implements: * a new configure option: --with(out)-ensurepip=[=upgrade] "install" or "upgrade" using bundled pip * a new makefile macro ENSUREPIP that can be supplied to a "make install" or "make altinstall

[issue19553] PEP 453: "make install" and "make altinstall" integration

2013-11-16 Thread Ned Deily
Changes by Ned Deily : Removed file: http://bugs.python.org/file32646/issue19553.patch ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue19553] PEP 453: "make install" and "make altinstall" integration

2013-11-16 Thread Ned Deily
Changes by Ned Deily : Added file: http://bugs.python.org/file32647/issue19553.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19608] devguide needs pictures

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: We're not designers either. However, something that *could* help is to investigate whether or not the blockdiag and seqdiag Sphinx extensions can be integrated into the build toolchain for the devguide and the main Python docs. That would drastically lower the b

[issue18861] Problems with recursive automatic exception chaining

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: Adjusting the target version, since it isn't feasible to move away from the current behaviour any earlier than Python 3.5. -- versions: +Python 3.5 -Python 3.3 ___ Python tracker __

[issue19619] Blacklist base64, hex, ... codecs from bytes.decode() and str.encode()

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: The full input/output type specifications can't be implemented sensibly without also defining at least a ByteSequence ABC. While I think it's a good idea in the long run, there's no feasible way to design such a system in the time remaining before the Python 3.4

[issue18861] Problems with recursive automatic exception chaining

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: Something else that this might make simpler: the unittest.TestCase.subTest API is currently kind of ugly. If the subtest details could be stored as a frame annotation instead... -- ___ Python tracker

[issue19619] Blacklist base64, hex, ... codecs from bytes.decode() and str.encode()

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think internal blacklist for all standard non-unicode codecs will be enough to prevent the denial of service attack in maintenance releases. -- components: +Unicode nosy: +doerwalter, ezio.melotti priority: normal -> critical stage: -> needs patch

[issue19183] PEP 456 Secure and interchangeable hash algorithm

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: Thanks - are those numbers with the current feature branch, and hence no small string optimization? To be completely clear, I'm happy to accept a performance penalty to fix the hash algorithm. I'd just like to know exactly how big a penalty I'm accepting, and w

[issue19586] distutils: Remove assertEquals and assert_ deprecation warnings

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Jason just have fixed assertEquals usage in 3.4. -- nosy: +jason.coombs ___ Python tracker ___ ___

[issue19535] Test failures with -OO

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch. -- assignee: -> serhiy.storchaka keywords: +patch stage: -> patch review Added file: http://bugs.python.org/file32648/issue19535.patch ___ Python tracker _

[issue19590] Use specific asserts in test_email

2013-11-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 27567e954cbe by Serhiy Storchaka in branch '2.7': Issue #19590: Use specific asserts in email tests. http://hg.python.org/cpython/rev/27567e954cbe New changeset db6ea9abd317 by Serhiy Storchaka in branch '3.3': Issue #19590: Use specific asserts in

[issue19590] Use specific asserts in test_email

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your review. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue5202] wave.py cannot write wave files into a shell pipeline

2013-11-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6a599249e8b7 by Serhiy Storchaka in branch 'default': Issue #5202: Added support for unseekable files in the wave module. http://hg.python.org/cpython/rev/6a599249e8b7 -- nosy: +python-dev ___ Python trac

[issue19183] PEP 456 Secure and interchangeable hash algorithm

2013-11-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: For the record, it's better to use a geometric mean when agregating benchmark results into a single score. -- ___ Python tracker ___ __

[issue19618] test_sysconfig_module fails on Ubuntu 12.04

2013-11-16 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue19623] Support for writing aifc to unseekable file

2013-11-16 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: The aifc module documentation mentions that underlying file can be unseekable if the number of frames are specified. When used for writing, the file object should be seekable, unless you know ahead of time how many samples you are going to write i

[issue19553] PEP 453: "make install" and "make altinstall" integration

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: Thanks for the patch and the detailed feedback, Ned! I've pinged the pip folks on https://github.com/pypa/pip/issues/1322 to help triage these issues as existing pip upstream issues. -- ___ Python tracker

[issue5202] wave.py cannot write wave files into a shell pipeline

2013-11-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue19553] PEP 453: "make install" and "make altinstall" integration

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: For 8 in particular, I'm inclined to push that over to the pip side of the fence (as with the first 7 points). pip knows that ensurepip is involved (due to ENSUREPIP_OPTIONS being set in the environment), so it may be able to check if the unversioned scripts are

[issue19619] Blacklist base64, hex, ... codecs from bytes.decode() and str.encode()

2013-11-16 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 16.11.2013 10:16, Nick Coghlan wrote: > > Nick Coghlan added the comment: > > The full input/output type specifications can't be implemented sensibly > without also defining at least a ByteSequence ABC. While I think it's a good > idea in the long run,

[issue16685] audioop functions shouldn't accept strings

2013-11-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset b96f4ee1b08b by Serhiy Storchaka in branch 'default': Issue #16685: Added support for writing any bytes-like objects in the aifc, http://hg.python.org/cpython/rev/b96f4ee1b08b -- ___ Python tracker

[issue19504] Change "customise" to "customize".

2013-11-16 Thread Vinay Sajip
Vinay Sajip added the comment: > Can be closed? Not sure - I've just updated the logging, venv and launcher code and docs. -- ___ Python tracker ___

[issue8311] wave module sets data subchunk size incorrectly when writing wav file

2013-11-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue8311] wave module sets data subchunk size incorrectly when writing wav file

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Committed in changeset b96f4ee1b08b. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue8311] wave module sets data subchunk size incorrectly when writing wav file

2013-11-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 932db179585d by Serhiy Storchaka in branch 'default': Fixed issue number for issue #8311. http://hg.python.org/cpython/rev/932db179585d -- nosy: +python-dev ___ Python tracker

[issue15381] Optimize BytesIO to do less reallocations when written, similarly to StringIO

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Only one week left before feature freeze. Please benchmark this patch on Windows. -- ___ Python tracker ___ _

[issue19624] Switch constants in the errno module to IntEnum

2013-11-16 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: It will be good to switch constants in the errno module to IntEnum. -- components: Extension Modules, Library (Lib) messages: 203035 nosy: barry, eli.bendersky, ethan.furman, serhiy.storchaka priority: normal severity: normal stage: needs patch statu

[issue19619] Blacklist base64, hex, ... codecs from bytes.decode() and str.encode()

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: Note that users can completely blacklist any codec that hasn't been imported yet by preventing imports of that codec definition: >>> import sys, encodings >>> blocked_codecs = "bz2_codec", "zlib_codec" >>> for name in blocked_codecs: ... sys.modules["encoding

[issue19619] Blacklist base64, hex, ... codecs from bytes.decode() and str.encode()

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: Now that I understand Victor's proposal better, I actually agree with it, I just think the attribute names need to be "encodes_to" and "decodes_to". With Victor's proposal, *input* validity checks (including type checks) would remain the responsibility of the co

[issue16596] Skip stack unwinding when "next", "until" and "return" pdb commands executed in generator context

2013-11-16 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue19548] 'codecs' module docs improvements

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: Another big one: the encodings module API is not documented in the prose docs, and nor is the interface between the default search function and the individual encoding definitions. There's some decent info in help(encoding) though. The interaction with the impor

[issue19619] Blacklist base64, hex, ... codecs from bytes.decode() and str.encode()

2013-11-16 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 16.11.2013 13:44, Nick Coghlan wrote: > > Nick Coghlan added the comment: > > Now that I understand Victor's proposal better, I actually agree with it, I > just think the attribute names need to be "encodes_to" and "decodes_to". > > With Victor's propo

[issue19548] 'codecs' module docs improvements

2013-11-16 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 16.11.2013 14:25, Nick Coghlan wrote: > > Nick Coghlan added the comment: > > Another big one: the encodings module API is not documented in the prose > docs, and nor is the interface between the default search function and the > individual encoding de

[issue19619] Blacklist base64, hex, ... codecs from bytes.decode() and str.encode()

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: Such codecs can be represented (for 3.4) by simply not setting the attribute and leaving the output types unspecified. We don't need that complexity for the standard library, and the "not specified" escape hatch means complex codecs will be no worse off than the

[issue19619] Blacklist base64, hex, ... codecs from bytes.decode() and str.encode()

2013-11-16 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 16.11.2013 14:37, Nick Coghlan wrote: > > Such codecs can be represented (for 3.4) by simply not setting the attribute > and leaving the output types unspecified. We don't need that complexity for > the standard library, and the "not specified" escape h

[issue19548] 'codecs' module docs improvements

2013-11-16 Thread Mark Lawrence
Mark Lawrence added the comment: Could they be documented with a massive warning in red "Cpython implementation detail - subject to change without notice"? Or documented in a place that is only accessible to developers and not users? Or...??? -- nosy: +BreamoreBoy __

[issue19548] 'codecs' module docs improvements

2013-11-16 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 16.11.2013 15:03, Mark Lawrence wrote: > > Mark Lawrence added the comment: > > Could they be documented with a massive warning in red "Cpython > implementation detail - subject to change without notice"? Or documented in > a place that is only access

[issue15381] Optimize BytesIO to do less reallocations when written, similarly to StringIO

2013-11-16 Thread STINNER Victor
STINNER Victor added the comment: > Only one week left before feature freeze. This issue is an optimization, not a new feature. -- ___ Python tracker ___ ___

[issue19619] Blacklist base64, hex, ... codecs from bytes.decode() and str.encode()

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: The only reasonable way to accurately represent "anything that exposes a buffer memoryview can read" as a type check is to write an appropriately duck-typed ABC. You can't enumerate all the types that the binary codecs accept as input, because that list of types

[issue19625] IDLE should use UTF-8 as it's default encoding

2013-11-16 Thread irdb
New submission from irdb: >>> s = 'ی' Unsupported characters in input I'm using windows 8 and Python 2.7.6. The same line works perfectly if I save it in a module with encoding set to UTF-8; but it's really annoying that I can't test my code directly in IDLE. -- components: IDLE messa

[issue19183] PEP 456 Secure and interchangeable hash algorithm

2013-11-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: So, amusingly, Christian's patch seems to be 4-5% faster than vanilla on many benchmarks here (Sandy Bridge Core i5, 64-bit, gcc 4.8.1). A couple of benchmarks are a couple % slower, but nothing severe. This without the small strings optimization. On top of t

[issue19548] 'codecs' module docs improvements

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: On 16 November 2013 23:33, Marc-Andre Lemburg wrote: > On 16.11.2013 14:25, Nick Coghlan wrote: > Those were not documented on purpose, since they are an implementation > detail of the encodings package search function. > > If you document them now, you'll set the

[issue19183] PEP 456 Secure and interchangeable hash algorithm

2013-11-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: Benchmark report (without the small strings optimization): http://bpaste.net/show/UohtA8dmSREbrtsJYfTI/ -- ___ Python tracker ___ _

[issue19586] distutils: Remove assertEquals and assert_ deprecation warnings

2013-11-16 Thread Jason R. Coombs
Jason R. Coombs added the comment: Thanks Gregory for the report and patch. I was unaware of this ticket when I was correcting the deprecation warnings for distutils, so I've just used your patch as a reference and pushed the remaining fixes as you indicated. -- resolution: -> fixed s

[issue19586] distutils: Remove assertEquals and assert_ deprecation warnings

2013-11-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset ff471d8526a8 by Jason R. Coombs in branch 'default': Issue #19586: Update remaining deprecated assertions to their preferred usage. http://hg.python.org/cpython/rev/ff471d8526a8 -- nosy: +python-dev ___ P

[issue16510] Using appropriate checks in tests

2013-11-16 Thread Jason R. Coombs
Jason R. Coombs added the comment: A third counterargument is: 3. Newer developers (and even seasoned ones) adding new tests may use existing tests as a model for best practices. If the existing tests model sub-optimal practices, then those practices will be perpetuated both in the codebase an

[issue19553] PEP 453: "make install" and "make altinstall" integration

2013-11-16 Thread Ned Deily
Ned Deily added the comment: I think the most serious problem is 3 since it directly affects the end user. It would be good to have that fixed someway for 3.4.0b1. Resolutions to the other items could wait. -- ___ Python tracker

[issue19553] PEP 453: "make install" and "make altinstall" integration

2013-11-16 Thread Donald Stufft
Donald Stufft added the comment: 1. This is bound to be an issue that stems from the fact pip is doing the install instead of distutils. It probably makes sense to use the group id of the parent directory I think? 2. This is a side effect of Wheel being a whole new way to install, previously

[issue19586] distutils: Remove assertEquals and assert_ deprecation warnings

2013-11-16 Thread Gregory Salvan
Gregory Salvan added the comment: nice if it helps. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue16510] Using appropriate checks in tests

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is synchronized to tip the patch which doesn't include patches for already separated children issues. It touches 129 files and modifies over 600 lines. -- Added file: http://bugs.python.org/file32650/tests_asserts_3.patch ___

[issue19625] IDLE should use UTF-8 as it's default encoding

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is a duplicate of issue15809. -- nosy: +serhiy.storchaka resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> IDLE console uses incorrect encoding. type: -> behavior _

[issue16203] Proposal: add re.fullmatch() method

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Matthew, could you please answer my question? -- ___ Python tracker ___ ___ Python-bugs-list maili

[issue19553] PEP 453: "make install" and "make altinstall" integration

2013-11-16 Thread Nick Coghlan
Nick Coghlan added the comment: For the record: the current "--default-pip" option is the one that was previously "--default-install". I switched it because having the default installation behaviour be something other than the behaviour requested via the "--default-install" option really didn'

[issue18842] Add float.is_finite is_nan is_infinite to match Decimal methods

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Should we add these methods to other concrete Number subclasses (as Fraction and complex)? -- ___ Python tracker ___

[issue13477] tarfile module should have a command line

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have added comments on Rietveld. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue19099] struct.pack fails first time with unicode fmt

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Any comments? -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailin

[issue17806] Add keyword args support to str/bytes.expandtabs()

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Ezio, you can commit the patch if you want. -- stage: patch review -> commit review ___ Python tracker ___ ___

[issue10712] 2to3 fixer for deprecated unittest method names

2013-11-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- versions: -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue17806] Add keyword args support to str/bytes.expandtabs()

2013-11-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 82b58807f481 by Ezio Melotti in branch 'default': #17806: Added keyword-argument support for "tabsize" to str/bytes.expandtabs(). http://hg.python.org/cpython/rev/82b58807f481 -- nosy: +python-dev ___ Pyt

[issue19183] PEP 456 Secure and interchangeable hash algorithm

2013-11-16 Thread Christian Heimes
Christian Heimes added the comment: The numbers are between cpython default tip and my feature branch. I have pulled and merged all upstream changes into my feature branch yesterday. The results with "sso" in the file name are with small string optimization. Performance greatly depends on comp

[issue17806] Add keyword args support to str/bytes.expandtabs()

2013-11-16 Thread Ezio Melotti
Changes by Ezio Melotti : -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue19255] Don't "wipe" builtins at shutdown

2013-11-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- priority: normal -> critical ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue19535] Test failures with -OO

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Actually test_inspect is affected by -O. Here is updated patch. -- Added file: http://bugs.python.org/file32651/issue19535_2.patch ___ Python tracker

[issue19619] Blacklist base64, hex, ... codecs from bytes.decode() and str.encode()

2013-11-16 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 16.11.2013 15:52, Nick Coghlan wrote: > > The only reasonable way to accurately represent "anything that exposes a > buffer memoryview can read" as a type check is to write an appropriately > duck-typed ABC. You can't enumerate all the types that the bi

[issue19553] PEP 453: "make install" and "make altinstall" integration

2013-11-16 Thread Ned Deily
Ned Deily added the comment: 1. Yes, I think so. 2. OK 3. Ah, I was just using the default 1.4.1 from PyPI. With current dev from github, the result is now pip3.4 like the wheel install. So once 1.5.x is released, this shouldn't be a problem. 4. Sorry, I was imprecise. For "-m ensurepip --

[issue16510] Using appropriate checks in tests

2013-11-16 Thread R. David Murray
R. David Murray added the comment: Jason: yes, if it is broken down into small enough pieces for the module maintainer to be comfortable with the review :). I approved Serhiy's separate patch for test_email. I still wasn't sure about backporting, but I really don't like the 'unless' construc

[issue19535] Test failures with -OO

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: Patch LGTM. I'm getting 4 additional failures on 3.4: test_asyncio test_contextlib test_email test_statistics * test_statistics is fixed by the attached patch. * test_email fails in Lib/email/_policybase.py:95 -- this probably deservers a separate issue. * test_

[issue19626] test_email and Lib/email/_policybase.py failures with -OO

2013-11-16 Thread Ezio Melotti
New submission from Ezio Melotti: >From #19535: $ ./python -OO -m test -v test_email [...] == ERROR: test_policy (unittest.loader.ModuleImportFailure) -- Trac

[issue19535] Test failures with -OO

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: I created #19626 for the test_email failures. -- dependencies: +test_email and Lib/email/_policybase.py failures with -OO ___ Python tracker ___ _

[issue16203] Proposal: add re.fullmatch() method

2013-11-16 Thread Matthew Barnett
Matthew Barnett added the comment: I don't know that it's not needed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue19627] python open built-in function - "updating" is not defined

2013-11-16 Thread Bulwersator
New submission from Bulwersator: see http://stackoverflow.com/questions/1466000/python-open-built-in-function-difference-between-modes-a-a-w-w-and-r - "The Python docs conveniently leave out the crucial explanation that "open the file for updating" means "opens the file for both reading and wr

[issue19572] Report more silently skipped tests as skipped

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: I get a failure on Linux with test_posix: $ ./python -m test test_posix [1/1] test_posix test test_posix failed -- Traceback (most recent call last): File "/home/wolf/dev/py/py3k/Lib/test/test_posix.py", line 713, in test_getcwd_long_pathnames _create_and_do

[issue19573] Fix the docstring of inspect.Parameter and the implementation of _ParameterKind

2013-11-16 Thread Ezio Melotti
Changes by Ezio Melotti : -- components: +Library (Lib) nosy: +ethan.furman, ezio.melotti, ncoghlan stage: -> patch review versions: +Python 3.4 ___ Python tracker ___ _

[issue17681] Work with an extra field of gzip and zip files

2013-11-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file30412/zip_extra.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue17681] Work with an extra field of gzip and zip files

2013-11-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file32653/gzip_extra.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue17681] Work with an extra field of gzip and zip files

2013-11-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file30411/gzip_extra.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue17681] Work with an extra field of gzip and zip files

2013-11-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file32654/zipfile_extra.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue17681] Work with an extra field of gzip and zip files

2013-11-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file32655/README.dz ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17681] Work with an extra field of gzip and zip files

2013-11-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file32656/README.zip ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17681] Work with an extra field of gzip and zip files

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Some examples: >>> import zipfile >>> z = zipfile.ZipFile('README.zip') >>> z.filelist[0].extra b'UT\x05\x00\x03\xe0\xc3\x87Rux\x0b\x00\x01\x04\xe8\x03\x00\x00\x04\xe8\x03\x00\x00' >>> z.filelist[0].extra_map >>> list(z.filelist[0].extra_map.items()) [(21589,

[issue19535] Test failures with -OO

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Updated patch fixes test_contextlib and test_statistics too. I think test_asyncio is worth separated issue too. -- Added file: http://bugs.python.org/file32657/issue19535_3.patch ___ Python tracker

[issue19535] Test failures with -OO

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Ah, test_contextlib shouldn't be fixed. It failed due to cached non-optimized test.support. -- ___ Python tracker ___ ___

[issue19572] Report more silently skipped tests as skipped

2013-11-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Except pickletester and test_posix third patch LGTM. test_posix is worth separate issue. test_reduce and test_getinitargs in pickletester are always empty and can be just removed (if you don't want implement them). -- ___

[issue19628] maxlevels -1 on compileall for unlimited recursion

2013-11-16 Thread Sworddragon
New submission from Sworddragon: All functions of compileall are providing a maxlevels argument which defaults to 10. But it is currently not possible to disable this recursion limitation. Maybe it would be useful to have a special value like -1 to disable this limitation and allow to compile

[issue19587] Remove empty tests in test_bytes.FixedStringTest

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: I said this elsewhere but I'll repeat it here. I think the whole string_tests could/should be reorganized (and possibly documented). There are lot of classes and mixins on several files, and more than once I found tests that were accidentally not run or had othe

[issue19588] Silently skipped test in test_random

2013-11-16 Thread Ezio Melotti
Changes by Ezio Melotti : -- keywords: +easy nosy: +ezio.melotti stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list ma

[issue19591] Use specific asserts in ctype tests

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: LGTM. -- nosy: +ezio.melotti stage: patch review -> commit review ___ Python tracker ___ ___ Python-bu

[issue19593] Use specific asserts in importlib tests

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: Patch LGTM. -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue19629] support.rmtree fails on symlinks under Windows

2013-11-16 Thread Antoine Pitrou
New submission from Antoine Pitrou: support.rmtree doesn't work under Windows when there are symlinks (the symlinks aren't deleted anymore), while shutil.rmtree() works fine: >>> support.rmtree("@test_2160_tmp") >>> os.listdir("@test_2160_tmp") ['dirA', 'dirB', 'dirC', 'fileA', 'linkA', 'linkB'

[issue19629] support.rmtree fails on symlinks under Windows

2013-11-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: shutil.rmtree() uses os.lstat() while support.rmtree() calls os.path.isdir() instead. -- ___ Python tracker ___ ___

[issue19594] Use specific asserts in unittest tests

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue19595] Silently skipped test in test_winsound

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: Maybe someone else can try it, or just enable it and see if the buildbots are happy (I think you can use custom builds as well for this kind of experiments). > at least on 3.4 an unexpected success is silently ignored by regrtest is this expected? -- n

[issue19597] Add decorator for tests not yet implemented

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: I don't think a new option for regrtest is necessary. I'm also not sure expected failure is a good idea -- in some cases it might be better to report a skip or an error. Do you have other examples where this can be used? If there aren't many occurrences we might

[issue19591] Use specific asserts in ctype tests

2013-11-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 98adbaccaae3 by Serhiy Storchaka in branch '3.3': Issue #19591: Use specific asserts in ctype tests. http://hg.python.org/cpython/rev/98adbaccaae3 New changeset 5fa9293b6cde by Serhiy Storchaka in branch 'default': Issue #19591: Use specific asserts

[issue19600] Use specific asserts in distutils tests

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: LGTM (I left a comment on rietveld). -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-lis

[issue19601] Use specific asserts in sqlite3 tests

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: LGTM. -- nosy: +ezio.melotti stage: patch review -> commit review ___ Python tracker ___ ___ Python-bu

[issue19597] Add decorator for tests not yet implemented

2013-11-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: Indeed, this doesn't sound like a terrific idea to me. -- ___ Python tracker ___ ___ Python-bugs-lis

  1   2   >