[issue19585] Frame annotation

2013-11-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: I think this would need a PEP. -- nosy: +ncoghlan, pitrou ___ Python tracker ___ ___ Python-bugs-lis

[issue19429] OSError constructor does not handle errors correctly

2013-11-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 61a712066770 by Victor Stinner in branch 'default': Issue #19429, #19437: fix error handling in the OSError constructor http://hg.python.org/cpython/rev/61a712066770 -- nosy: +python-dev ___ Python tracke

[issue19596] Silently skipped tests in test_importlib

2013-11-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I use `test_spam = None` to skip the test in a subclass and remove it from the report. The question is which of these tests should be removed because they are senseless in specified subclass and which of them are just not implemented yet and should be repor

[issue19429] OSError constructor does not handle errors correctly

2013-11-14 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue19595] Silently skipped test in test_winsound

2013-11-14 Thread Zachary Ware
Zachary Ware added the comment: It doesn't appear to; at least on 3.4 an unexpected success is silently ignored by regrtest in non-verbose mode and added to the report in verbose mode (e.g., "OK (skipped=1, unexpected successes=1)") or when run alone. -- __

[issue19590] Use specific asserts in test_email

2013-11-14 Thread R. David Murray
R. David Murray added the comment: Looks fine to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue19572] Report more silently skipped tests as skipped

2013-11-14 Thread Zachary Ware
Zachary Ware added the comment: Here's a new patch to address the reviews from Serhiy and Ezio (thanks to you both!). -- versions: +Python 2.7 Added file: http://bugs.python.org/file32625/skiptest_not_return_or_pass.v3.diff ___ Python tracker

[issue19597] Add decorator for tests not yet implemented

2013-11-14 Thread Zachary Ware
New submission from Zachary Ware: Some tests in the test suite are not implemented for one reason or another, and most of these are defined simply as "def test_thats_not_implemented(self): pass", possibly with a comment meant to be a reminder to implement it. This patch adds a decorator to te

[issue19585] Frame annotation

2013-11-14 Thread Nick Coghlan
Nick Coghlan added the comment: Aye, it would. The improved exception chaining and frame hiding ideas in issue 18861 are also related. The part I particularly like in Walter's suggestion is the idea of a "frame description" that is displayed in the traceback for that frame, without the traceback

[issue16510] Using appropriate checks in tests

2013-11-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: I think there are two counterargument to leaving things alone. 1. The reason for the specialized checks is to change behavior when the test fails, to give more informative error messages. So the change is not purely cosmetic or stylistic. I believe there was a

[issue19590] Use specific asserts in test_email

2013-11-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is larger patch (some asserts were aliased). It is applicable to 3.3 too. -- versions: +Python 3.3 Added file: http://bugs.python.org/file32627/test_email_asserts_2.patch ___ Python tracker

[issue19590] Use specific asserts in test_email

2013-11-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: And here is a patch for 2.7. -- versions: +Python 2.7 Added file: http://bugs.python.org/file32628/test_email_asserts_2-2.7.patch ___ Python tracker _

[issue19580] Got resource warning when running test_base_events (test_asyncio)

2013-11-14 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue19466] Clear state of threads earlier in Python shutdown

2013-11-14 Thread STINNER Victor
STINNER Victor added the comment: The fix raised a new issue: #19565. I also saw a crash on Windows which is probably related: http://buildbot.python.org/all/builders/x86 Windows Server 2003 [SB] 3.x/builds/1717/steps/test/logs/stdio ==

[issue19598] Timeout in test_popen() of test_asyncio.test_windows_utils.PopenTests

2013-11-14 Thread STINNER Victor
New submission from STINNER Victor: http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/7528/steps/test/logs/stdio ... test_popen (test.test_asyncio.test_windows_utils.PopenTests) ... FAIL test_winsocketpair (test.test_asyncio.test_windows_utils.WinsocketpairTests) ... ok test_w

[issue19599] Failure of test_async_timeout() of test_multiprocessing_spawn: TimeoutError not raised

2013-11-14 Thread STINNER Victor
New submission from STINNER Victor: http://buildbot.python.org/all/builders/x86%20Windows%20Server%202003%20%5BSB%5D%203.x/builds/1716/steps/test/logs/stdio and http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/7529/steps/test/logs/stdio

[issue19598] Timeout in test_popen() of test_asyncio.test_windows_utils.PopenTests

2013-11-14 Thread Guido van Rossum
Guido van Rossum added the comment: Likely. Can you suggest a fix? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue19553] PEP 453: "make install" and "make altinstall" integration

2013-11-14 Thread Ned Deily
Changes by Ned Deily : -- assignee: -> ned.deily ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue19590] Use specific asserts in test_email

2013-11-14 Thread R. David Murray
R. David Murray added the comment: Any chance of getting a patch with the just the added changes? I'd rather not fish through the stuff I've already looked at looking for the new stuff. I'm of two minds about the advisability of backporting this. -- __

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

2013-11-14 Thread Eric Snow
Eric Snow added the comment: FYI, as of cc7ebd952777 the bulk of the implementation in features/pep-451 is working. There is a failing test on the Windows Server 2003 buildbot (which I'm trying to track down). I haven't been able to reproduce the failure on other buildbots, on my local Ubunt

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

2013-11-14 Thread Eric Snow
Eric Snow added the comment: Cool. Roundup linked the revision hash to the feature clone. :) -- ___ Python tracker ___ ___ Python-bug

[issue19597] Add decorator for tests not yet implemented

2013-11-14 Thread Zachary Ware
Zachary Ware added the comment: This patch takes the idea a little further, adding a command line option to regrtest, '--failnoimpl' (it could use a better name). With this option specified any test decorated by support.not_implemented will not be marked as an expected failure, allowing the No

[issue19530] cross thread shutdown of UDP socket exhibits unexpected behavior

2013-11-14 Thread mpb
mpb added the comment: Someone wrote a kernel patch based on my bug report. http://www.spinics.net/lists/netdev/msg257653.html -- ___ Python tracker ___

[issue19590] Use specific asserts in test_email

2013-11-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch which includes only added changes. Such small and straightforward changes are easier to review by looking at colorized `hg diff` output. -- Added file: http://bugs.python.org/file32630/test_email_asserts_2_diff.patch

<    1   2