[issue12037] test_email failures under Windows with the eol extension activated

2013-08-30 Thread R. David Murray
R. David Murray added the comment: We have to be careful, since while Windows may no longer care about \r\n, the RFCs certainly do, and the email package is very concerned with the RFC. However, neither of these tests are testing linesep discipline, so it is fine to fix them. I've made review

[issue18889] test_sax: multiple failures on Windows desktop

2013-08-30 Thread Terry J. Reedy
New submission from Terry J. Reedy: These are due to \r in line endings, as with #12037. File "F:\Python\dev\py34\lib\test\test_sax.py", line 634, in test_expat_file self.assertEqual(result.getvalue(), xml_test_out) Assert fails because off many \rs in xml_text_out. Same in line 649, in t

[issue11798] Test cases not garbage collected after run

2013-08-30 Thread Meador Inge
Meador Inge added the comment: I see some regressions when reference leak hunting with -j './python -j8 -R :' test test_ast crashed -- Traceback (most recent call last): File "/home/meadori/src/cpython/Lib/test/regrtest.py", line 1265, in runtest_inne r huntrleaks) File "/home/meadori/sr

[issue18889] test_sax: multiple failures on Windows desktop

2013-08-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: On #12037, David suggests instead the equivalent of this: with open(TEST_XMLFILE_OUT) as f: xml_test_out = f.read().encode('ascii') -- ___ Python tracker _

[issue12037] test_email failures under Windows with the eol extension activated

2013-08-30 Thread Terry J. Reedy
Terry J. Reedy added the comment: Attached patch works here too. Only the test...rfc822 part applies to 3.3, both to 3.4. The same idea works for #18889 too. -- Added file: http://bugs.python.org/file31527/12037_test_email2.diff ___ Python tracker <

[issue18890] Add a raw_data_manager content manager to the email package.

2013-08-30 Thread R. David Murray
New submission from R. David Murray: This is the third of three layered patches that introduce a new content management API to the email package. This patch is layered on top of the patch in issue 18860. Unfortunately the fact that these patches are layered (which I did in hopes of making th

[issue18890] Add a raw_data_manager content manager to the email package.

2013-08-30 Thread R. David Murray
Changes by R. David Murray : -- dependencies: +Add content manager API to email package ___ Python tracker ___ ___ Python-bugs-list ma

[issue18808] Thread.join returns before PyThreadState is destroyed

2013-08-30 Thread Tim Peters
Tim Peters added the comment: Nasty problem ;-) I don't understand the need for all the indirections in the second patch. Like, why use a weakref? It's not like we have to worry about an immortal tstate keeping a measly little lock object alive forever, right? Seems to me that if the tstat

[issue18418] Thread.isAlive() sometimes True after fork

2013-08-30 Thread A. Jesse Jiryu Davis
A. Jesse Jiryu Davis added the comment: Thanks for accepting this patch! Antoine, I initially had trouble writing a test that reliably reproduced the bug, especially in Python 3.3. But I read other threading tests and got smarter. The final patch includes tests that are very reliable at reveal

[issue18891] Master patch for content manager addtion to email package.

2013-08-30 Thread R. David Murray
New submission from R. David Murray: Since the only way to get a rietveld review link for all the changes is to post a single complete patch, I'm doing so in this issue. Feel free to review based on either this or the separate patches posted in issue 18785, issue 18860, and issue 18890. Ther

[issue12037] test_email failures under Windows with the eol extension activated

2013-08-30 Thread R. David Murray
R. David Murray added the comment: Looks good to me, go ahead and push it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue18882] Add threading.main_thread() function

2013-08-30 Thread Andrew Svetlov
Andrew Svetlov added the comment: There is updated patch. All tests pass. I've added docs for threading.main_thread() function also. -- Added file: http://bugs.python.org/file31530/issue18882-2.diff ___ Python tracker

[issue14075] argparse: unused method?

2013-08-30 Thread Madison May
Madison May added the comment: Any chance this issue could be reopened? I ran across this bit of code today when working on coverage for argparse. I'd like to again propose the removal or modification of _get_args. I understand that it's there primarily to be overridden, but even that's not

<    1   2