[issue1727418] xmlrpclib waits indefinately

2013-04-13 Thread Adam Duston
Changes by Adam Duston : -- versions: +Python 2.6 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15866] encode(..., 'xmlcharrefreplace') produces entities for surrogate pairs

2013-04-13 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- versions: -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue17618] base85 encoding

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: For the record, Mads and Brendan have submitted a contributor's agreement, so we can now take what we want from Mercurial's base85.py (which you can find at http://selenic.com/hg/file/4e1ae55e63ef/mercurial/pure/base85.py). --

[issue17720] pickle.py's load_appends should call append() on objects other than lists

2013-04-13 Thread Alexandre Vassalotti
New submission from Alexandre Vassalotti: In pickle.py, load_appends is currently defined as def load_appends(self): stack = self.stack mark = self.marker() list = stack[mark - 1] list.extend(stack[mark + 1:]) del stack[mark:] However, according to th

[issue17721] Help button on preference window doesn't work

2013-04-13 Thread Guilherme Simões
New submission from Guilherme Simões: The Help button on the Preferences windows does not do anything. Maybe I can fix it, but I don't know what it was supposed to do in the first place. For now it probably should be removed. -- components: IDLE messages: 186775 nosy: Guilherme.Simões

[issue17627] Datetime and time doesn't update timezone in a running Win app

2013-04-13 Thread Sijin Joseph
Sijin Joseph added the comment: This is the same as issue10634 Problem is with the Windows CRT implementation of localtime which does not seem to be using updated timezone information. Can this become an issue with technologies like vMotion which allow Live Migration of virtual servers across

[issue17708] sys.flags.hash_randomization doesn't return correct value

2013-04-13 Thread Stephen Tu
Stephen Tu added the comment: Py_HashRandomizationFlag was not getting properly set anywhere. This patch fixes this. Also a test case Behavior is now: $ cat ~/hr.py import sys print(sys.flags.hash_randomization) $ PYTHONHASHSEED=random ./python.exe ~/hr.py 1 $ PYTHONHASHSEED=0 ./python.exe ~/

[issue17016] _sre: avoid relying on pointer overflow

2013-04-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 27162465316f by Serhiy Storchaka in branch '2.7': Issue #17016: Get rid of possible pointer wraparounds and integer overflows http://hg.python.org/cpython/rev/27162465316f New changeset 2673d207c524 by Serhiy Storchaka in branch '3.3': Issue #17016:

[issue12220] minidom xmlns not handling spaces in xmlns attribute value field

2013-04-13 Thread amathew
amathew added the comment: I added a more descriptive error message for invalid namespaces. I agree that it would be great to eventually move to DOMException's. -- keywords: +patch nosy: +amathew Added file: http://bugs.python.org/file29812/minidom_space_char_in_namespace.patch __

[issue17628] str==str: compare the first and last character before calling memcmp()

2013-04-13 Thread STINNER Victor
STINNER Victor added the comment: You must check that data is aligned. Did you run a benchmark? -- ___ Python tracker ___ ___ Python-

[issue17618] base85 encoding

2013-04-13 Thread Martin Morrison
Martin Morrison added the comment: Ok, great. I'll update the patch to include both encoding schemes. -- ___ Python tracker ___ ___ Py

[issue17710] SystemError in cPickle for incorrect input

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Here is a patch for 2.7. -- keywords: +patch Added file: http://bugs.python.org/file29813/cpickle_systemerror.patch ___ Python tracker ___ _

[issue17627] Datetime and time doesn't update timezone in a running Win app

2013-04-13 Thread Sijin Joseph
Sijin Joseph added the comment: Some more links discussing similar issues http://www.sourceware.org/bugzilla/show_bug.cgi?id=154 - tzset not called frequently enough by localtime() and friends http://stackoverflow.com/questions/12150651/library-code-for-dynamically-reloading-the-usr-share-zonei

[issue11957] re.sub confusion between count and flags args

2013-04-13 Thread Mike Milkin
Mike Milkin added the comment: I like option #2, and I was thinking of working on it today, poke me if anyone has a problem with this. -- nosy: +mmilkin ___ Python tracker ___ _

[issue17386] Bring Doc/make.bat as close to Doc/Makefile as possible

2013-04-13 Thread Terry J. Reedy
Terry J. Reedy added the comment: I do want to test this. If my regular machine does not get fixed soon, I will install svn on my current substitute to do so. -- ___ Python tracker

[issue17710] SystemError in cPickle for incorrect input

2013-04-13 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- versions: +Python 3.3, Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17710] SystemError in cPickle for incorrect input

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: I don't think the UnpicklingError in 3.x is a bug, though: it's just a different exception than ValueError. It's just a shame that the two are used interchangeably for the same purpose. -- stage: needs patch -> patch review versions: -Python 3.3, Pyth

[issue17671] io.BufferedRWPair can use uninitialized members

2013-04-13 Thread Stephen Tu
Stephen Tu added the comment: _forward_call() now checks if reader/write is NULL- if so, throws a runtime exception -- keywords: +patch nosy: +Stephen.Tu Added file: http://bugs.python.org/file29814/bufferedio.patch ___ Python tracker

[issue17710] SystemError in cPickle for incorrect input

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Hmm, forget what I just said. A SystemError can actually be triggered through a slightly longer line: $ ./python -c "import pickle; print (repr(pickle.loads(b\"S'\np0\n.\")))" Traceback (most recent call last): File "", line 1, in SystemError: Negative s

[issue17711] Persistent id in pickle with protocol version 0

2013-04-13 Thread Alexandre Vassalotti
Alexandre Vassalotti added the comment: In protocol 0, the persistent ID is restricted to alphanumeric strings because of the problems that arise when the persistent ID contains newline characters. _pickle likely should be changed to use the ASCII decoded. And perhaps, we should check for embe

[issue9538] Replace confusing pseudoname 'object' in special methods section.

2013-04-13 Thread peter recore
peter recore added the comment: Here is a patch that implements Eric's suggestion. I am a new contributor and would welcome feedback on if this is correct or not. -- keywords: +patch nosy: +peterrecore Added file: http://bugs.python.org/file29815/issue9538.patch __

[issue17710] SystemError in cPickle for incorrect input

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: And here is a 3.x patch. -- Added file: http://bugs.python.org/file29816/pickle_systemerror.patch ___ Python tracker ___ ___

[issue2118] smtplib.SMTP() raises socket.error rather than SMTPConnectError

2013-04-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6ca27b5de309 by R David Murray in branch '2.7': #2118: clarify smtplib exception documentation. http://hg.python.org/cpython/rev/6ca27b5de309 New changeset 36d07a877f33 by R David Murray in branch '3.3': #2118: clarify smtplib exception documentatio

[issue7152] urllib2.build_opener() skips ProxyHandler

2013-04-13 Thread Jessica McKellar
Jessica McKellar added the comment: I confirm Barry's observation in msg94150 that if you set http_proxy (or any `*_proxy` environment variable), ProxyHandler does show up in build_opener().handlers. You can also add a ProxyHandler to build_opener through the public API as described in http:/

[issue17575] HTTPConnection.send

2013-04-13 Thread Stephen Tu
Stephen Tu added the comment: I don't think this is a bug anymore in the codebase- looking at Lib/http/client.py, if hasattr(data, "read") is true, then the branch will return unconditionally. if hasattr(data, "read") : if self.debuglevel > 0: print("sendI

[issue2118] smtplib.SMTP() raises socket.error rather than SMTPConnectError

2013-04-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1158c38bf2dc by R David Murray in branch 'default': #2118: Make SMTPException a subclass of IOError. http://hg.python.org/cpython/rev/1158c38bf2dc -- ___ Python tracker

[issue17671] io.BufferedRWPair can use uninitialized members

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thanks for the patch, Stephen. Could you add a test in Lib/test/test_io.py? -- ___ Python tracker ___ __

[issue17689] Fix test discovery for test_tarfile.py

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Wouldn't it be simpler to write (untested): def skipUnlessCompressionModule(name): """ Skip if the specified compression module is not available. Must e a string, currently any of 'gzip', 'bz2', or 'lzma'. """ return unittest.skipUnless(glob

[issue2118] smtplib.SMTP() raises socket.error rather than SMTPConnectError

2013-04-13 Thread R. David Murray
R. David Murray added the comment: Thanks, Ned. After taking a look at the library documentation, I decided to change the docstring in a somewhat different way. In general in our docs we do not document all the possible exceptions a library can raise, but just the library-specific exceptions

[issue17720] pickle.py's load_appends should call append() on objects other than lists

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Your patch is bogus (duplicated load_appends definition). Also, I think you want to add a test if you want to avoid further regressions. -- ___ Python tracker _

[issue17720] pickle.py's load_appends should call append() on objects other than lists

2013-04-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, test is needed. Current tests don't cover this case. I suggest to move obj.append out of the tight loop, as in C implementation. append = obj.append for item in items: append(item) --

[issue15480] Drop TYPE_INT64 from marshal in Python 3.4

2013-04-13 Thread Dan Riti
Dan Riti added the comment: So I figured I'd give this one a shot...generated a patch to remove TYPE_INT64. Tests seem to pass, but please provide any guidance if I did something wrong! Thanks. -- keywords: +patch nosy: +dan.riti Added file: http://bugs.python.org/file29818/marshall-re

[issue13672] Add co_qualname attribute in code objects

2013-04-13 Thread James Pye
James Pye added the comment: Considering the API changes necessary for adding qualname, perhaps a better solution would be to just start using the qualname instead of the function's "basename"--co_name is the qualname. This would offer an automatic improvement to the readability of coverage/pr

[issue9297] SMTP with Sqlite3 file attached problem

2013-04-13 Thread Jessica McKellar
Jessica McKellar added the comment: murilobr, thank you for the detailed and persistent bug report :) I was not able to reproduce this issue when sending mail from myself to myself through an open Google SMTP server*, using either Python 2.7** or 3.1. Do you experience this issue with a GMail

[issue9538] Replace confusing pseudoname 'object' in special methods section.

2013-04-13 Thread Georg Brandl
Georg Brandl added the comment: Note that Sphinx searches for "object.__foo__" when :meth:`__foo__` is used; this change will break all those links. For that reason I'm -1 to this change: I don't see the perceived issue as problematic anyway. -- __

[issue17719] IDLE help text refers to incorrect Python version

2013-04-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset eac4e23ce2fd by R David Murray in branch 'default': #17719: fix incorrect version number in deprecation doc. http://hg.python.org/cpython/rev/eac4e23ce2fd -- nosy: +python-dev ___ Python tracker

[issue17719] IDLE help text refers to incorrect Python version

2013-04-13 Thread R. David Murray
R. David Murray added the comment: Thanks, Kent. For the record, the issue for the deprecation is #16123, and the issue that introduced the incorrect line is #5066. -- nosy: +r.david.murray resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed

[issue16061] performance regression in string replace for 3.3

2013-04-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset d396e0716bf4 by Serhiy Storchaka in branch 'default': Issue #16061: Speed up str.replace() for replacing 1-character strings. http://hg.python.org/cpython/rev/d396e0716bf4 -- nosy: +python-dev ___ Python

[issue16061] performance regression in string replace for 3.3

2013-04-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks to Ezio Melotti and Daniel Shahaf for their great help in correcting my clumsy wording. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue17659] no way to determine First weekday (based on locale)

2013-04-13 Thread Kyle McMartin
Kyle McMartin added the comment: Hacky patch at adding support for querying these values from nl_langinfo, and a new exported function from the locale module to return a guess at the first day of the week appropriate for Calendar.firstdayofweek After writing this, I think it might be better to

[issue2118] smtplib.SMTP() raises socket.error rather than SMTPConnectError

2013-04-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Since 3.3 IOError is an alias of OSError. We get rid of reference of IOError and other OSError aliases in the documentation and code, replacing them with OSError. -- nosy: +serhiy.storchaka ___ Python tracker

[issue9682] socket.create_connection error message for domain subpart with invalid length is very confusing

2013-04-13 Thread R. David Murray
R. David Murray added the comment: Thanks, Mike. I made some review comments (you should have gotten an email, or look at them via the 'review' link on the patch). -- ___ Python tracker ___

[issue2118] smtplib.SMTP() raises socket.error rather than SMTPConnectError

2013-04-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: socket.error is another alias of OSError. -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue17722] 'round' function doesn't honour a descriptor __round__

2013-04-13 Thread Mark Dickinson
Mark Dickinson added the comment: Whoops. That patch introduces a new refleak; will fix shortly. -- ___ Python tracker ___ ___ Pytho

[issue17722] 'round' function doesn't honour a descriptor __round__

2013-04-13 Thread Mark Dickinson
New submission from Mark Dickinson: Benjamin pointed out on #python-dev that the builtin round function should be using _PyObject_LookupSpecial to look up the __round__ method. Here's a fix. -- components: Interpreter Core files: round_descriptor.patch keywords: patch messages: 186813

[issue16694] Add pure Python operator module

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Zachary, I suppose Modules/_operator.c is a rename of Modules/operator.c. Could you generate your patch using "hg diff --git" so that history isn't lost here? See also http://docs.python.org/devguide/committing.html#minimal-configuration -- nosy: +pitr

[issue17711] Persistent id in pickle with protocol version 0

2013-04-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Even for alphanumeric strings Python 3 have a bug. It saves strings and load bytes objects. -- ___ Python tracker ___ ___

[issue17722] 'round' function doesn't honour a descriptor __round__

2013-04-13 Thread Mark Dickinson
Mark Dickinson added the comment: Non-leaky patch. -- Added file: http://bugs.python.org/file29821/round_descriptor2.patch ___ Python tracker ___

[issue13510] Clarify that readlines() is not needed to iterate over a file

2013-04-13 Thread Dan Riti
Dan Riti added the comment: After reading the comments, I generated a patch that does the following: - Reorganize to present `for line in f:` as the first approach for reading lines. I refrained from saying it's the *preferred* approach, however I can add that if desired. - Reorganize to prese

[issue17713] test_logging fails in test_compute_rollover_weekly_attime

2013-04-13 Thread Shaun Hickson
Shaun Hickson added the comment: I was looking at this yesterday and this morning a little bit, and the expected value is too large by a day (e.g. as the test currently runs, actual = expected - (24 * 60 * 60)). -- nosy: +sphickson ___ Python tracke

[issue16273] f.tell() returning negative number on Windows build

2013-04-13 Thread Sijin Joseph
Sijin Joseph added the comment: Attaching a patch with a doc update to the tutorial, specifying that 1. The return value from f.tell is an opaque number for text files. 2. When seeking using text files the offset value needs to come from f.tell(). http://docs.python.org/3.4/library/io.html#io.T

[issue16273] f.tell() returning negative number on Windows build

2013-04-13 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- assignee: -> docs@python components: +Documentation, IO -Interpreter Core nosy: +docs@python priority: high -> normal stage: test needed -> patch review versions: +Python 3.3, Python 3.4 -Python 2.7 ___ Python tracker

[issue17710] SystemError in cPickle for incorrect input

2013-04-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Of course, UnpicklingError is not a bug. Perhaps almost any exception except SystemError is not a bug. I mention it because it's a case where Python 3 differs from Python 2. I think _pickle.c patches can be simplified. +if (len < 2) +goto insecu

[issue17710] SystemError in cPickle for incorrect input

2013-04-13 Thread Alexandre Vassalotti
Alexandre Vassalotti added the comment: I also wrote a patch for this. I took I slightly different approach though. I fixed the C implementation to be more strict on the quoting. Currently, it strips trailing non-printable characters, something pickle.py doesn't do. I also cleaned up the tests

[issue17710] SystemError in cPickle for incorrect input

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Alexandre, I don't like your patch very much: - you are changing the exception from ValueError to UnpicklingError (which doesn't derive from ValueError) in a bugfix release - you aren't actually adding any guards in the C code, so it's not demonstrably more rob

[issue9538] Replace confusing pseudoname 'object' in special methods section.

2013-04-13 Thread peter recore
peter recore added the comment: George, When I build the docs with my changes, the links from the method names seem to work the same way as they do in the existing docs. -- ___ Python tracker _

[issue11957] re.sub confusion between count and flags args

2013-04-13 Thread Mike Milkin
Mike Milkin added the comment: There is no sane way to issue a warning without changing the signature and we don't want to change the signature without issuing a deprecation warning for the function, so sadly option 3 is the only way for this to work, (Im going to not touch this till ENUMS are

[issue15480] Drop TYPE_INT64 from marshal in Python 3.4

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thank you, Daniel. The patch looks technically ok. Could you sign a contributor agreement? It will cover all your future contributions to Python: http://www.python.org/psf/contrib/ -- nosy: +pitrou ___ Python tracke

[issue13510] Clarify that readlines() is not needed to iterate over a file

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: In 3.x I think we'll want to drop the following sentence: "Since the two approaches manage line buffering differently, they should not be mixed". But it can wait for another issue. -- nosy: +pitrou ___ Python tracke

[issue15480] Drop TYPE_INT64 from marshal in Python 3.4

2013-04-13 Thread Dan Riti
Dan Riti added the comment: Antoine, I just filled one out maybe 2 hours ago (I'm at a CPython sprint in Boston). https://secure.echosign.com/public/viewAgreement?aid=T8FLXZG5LX3W2N&eid=T8GPRVI62IXF2Y&; -- ___ Python tracker

[issue995907] memory leak with threads and enhancement of the timer class

2013-04-13 Thread Yael
Yael added the comment: I am working on a patch for a new class that uses a single background thread, it should be ready soon. One unintended consequence of this change is that with one thread, multiple timers that have the same timeout will no longer run in parallel, but one after the other.

[issue15480] Drop TYPE_INT64 from marshal in Python 3.4

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Antoine, I just filled one out maybe 2 hours ago (I'm at a CPython > sprint in Boston). Ah, great, thank you! -- ___ Python tracker ___ _

[issue15480] Drop TYPE_INT64 from marshal in Python 3.4

2013-04-13 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue17707] Multiprocessing queue get method does not block for short timeouts

2013-04-13 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: Assigning to me. Will get back in 1 or 2 days. -- assignee: -> giampaolo.rodola ___ Python tracker ___ _

[issue11957] re.sub confusion between count and flags args

2013-04-13 Thread Ezio Melotti
Ezio Melotti added the comment: Can't you use *args and **kwargs and then raise a deprecation warning if count and/or flags are in args? Even if enums are merged in, there might still be issues depending on their implementation. -- ___ Python tracke

[issue17301] An in-place version of many bytearray methods is needed

2013-04-13 Thread Ned Jackson Lovely
Ned Jackson Lovely added the comment: An mtranslate, or "mutating translate" method for bytearrays. My first C code in a long time, so be gentle. The name is bad, but I don't see a better suggestion below. -- keywords: +patch nosy: +n Added file: http://bugs.python.org/file29825/issue1

[issue7100] test_xmlrpc: global name 'stop_serving' is not defined

2013-04-13 Thread Jessica McKellar
Jessica McKellar added the comment: To summarize (as I understand it) the state of this ticket: * stop_serving no longer exists anywhere in the code base, so the proximal cause of the bug report from 2009 no longer exists. * the tests in test_xmlrpc currently all pass without issue. * If you

[issue17710] SystemError in cPickle for incorrect input

2013-04-13 Thread Alexandre Vassalotti
Alexandre Vassalotti added the comment: I was targeting head, not the release branches. It is fine to change the exception there as we don't make any guarantee about the exceptions raised during the unpickling process. It is easy enough to fix patch use ValueError for the release branch. And

[issue15480] Drop TYPE_INT64 from marshal in Python 3.4

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: So, I've just tweaked the patch a bit so that ints longer than machine size are still tested for. Congrats for your first contribution! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed __

[issue17710] SystemError in cPickle for incorrect input

2013-04-13 Thread Alexandre Vassalotti
Changes by Alexandre Vassalotti : Removed file: http://bugs.python.org/file29824/fix_quoted_string_python3.patch ___ Python tracker ___ ___ Py

[issue15480] Drop TYPE_INT64 from marshal in Python 3.4

2013-04-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 74a440984b20 by Antoine Pitrou in branch 'default': Issue #15480: Remove the deprecated and unused TYPE_INT64 code from marshal. http://hg.python.org/cpython/rev/74a440984b20 -- nosy: +python-dev ___ Pyth

[issue15480] Drop TYPE_INT64 from marshal in Python 3.4

2013-04-13 Thread Dan Riti
Dan Riti added the comment: Looks great, thanks Antoine! =) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue7100] test_xmlrpc: global name 'stop_serving' is not defined

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Indeed, this issue looks obsolete. Thanks for taking a look! -- resolution: -> out of date stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker __

[issue17016] _sre: avoid relying on pointer overflow

2013-04-13 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- components: +Extension Modules resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed versions: -Python 3.2 ___ Python tracker _

[issue17016] _sre: avoid relying on pointer overflow

2013-04-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you, Nickolai, for the patch. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue2118] smtplib.SMTP() raises socket.error rather than SMTPConnectError

2013-04-13 Thread Andrew Svetlov
Andrew Svetlov added the comment: Agree with Serhiy. Better to direcly use OSError than IOError alias. -- nosy: +asvetlov ___ Python tracker ___ __

[issue17705] Fill Character cannot be \0

2013-04-13 Thread Jason Michalski
Jason Michalski added the comment: I worked on a patch that allows NUL padding for longs, floats and complex numbers. It seems NUL was being used as a sentinel in the format string parsing when no padding character is given. It was then replaced with a space in each call to fill_padding if it

[issue17713] test_logging fails in test_compute_rollover_weekly_attime

2013-04-13 Thread Shaun Hickson
Shaun Hickson added the comment: Patch to fix test_compute_rollover_weekly_attime: 1) Use 6 rather than 7 for calculating expected rollover day 2) Roll all cases (rollover day earlier than current day, both days the same, and current day earlier than rollover day) into one if/else statement -

[issue11957] re.sub confusion between count and flags args

2013-04-13 Thread Mike Milkin
Mike Milkin added the comment: We could do that but we would be changing the signature before adding the warning -- ___ Python tracker ___ __

[issue17713] test_logging fails in test_compute_rollover_weekly_attime

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Shaun, your patch fails if I remove the @skip decorator: == FAIL: test_compute_rollover_weekly_attime (test.test_logging.TimedRotatingFileHandlerTest) --

[issue5993] python produces zombie in webbrowser.open

2013-04-13 Thread Shaun Hickson
Shaun Hickson added the comment: Just as an additional data point, I was also unable to recreate this on OS X 10.8.3 using any browser. -- nosy: +sphickson ___ Python tracker ___

[issue17713] test_logging fails in test_compute_rollover_weekly_attime

2013-04-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: I also find the original code totally unreadable. Why "currentTime = 0"? Why no comments on the various calculations? Vinay, it would be nice if you could make some efforts here. -- ___ Python tracker

[issue17722] 'round' function doesn't honour a descriptor __round__

2013-04-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Perhaps it will be good to add a new test when X doesn't not have a special method. I don't see this case is covered. -- nosy: +serhiy.storchaka ___ Python tracker _

[issue17723] Use FileRead and FileWrite in fileio.c on Windows

2013-04-13 Thread John Ehresman
New submission from John Ehresman: File object's can use the win32 api FileRead and FileWrite instead of the CRT's read & write function. This would eliminate the need to set the mode to binary on stdin & stdout, which is the underlying cause of issue 16587. This could also possibly be the b

[issue17723] Use FileRead and FileWrite in fileio.c on Windows

2013-04-13 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +haypo, sbt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue2118] smtplib.SMTP() raises socket.error rather than SMTPConnectError

2013-04-13 Thread Ned Jackson Lovely
Ned Jackson Lovely added the comment: s/IOError/OSError/ -- Added file: http://bugs.python.org/file29830/issue2118-OSError.diff ___ Python tracker ___

[issue4140] urllib2: request with digest auth through proxy fail

2013-04-13 Thread Jessica McKellar
Jessica McKellar added the comment: jan.kollhof, thanks for the report and your work on this ticket! The format of the client response to a server's digest challenge is detailed in RFC 2617, section 3.2.2: The Authorization Request Header. The urllib2.py attachment is unfortunately the whole f

[issue16273] f.tell() returning negative number on Windows build

2013-04-13 Thread Armin Rigo
Changes by Armin Rigo : -- nosy: -arigo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue16587] Py_Initialize breaks wprintf on Windows

2013-04-13 Thread John Ehresman
John Ehresman added the comment: One way to fix this is to use the FileRead & FileWrite api functions directly as proposed in issue 17723 I would regard this as a change in behavior and not a simple bug fix because there is probably code written for 3.3 that assumes the C level stdout is in b

[issue17724] urllib -- add_handler method refactoring for clarity

2013-04-13 Thread Max Mautner
New submission from Max Mautner: Response handlers are registered with the OpenerDirector class in the urllib.request module using the add_handler method--it's a convoluted method that I refactored for legibility's sake. -- files: urllib_add_handler.patch keywords: patch messages: 1868

[issue17722] 'round' function doesn't honour a descriptor __round__

2013-04-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset cc59c215f19e by Benjamin Peterson in branch 'default': properly lookup the __round__ special method (closes #17722) http://hg.python.org/cpython/rev/cc59c215f19e -- nosy: +python-dev resolution: -> fixed stage: patch review -> committed/rej

[issue17722] 'round' function doesn't honour a descriptor __round__

2013-04-13 Thread Benjamin Peterson
Benjamin Peterson added the comment: Sorry for trampling on you; I had a patch already in my wc. -- nosy: +benjamin.peterson ___ Python tracker ___ __

[issue11957] re.sub confusion between count and flags args

2013-04-13 Thread Ezio Melotti
Ezio Melotti added the comment: The change would still be backwards compatible (even though inspect.signature and similar functions might return something different). Note that I'm not saying that's the best option, but it should be doable. -- ___

[issue17694] Enhance _PyUnicodeWriter API to control minimum buffer length without overallocation

2013-04-13 Thread Vladimir Korolev
Vladimir Korolev added the comment: I'd like to note that the actual patch was written by Adam.Duston http://bugs.python.org/user17706 I just verified the results, measured the time/memory performance submitted the patch. -- ___ Python tracker

[issue17694] Enhance _PyUnicodeWriter API to control minimum buffer length without overallocation

2013-04-13 Thread Vladimir Korolev
Vladimir Korolev added the comment: We have this issue triaged for at CPython hackathon in Boston. Here is a patch for the issue. We only tested on Mac OS X 10.8.3, which has zoned allocator, so the memory profile is exactly the same with our without this patch. The running time seems t

[issue17694] Enhance _PyUnicodeWriter API to control minimum buffer length without overallocation

2013-04-13 Thread Vladimir Korolev
Vladimir Korolev added the comment: For some reason can't figure out how to attach multiple files. So here is the benchmark module -- Added file: http://bugs.python.org/file29833/benchmark.py ___ Python tracker _

[issue17722] 'round' function doesn't honour a descriptor __round__

2013-04-13 Thread Mark Dickinson
Mark Dickinson added the comment: No problem. Do you usually keep patches in your WC? -- ___ Python tracker ___ ___ Python-bugs-list

[issue17722] 'round' function doesn't honour a descriptor __round__

2013-04-13 Thread Benjamin Peterson
Benjamin Peterson added the comment: In this case, I had almost finished a patch as I was talking with you on IRC, but I had to go play in a show for 3 hours. -- ___ Python tracker

[issue15301] os.chown: OverflowError: Python int too large to convert to C long

2013-04-13 Thread Mark Dickinson
Mark Dickinson added the comment: +1 on using PyNumber_Index. -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mai

[issue9682] socket.create_connection error message for domain subpart with invalid length is very confusing

2013-04-13 Thread Mike Milkin
Mike Milkin added the comment: Made changes to to the tests and made changes to the error messages. I think decode() is valid since the input is already ascii encoded. -- Added file: http://bugs.python.org/file29834/Issue9682-full.patch ___ Python tr

<    1   2   3   >