[issue15518] Provide test coverage for filecmp.dircmp.report methods.

Chris Calloway added the comment: The attached file test_filecmp_layouts.rst documents the directory and file layouts for complete test coverage of filecmp.dircmp report methods to aid in review discussion of patch. -- Added file: http://bugs.python.org/file29745/test_filecmp_layouts.r

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

Chris Calloway added the comment: The attached file test_filecmp_reports.rst documents the reports generated by filecmp.dircmp test methods if the directory and file layouts in test_filecmp_layouts.rst are followed to aid in review discussion of patch. -- Added file: http://bugs.python

[issue17670] expandtabs() weirdness

Ned Deily added the comment: Yes, the behavior is by design. I think you are misunderstanding how exandtabs() works. The "tabsize" argument indicates the number of columns each tab position occupies. So, with a tabsize of 4, the tab positions occur every four columns; the tab positions are

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

Chris Calloway added the comment: The attached patch issue-15518-1.patch replaces previous patch proposals for this issue. The patch implements the suggestion to factor code common to report TestCase classes into a common base class BaseReportTestCase. Apologies for not having that in the pre

[issue17669] Segfault caused by weird combination of imports and yield from

R. David Murray added the comment: The crashing version has 'import logging' at the top of generators.py. I did not experience a crash when it was absent even if there was no __pycache__. It also doesn't crash if the import is moved out of the body of first_gen. FAULTHANDLER doesn't fair too

[issue17657] IDLE: about dialog should report the full version of TK

Roundup Robot added the comment: New changeset 9b6de25c6054 by Roger Serwy in branch '2.7': #17657: Show full Tk version in IDLE's about dialog. http://hg.python.org/cpython/rev/9b6de25c6054 New changeset 769699f0a760 by Roger Serwy in branch '3.3': #17657: Show full Tk version in IDLE's about d

[issue16427] Faster hash implementation

Changes by Raymond Hettinger : -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue17589] Make documentation about macros in C API explicit about rvalue vs statement

Larry Hastings added the comment: Amaury: I'd appreciate it if you'd bring those examples up on bug 17206. If we're going to change the semantics of Py_INCREF I'd prefer we did it with our eyes wide open. -- ___ Python tracker

[issue17657] IDLE: about dialog should report the full version of TK

Roger Serwy added the comment: Let's discuss improving the about dialog on idle-dev or in a new issue. Thanks for the patch, Todd! -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue17589] Make documentation about macros in C API explicit about rvalue vs statement

Larry Hastings added the comment: Oh, and, yes, it's true that Py_RETURN_NONE currently takes advantage of Py_INCREF being an rvalue, and changing Py_INCREF to a statement would break the existing implementation. But Py_RETURN_NONE itself is of necessity a statement. We would simply change

[issue17669] Segfault caused by weird combination of imports and yield from

Benjamin Peterson added the comment: This is the patch. I'll have to think about whether there's a self-contained way to test this. -- assignee: -> benjamin.peterson keywords: +patch Added file: http://bugs.python.org/file29748/gen_fix.patch ___ Pyt

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

Changes by Chris Calloway : Removed file: http://bugs.python.org/file29747/issue-15518-1.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

Chris Calloway added the comment: Fix calls to BaseReportTestCase methods in subclasses. Not an override so don't need super(). -- Added file: http://bugs.python.org/file29749/issue-15518-1.patch ___ Python tracker

[issue17672] ssl clean shutdown

New submission from Hiroaki Kawai: When using ssl module, I sometimes get unexpected error. The observed error varies in different situations. After the investigation, I found the reason was that ssl shutdown was not performed and sometimes RST was sent over the network instead of FIN. I crea

[issue17511] Idle find function closes after each find operation

Roger Serwy added the comment: I tried the patch against 2.7 and it appears to work, but might introduce another interface problem. The search dialog opens up as a modal window which disallows the user from changing the text. This may or may not be desirable. The technique of using the "hit"

[issue17672] ssl unclean shutdown

Changes by Hiroaki Kawai : -- title: ssl clean shutdown -> ssl unclean shutdown ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue17668] re.split loses characters matching ungrouped parts of a pattern

Tomasz J. Kotarba added the comment: Hi, I can still see one piece of functionality I have mentioned missing. Using my first example, even when one uses '^(>(.*))$' one cannot get ['', '>Homo sapiens catenin (cadherin-associated)', ''] as one will get a four-element list and need to deal with

[issue17648] test_urllib2 convert doctests to unittest

Roundup Robot added the comment: New changeset eb632aafff57 by Senthil Kumaran in branch 'default': #17648 - Clean up test_urllib2.py. Converted doctests to unittest for http://hg.python.org/cpython/rev/eb632aafff57 -- nosy: +python-dev ___ Python tra

[issue17648] test_urllib2 convert doctests to unittest

Senthil Kumaran added the comment: I have pushed the changes since they are restricted to test files. If there are review comments, I shall do make the changes. I shall consider to to make 3.3 tests close to default branch ones so that fixes can be backported. (Leaving the bug open for that).

[issue6640] urlparse should parse mailto: URL headers as query parameters

Senthil Kumaran added the comment: RFC3986 bears the weightage since urlparse aims to satisfy that. As per that, mailto should return the url as path, and current urlparse behaves properly. $ ./python.exe Python 3.4.0a0 (default:50164abbfc98+, Apr 8 2013, 22:19:34) [GCC 4.2.1 (Apple Inc. build

[issue6640] urlparse should parse mailto: URL headers as query parameters

Changes by Senthil Kumaran : -- resolution: fixed -> invalid ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue12181] SIGBUS error on OpenBSD (sparc64)

Charles-François Natali added the comment: > New version hopefully good and ready for inclusion. Looks good to me. Since I assume you tested your patch on OpenBSD, to me it's ready for commit. I won't be able to do it myself before two weeks though, so if someone beats me to it, go ahead! > Ple

[issue12181] SIGBUS error on OpenBSD (sparc64)

Changes by Charles-François Natali : -- versions: +Python 3.3, Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue17661] documentation of '%r' links to the wrong repr

Éric Araujo added the comment: Thanks for catching this; Sphinx’ lookup is confusing sometimes. Using `.repr` or something similar will fix it. -- nosy: +eric.araujo, ezio.melotti ___ Python tracker _

[issue17659] First weekday

Éric Araujo added the comment: I’m not sure I understand the request. Is it that you want to know if you should e.g. display a calendar with Monday or Sunday in the first column depending on the user country? It looks like this could belong in the locale or calendar module, if there is a cle

[issue17661] documentation of '%r' links to the wrong repr

Georg Brandl added the comment: It just highlights the mistake we made calling a builtin module the same name as a builtin function :) -- nosy: +georg.brandl ___ Python tracker

[issue17511] Idle find function closes after each find operation

Terry J. Reedy added the comment: The modal versus non-modal issue, plus the Windows hi-lite issue, may partly explain the current design. It is actually quite usable once understood. The problem is that the current sparse doc does not adequately explain the intention - use ^F once to set the

[issue17668] re.split loses characters matching ungrouped parts of a pattern

R. David Murray added the comment: Only group the stuff you want to see in the result: >>> re.split(r'(^>.*$)', '>Homo sapiens catenin (cadherin-associated)') ['', '>Homo sapiens catenin (cadherin-associated)', ''] >>> re.split(r'^(>.*)$', '>Homo sapiens catenin (cadherin-associated)') ['', '>H

[issue17659] First weekday

R. David Murray added the comment: I believe the request is exactly a function in the locale module to expose the locale-dependent calendar-week-start-day information based on the algorithm in the linked articles. As for being able to pass in the locale, that's a general problem with the curr

[issue17487] wave.Wave_read.getparams should be more user friendly

Claudiu.Popa added the comment: Hello. I received the confirmation for my CLA, could you commit the patch? Thank you! -- ___ Python tracker ___ _

[issue17206] Py_XDECREF() expands its argument multiple times

Amaury Forgeot d'Arc added the comment: As I wrote in issue17589, there are some extension modules (pytables) that which assume that Py_INCREF is an expression: return Py_INCREF(x), x; and Py_RETURN_NONE is also defined with a comma expression. Oh, and Cython: #define __Pyx_PyBool_FromLong(b)

<    1   2