[issue14127] add st_*time_ns fileds to os.stat(), add ns keyword to os.*utime*(), os.*utimens*() expects a number of nanoseconds

2012-03-16 Thread Larry Hastings
Larry Hastings added the comment: Updated patch incorporating only one of Antoine's latest suggestions. Please see my reply on Reitveld for r3 as to why I skipped two of your three suggestions. -- Added file: http://bugs.python.org/file24884/larry.st_mtime_ns.patch.4.txt ___

[issue10484] http.server.is_cgi fails to handle CGI URLs containing PATH_INFO

2012-03-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: Actually no. I revert back my previous statement. Meddling with splitpath breaks all the tests. -- ___ Python tracker ___ __

[issue13709] Capitalization mistakes in the documentation for ctypes

2012-03-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset d2460ff173ff by Eli Bendersky in branch 'default': Issue #13709: some fixes to the ctypes documentation. In addition to fixing http://hg.python.org/cpython/rev/d2460ff173ff -- nosy: +python-dev ___ Pytho

[issue13709] Capitalization mistakes in the documentation for ctypes

2012-03-16 Thread Eli Bendersky
Eli Bendersky added the comment: Fixed in 3.3 I don't think this is important enough to spend time on backporting. -- resolution: -> fixed stage: needs patch -> commit review status: open -> closed versions: +Python 3.3 ___ Python tracker

[issue2486] Recode (parts of) decimal module in C

2012-03-16 Thread Mark Dickinson
Mark Dickinson added the comment: No, this should be closed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14320] set.add can return boolean indicate newly added item

2012-03-16 Thread Matt Joiner
Matt Joiner added the comment: Is there still some value to at least exposing this in the C API, per the precedents I mentioned? The patch also contains some adjustment to the set_add_entry/set_add_key abstraction dance, and some future proofing of PySet_Add return values that have merit on

[issue14333] queue unittest errors

2012-03-16 Thread Matt Joiner
New submission from Matt Joiner : $ python3.3 -m unittest test.test_queue Generates errors in the unit test code of the form AttributeError: 'BaseQueueTest' object has no attribute 'type2test' -- components: Tests messages: 156006 nosy: anacrolix, benjamin.peterson, rhettinger priority

[issue10484] http.server.is_cgi fails to handle CGI URLs containing PATH_INFO

2012-03-16 Thread Glenn Linderman
Glenn Linderman added the comment: I'm not sure what tests break or why, I suppose it is the ones for the security patch. I'm not sure which code you are referring to... the code in msg122259 I tested only cursorily, the (different) code in issue 13893 is what I'm running today, and so has b

[issue2486] Recode (parts of) decimal module in C

2012-03-16 Thread Mark Dickinson
Changes by Mark Dickinson : -- resolution: -> rejected status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue8739] Update to smtpd.py to RFC 5321

2012-03-16 Thread Michele Orrù
Michele Orrù added the comment: David: yes, I did. About two weeks ago. Probably I'll take a look to those issues :) -- ___ Python tracker ___ ___

[issue8739] Update to smtpd.py to RFC 5321

2012-03-16 Thread Michele Orrù
Michele Orrù added the comment: David, can you tag this issue as dependency for issue14261 ? -- ___ Python tracker ___ ___ Python-bugs

[issue10484] http.server.is_cgi fails to handle CGI URLs containing PATH_INFO

2012-03-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset bab9f29c93fd by Senthil Kumaran in branch '2.7': 2.7 - Issue #10484: Fix the CGIHTTPServer's PATH_INFO handling problem http://hg.python.org/cpython/rev/bab9f29c93fd New changeset 88c86869ce92 by Senthil Kumaran in branch '3.2': closes issue10484 -

[issue10484] http.server.is_cgi fails to handle CGI URLs containing PATH_INFO

2012-03-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: I treated this as a regression from 2.6. A cgi url with /cgi-bin/hello.py/hello/world would have PATH_INFO as '/hello/world' I saw some apache specs saying that it should be 'hello/world', but I relied on python2.6's behavior with had initial '/'. Glenn, I

[issue10487] http.server doesn't process Status header from CGI scripts

2012-03-16 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue10487] http.server doesn't process Status header from CGI scripts

2012-03-16 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- superseder: -> Make CGIHTTPServer capable of redirects (and status other than 200) ___ Python tracker ___ __

[issue10485] http.server fails when query string contains addition '?' characters

2012-03-16 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue10484] http.server.is_cgi fails to handle CGI URLs containing PATH_INFO

2012-03-16 Thread Glenn Linderman
Glenn Linderman added the comment: In reviewing my code in this area, I also see that in addition to fixing _url_collapse_path_split, I override the location that uses it, which is the is_cgi function. Here is my code for the override, which actually creates a proper PATH_INFO string:

[issue10484] http.server.is_cgi fails to handle CGI URLs containing PATH_INFO

2012-03-16 Thread Glenn Linderman
Glenn Linderman added the comment: Senthil, the patch you submitted breaks the encapsulation of cgi_directories -- this should be changeable per particular application via subclassing or assignment, but you've built those directories into the code. Perhaps you should take a look at my code f

[issue10484] http.server.is_cgi fails to handle CGI URLs containing PATH_INFO

2012-03-16 Thread Glenn Linderman
Glenn Linderman added the comment: Another issue with the patch, is that it doesn't do .. and . collapsing on the PATH_INFO part of the path. It is possible for a path like /cgi-bin/script.py/../../plain-file.html to be passed to the server. I guess the question is if it should serve plain

[issue10484] http.server.is_cgi fails to handle CGI URLs containing PATH_INFO

2012-03-16 Thread Glenn Linderman
Glenn Linderman added the comment: I just tested what Apache does with such a path as /cgi-bin/script.py/../../plain-file.html, and it serves the plain-file.html. -- ___ Python tracker ___

[issue14202] The docs of xml.dom.pulldom are almost nonexistent

2012-03-16 Thread Florian Mladitsch
Changes by Florian Mladitsch : -- keywords: +patch Added file: http://bugs.python.org/file24885/xml.dom.pulldom.rst.patch ___ Python tracker ___ _

[issue14133] improved PEP 409 implementation

2012-03-16 Thread Nick Coghlan
Nick Coghlan added the comment: With the decision on whether or not to suppress the context moved out to a separate flag, I think we need to allow it. Requiring that the flag be False *and* that the context also be None gets us back to asking the question of why the flag doesn't work when the

[issue14334] Invalid free in _PyUnicode_Ready()

2012-03-16 Thread Stefan Krah
New submission from Stefan Krah : Hi -- I'm getting a segfault running the attached crasher.py script. Valgrind traces it down to an Invalid free() / delete / delete[] in _PyUnicode_Ready(). Reproduce: == Rev: 870c0ef7e8a2 Build: ./configure --without-pymalloc CFLAGS="-O0 -g" && make $

[issue14202] The docs of xml.dom.pulldom are almost nonexistent

2012-03-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 172630a3e6d8 by Eli Bendersky in branch '3.2': Issue #14202: Greatly enhance the documentation of xml.dom.pulldom. http://hg.python.org/cpython/rev/172630a3e6d8 New changeset 5d118a154ba3 by Eli Bendersky in branch 'default': Issue #14202: Greatly

[issue14202] The docs of xml.dom.pulldom are almost nonexistent

2012-03-16 Thread Eli Bendersky
Eli Bendersky added the comment: I committed the patch after some minor modifications, to 3.2 and 3.3 Florian, thanks for the contribution! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed versions: +Python 3.2 -Python 2.7 _

[issue14325] Stop using the garbage collector to manage the lifetime of the getargs.c freelist

2012-03-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9fc456ac20cf by Jean-Paul Calderone in branch 'default': Issue #14325: Stop using python lists, capsules, and the garbage collector to deal with PyArg_Parse* cleanup. http://hg.python.org/cpython/rev/9fc456ac20cf -- nosy: +python-dev

[issue14325] Stop using the garbage collector to manage the lifetime of the getargs.c freelist

2012-03-16 Thread Jean-Paul Calderone
Changes by Jean-Paul Calderone : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue11379] Remove "lightweight" from minidom description

2012-03-16 Thread Eli Bendersky
Eli Bendersky added the comment: Éric, what else would you like to do here? -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue14334] Invalid free in _PyUnicode_Ready()

2012-03-16 Thread Stefan Krah
Stefan Krah added the comment: 3.2 also crashes. 2.7 runs fine. So it's certainly not related to the new Unicode API. -- versions: +Python 3.2 ___ Python tracker ___ ___

[issue14325] Stop using the garbage collector to manage the lifetime of the getargs.c freelist

2012-03-16 Thread Eli Bendersky
Eli Bendersky added the comment: This is cool! Any benchmark / speedup data? -- nosy: +eli.bendersky ___ Python tracker ___ ___ Pytho

[issue14325] Stop using the garbage collector to manage the lifetime of the getargs.c freelist

2012-03-16 Thread Jean-Paul Calderone
Jean-Paul Calderone added the comment: If it's a bit faster, that'd be a nice win, but I didn't benchmark. I'm primarily interested in correctness in the PyPy case (PyPy re-uses this code), and I think CPython benefits from the slightly simplified code as well. If you do any benchmarks, I'd

[issue14128] _elementtree should expose types and factory functions consistently with ElementTree

2012-03-16 Thread Eli Bendersky
Eli Bendersky added the comment: The TreeBuilder constructor in _elemettree doesn't accept arguments, contrary to the documentation. Added a (currently marked as failing) test. -- ___ Python tracker _

[issue14334] Crash: getattr(type, '__getattribute__')(type, type)

2012-03-16 Thread Stefan Krah
Stefan Krah added the comment: I've traced it down to this line: >>> getattr(type, '__getattribute__')(type, type) Segmentation fault Setting to 'normal', since there are apparently more of these. -- priority: high -> normal title: Invalid free in _PyUnicode_Ready() -> Crash: getattr

[issue11379] Remove "lightweight" from minidom description

2012-03-16 Thread Éric Araujo
Éric Araujo added the comment: I’ll soon have a revised version of my patch to address your feedback. -- ___ Python tracker ___ ___ P

[issue14320] set.add can return boolean indicate newly added item

2012-03-16 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue14335] Reimplement multiprocessing's ForkingPickler using dispatch_table

2012-03-16 Thread sbt
New submission from sbt : The attached patch reimplements ForkingPickler using the new dispatch_table attribute. This allows ForkingPickler to subclass Pickler (implemented in C) instead of _Pickler (implemented in Python). -- components: Library (Lib) files: mp_forking_pickler.patch

[issue14334] Crash: getattr(type, '__getattribute__')(type, type)

2012-03-16 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: One-line crasher: type.__getattribute__(type, type) Python 2.7 does not crash reliably, but is not exempt from the bug: type.__getattribute__(type, 1.1j) -- nosy: +amaury.forgeotdarc ___ Python tracker

[issue14009] Clearer documentation for cElementTree

2012-03-16 Thread Éric Araujo
Éric Araujo added the comment: I will commit the patch, keeping the indexing in 3.3 as agreed. I just moved to a new city, so today is paperwork day but in the evening or tomorrow I’ll do Python work :) -- versions: +Python 3.3 ___ Python tracker

[issue14230] Delegating generator is not always visible to debugging tools such as inspect & pdb

2012-03-16 Thread Matt Joiner
Matt Joiner added the comment: This changeset has broken something. All I get is a confusing backtrace ending with: File "/home/matt/src/python-torrent/torrent/bencode.py", line 15, in encode yield from encode(k) AttributeError: 'list_iterator' object has no attribute 'send' Backing out

[issue14230] Delegating generator is not always visible to debugging tools such as inspect & pdb

2012-03-16 Thread Benjamin Peterson
Benjamin Peterson added the comment: 2012/3/16 Matt Joiner : > > Matt Joiner added the comment: > > This changeset has broken something. All I get is a confusing backtrace > ending with: > >  File "/home/matt/src/python-torrent/torrent/bencode.py", line 15, in encode >    yield from encode(k)

[issue14230] Delegating generator is not always visible to debugging tools such as inspect & pdb

2012-03-16 Thread Benjamin Peterson
Benjamin Peterson added the comment: Nevermind, I think I see the problem. 2012/3/16 Benjamin Peterson : > > Benjamin Peterson added the comment: > > 2012/3/16 Matt Joiner : >> >> Matt Joiner added the comment: >> >> This changeset has broken something. All I get is a confusing backtrace >>

[issue14230] Delegating generator is not always visible to debugging tools such as inspect & pdb

2012-03-16 Thread Benjamin Peterson
Benjamin Peterson added the comment: Can you possibly create a small example that fails? -- ___ Python tracker ___ ___ Python-bugs-li

[issue12338] multiprocessing.util._eintr_retry doen't recalculate timeouts

2012-03-16 Thread sbt
sbt added the comment: _eintr_retry is currently unused. The attached patch removes it. If it is retained then we should at least add a warning that it does not recalculate timeouts. -- keywords: +patch Added file: http://bugs.python.org/file24888/mp_remove_eintr_retry.patch ___

[issue14202] The docs of xml.dom.pulldom are almost nonexistent

2012-03-16 Thread Éric Araujo
Éric Araujo added the comment: Thanks to you both, the new docs are greatly better! Eli, why not backporting to 2.7 too? It has the same rules and should get the same attention as 3.2. BTW, when you nest class/method directives, you needn’t repeat the class name in the method directives:

[issue14334] Crash: getattr(type, '__getattribute__')(type, type)

2012-03-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset b7bad204b34f by Benjamin Peterson in branch '3.2': check to make sure the attribute is a string (#14334) http://hg.python.org/cpython/rev/b7bad204b34f New changeset e44591015cf0 by Benjamin Peterson in branch 'default': merge 3.2 (#14334) http://hg

[issue14230] Delegating generator is not always visible to debugging tools such as inspect & pdb

2012-03-16 Thread Mark Shannon
Mark Shannon added the comment: The magic number has not been updated Patch attached. -- Added file: http://bugs.python.org/file24889/magic.patch ___ Python tracker ___ ___

[issue14316] Broken link in grammar.rst

2012-03-16 Thread Éric Araujo
Éric Araujo added the comment: Thanks for the catch! A little detective work finds that grammar.rst started as a copy of PEP 306, where the link’s target is http://www.python.org/sf/676521 a.k.a. http://bugs.python.org/issue676521 I can fix this later if nobody does it before me. --

[issue14230] Delegating generator is not always visible to debugging tools such as inspect & pdb

2012-03-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset c0a6569fdad6 by Benjamin Peterson in branch 'default': in 72556ff86828, I should have updated the magic as well as the comment (#14230) http://hg.python.org/cpython/rev/c0a6569fdad6 -- ___ Python tracker

[issue14319] cleanup index switching mechanism on packaging.pypi

2012-03-16 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo versions: +3rd party, Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue14318] clarify "may not" in time.steady docs

2012-03-16 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue14275] pysetup create doesn't handle install requirements

2012-03-16 Thread Éric Araujo
Changes by Éric Araujo : -- stage: -> needs patch versions: +3rd party -Python 2.6, Python 2.7 ___ Python tracker ___ ___ Python-bugs

[issue14322] More test coverage for hmac

2012-03-16 Thread Éric Araujo
Éric Araujo added the comment: Thanks for the patch. Could you rewrite it using self.assert* methods instead of asserts? I’m not an hmac expert, so you may have to wait a bit for another core developer to see and commit the patch. -- nosy: +eric.araujo title: More test coverage for

[issue14311] ConfigParser does not parse utf-8 files with BOM bytes

2012-03-16 Thread Éric Araujo
Éric Araujo added the comment: Could you paste the exact code that fails? In 3.2+ there is a read_something method that takes an encoding argument, so that should work for example. -- nosy: +eric.araujo ___ Python tracker

[issue14334] Crash: getattr(type, '__getattribute__')(type, type)

2012-03-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset d1cf6008a565 by Benjamin Peterson in branch '2.7': check to make sure the attribute is a string (#14334) http://hg.python.org/cpython/rev/d1cf6008a565 -- ___ Python tracker

[issue14330] do not use the host python for cross builds

2012-03-16 Thread Éric Araujo
Éric Araujo added the comment: + case $$MAKEFLAGS in *s*) quiet=-s; esac; \ Should be quiet=-q. make -s → setup.py -q -- nosy: +eric.araujo ___ Python tracker ___ ___

[issue14334] Crash: getattr(type, '__getattribute__')(type, type)

2012-03-16 Thread Benjamin Peterson
Benjamin Peterson added the comment: It doesn't crash for me anymore. -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue14332] difflib.ndiff appears to ignore linejunk argument

2012-03-16 Thread Éric Araujo
Éric Araujo added the comment: Unfortunately Python 2.6 only gets fixes for security bugs now, not regular bugs. Can you reproduce the problem with 2.7 or 3.2? -- nosy: +eric.araujo, terry.reedy versions: -Python 2.6 ___ Python tracker

[issue14317] index.simple module lacking in distutils2

2012-03-16 Thread Éric Araujo
Changes by Éric Araujo : -- resolution: wont fix -> out of date stage: -> committed/rejected versions: +3rd party -Python 2.6 ___ Python tracker ___

[issue14202] The docs of xml.dom.pulldom are almost nonexistent

2012-03-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1a740ea4f2a1 by Eli Bendersky in branch '3.2': Issue #14202: some additional doc fixes http://hg.python.org/cpython/rev/1a740ea4f2a1 New changeset b2e27f21760e by Eli Bendersky in branch 'default': Issue #14202: some additional doc fixes http://hg.

[issue14202] The docs of xml.dom.pulldom are almost nonexistent

2012-03-16 Thread Eli Bendersky
Eli Bendersky added the comment: Éric, thanks for the comments - all fixed. As for 2.7, it's just laziness really. Committing to both 3.2 and 3.3 is trivial since it's a simple merge. For 2.7 it's more complicated since it's an unrelated branch, and the code samples have to be fixed as well (

[issue2377] Replace __import__ w/ importlib.__import__

2012-03-16 Thread Brett Cannon
Brett Cannon added the comment: Thanks to everyone for the reviews. I'm moving house tomorrow and I suspect Andrea wants me to take a little Python break so I might not get to the reviews before a2, but I will definitely get to them an merged by a3. -- ___

[issue14296] Compilation error on CentOS 5.8

2012-03-16 Thread Hervé Coatanhay
Hervé Coatanhay added the comment: I still have the exact same error Maybe change should be: #if !defined(CPU_ALLOC) && defined(HAVE_SCHED_SETAFFINITY) #undef HAVE_SCHED_SETAFFINITY #endif it seems CPU_ALLOC first appeared in glibc 2.7 -- ___ Pyth

[issue14317] index.simple module lacking in distutils2

2012-03-16 Thread Pierre Lecointre
Pierre Lecointre added the comment: Un grand merci pour cette réponse ! La substitution index par pypi a fonctionné. Bon week-end 2012/3/15 Alexis Metaireau > > Alexis Metaireau added the comment: > > The APIs of distutils2 have changed. the "index" module is now named > "pypi". > > So, doi

[issue14334] Crash: getattr(type, '__getattribute__')(type, type)

2012-03-16 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: well, on 2.6 and 2.7 the following has weird output and crashes: def test(obj): try: type(obj).__getattribute__(obj, (1,)) except AttributeError as e: print(e) class C: pass test(str) test(C) test(C()) -- status: close

[issue14296] Compilation error on CentOS 5.8

2012-03-16 Thread Benjamin Peterson
Benjamin Peterson added the comment: 2012/3/16 Hervé Coatanhay : > > Hervé Coatanhay added the comment: > > I still have the exact same error > > Maybe change should be: > > #if !defined(CPU_ALLOC) && defined(HAVE_SCHED_SETAFFINITY) > #undef HAVE_SCHED_SETAFFINITY > #endif Right you are. Try n

[issue14296] Compilation error on CentOS 5.8

2012-03-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 17980cb07625 by Benjamin Peterson in branch 'default': fix condition (#14296) http://hg.python.org/cpython/rev/17980cb07625 -- ___ Python tracker

[issue14261] Cleanup in smtpd module

2012-03-16 Thread R. David Murray
Changes by R. David Murray : -- dependencies: +Update to smtpd.py to RFC 5321 stage: -> needs patch ___ Python tracker ___ ___ Python

[issue14202] The docs of xml.dom.pulldom are almost nonexistent

2012-03-16 Thread Éric Araujo
Éric Araujo added the comment: I understand :) I’ll do it. I value doc as much as code, it’s also delivered faster to the users, and there are a lot of Python 2 users out there, so porting doc fixes to 2.7 is really worth it. -- assignee: docs@python -> eric.araujo status: closed ->

[issue14334] Crash: getattr(type, '__getattribute__')(type, type)

2012-03-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3d4d52e47431 by Benjamin Peterson in branch '2.7': check for string attribute names in old-style classes (closes #14334) http://hg.python.org/cpython/rev/3d4d52e47431 -- stage: needs patch -> committed/rejected status: open -> closed _

[issue14325] Stop using the garbage collector to manage the lifetime of the getargs.c freelist

2012-03-16 Thread Stefan Krah
Stefan Krah added the comment: I'm getting a leak since this revision: ./configure --without-pymalloc CFLAGS="-O0 -g" && make valgrind --db-attach=yes --suppressions=./Misc/valgrind-python.supp --leak-check=full ./python leak.py ==32303== 16 bytes in 1 blocks are definitely lost in loss recor

[issue14325] Stop using the garbage collector to manage the lifetime of the getargs.c freelist

2012-03-16 Thread Stefan Krah
Stefan Krah added the comment: Here's leak.py. -- Added file: http://bugs.python.org/file24890/leak.py ___ Python tracker ___ ___ Pyt

[issue13512] ~/.pypirc created insecurely

2012-03-16 Thread Jakub Wilk
Changes by Jakub Wilk : -- nosy: +jwilk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/

[issue12568] Add functions to get the width in columns of a character

2012-03-16 Thread Éric Araujo
Éric Araujo added the comment: eo -- nosy: +benjamin.peterson, eric.araujo, lemburg ___ Python tracker ___ ___ Python-bugs-list maili

[issue12568] Add functions to get the width in columns of a character

2012-03-16 Thread Éric Araujo
Changes by Éric Araujo : -- Removed message: http://bugs.python.org/msg156059 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

2012-03-16 Thread Benjamin Peterson
Benjamin Peterson added the comment: Shouldn't using vgetargs1 with '$' in the format string just be an error? vgetargs1 doesn't know anything about keyword arguments. -- ___ Python tracker __

[issue14332] Better explain "junk" concept in difflib doc

2012-03-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: I reproduced the observed behavior in 3.3.0a. However, I am rather sure it is not a bug. In any case, linejunk is not ignored. Passing 'lambda x: 1/0' causes ZeroDivisionError, proving that it gets called. The body of ndiff(linejunk,charjunk,a,b) is return

[issue14309] Deprecate time.clock()

2012-03-16 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: STINNER Victor wrote: > > STINNER Victor added the comment: > >> time.clock() has been in use for ages in many many scripts. >> We don't want to carelessly break all those. > > I don't want to remove the function, just mark it as deprecated to > avoid co

[issue10484] http.server.is_cgi fails to handle CGI URLs containing PATH_INFO

2012-03-16 Thread Glenn Linderman
Glenn Linderman added the comment: Senthil, from you patch, I discovered where the test_httpservers.py lives, and added '/cgi-bin/file1.py/../../a': ('/', 'a'), to a local copy, and it worked fine against whatever version of the server and tests it was running against... but tha

[issue14313] zipfile does not unpack files from archive (files extracted have zero length)

2012-03-16 Thread Glenn Linderman
Glenn Linderman added the comment: While Amaury's comment is no doubt true, shouldn't z.read raise an exception if it encounters an unsupported compression type? -- nosy: +v+python ___ Python tracker

[issue14332] Better explain "junk" concept in difflib doc

2012-03-16 Thread Weronika Patena
Weronika Patena added the comment: Ah, I see. True, the ndiff docstring doesn't actually explain what junk IS - I was just engaging in wishful thinking and assuming it did the thing I wanted. A better explanation would help. -- ___ Python tracker

[issue14325] Stop using the garbage collector to manage the lifetime of the getargs.c freelist

2012-03-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset d08f0f3ab23e by Benjamin Peterson in branch 'default': plug memory leak (closes #14325) http://hg.python.org/cpython/rev/d08f0f3ab23e -- stage: -> committed/rejected status: open -> closed ___ Python tr

[issue14245] float rounding examples in FAQ are outdated

2012-03-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: The last version in the message above looks good to me. Ready to markup and apply? -- keywords: +patch nosy: +terry.reedy stage: -> patch review ___ Python tracker _

[issue14250] for string patterns regex.flags is never equal to 0

2012-03-16 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue14336] Difference between pickle implementations for function objects

2012-03-16 Thread sbt
New submission from sbt : When pickling a function object, if it cannot be saved as a global the C implementation falls back to using copyreg/__reduce__/__reduce_ex__. The comment for the changeset which added this fallback claims that it is for compatibility with the Python implementation. S

[issue14297] Custom string formatter doesn't work like builtin str.format

2012-03-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: We know that string.Formatter does not properly duplicate str.format. #13598 is specifically about use of {}. Search "string Formatter" for other related issues. -- nosy: +terry.reedy resolution: -> duplicate status: open -> closed superseder: -> stri

[issue14337] test_builtin: refleaks

2012-03-16 Thread Stefan Krah
New submission from Stefan Krah : I don't see immediately why, but since 3877bf2e323 test_builtin and a couple of other tests leak in refcounting mode: hg up 8a5742b7a14d make distclean && ./configure --with-pydebug && make ./python -m test -uall -R :: test_builtin [1/1] test_builtin beginning

[issue14337] test_builtin: refleaks

2012-03-16 Thread Benjamin Peterson
Benjamin Peterson added the comment: Yes, see 9e7f6ddc0d76 for the fix. -- resolution: -> out of date status: open -> closed ___ Python tracker ___

[issue14331] Python/import.c uses a lot of stack space due to MAXPATHLEN

2012-03-16 Thread Gregory P. Smith
Gregory P. Smith added the comment: It looks like MAXPATHLEN is 4096 on our systems. The offending code that caused a stack overflow segfault shows over 100 Python/import.c function calls in its backtrace. -- ___ Python tracker

[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO

2012-03-16 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue14306] try/except block is both efficient and expensive?

2012-03-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: I think it would be sufficient to add ' if no exceptions are raised' to the first sentence. The example that follows in the entry clarifies the implications of "cheap to try, expensive to catch". -- keywords: +patch nosy: +terry.reedy ___

[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO

2012-03-16 Thread R. David Murray
R. David Murray added the comment: Thanks for the patch. I think this is fine. An alternate approach would be to introduce the concept of a state (like imaplib has), have a list of which commands are allowed in which state, and implement the check in the command processing function, but that

[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO

2012-03-16 Thread R. David Murray
R. David Murray added the comment: Oh, by the way the mention of EHLO in that message depends on issue 8739 going in. -- ___ Python tracker ___

[issue14337] Recent refleaks

2012-03-16 Thread Stefan Krah
Stefan Krah added the comment: Ah, thanks for the pointer. 9e7f6ddc0d76 is clean, but default still leaks. Next attempt: OK: d2460ff173ff Leak: 3b2856d8614b test_dict leaked [12, 12] references, sum=24 test_builtin leaked [24, 24] references, sum=48 test_unittest leaked [970, 970] references

[issue14338] urllib2 HowTo for overriding post/3xx behavior.

2012-03-16 Thread beeNuts
Changes by beeNuts : -- type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue14311] ConfigParser does not parse utf-8 files with BOM bytes

2012-03-16 Thread Łukasz Langa
Łukasz Langa added the comment: What you considered a workaround is actually what you should be using faced with BOM bytes. This is a broader issue in Python, not necessarily connected with ConfigParser or any other library. Also, this has been already reported here: http://bugs.python.org/i

[issue14338] urllib2 HowTo for overriding post/3xx behavior.

2012-03-16 Thread beeNuts
New submission from beeNuts : Issue #14144, with the title "urllib2 HTTPRedirectHandler not forwarding POST data in redirect" was recently closed with these comments: "This could be cookbook recipe style example, if it's utility value is high. I am closing this issue as I feel that the require

[issue14245] float rounding examples in FAQ are outdated

2012-03-16 Thread Mark Dickinson
Mark Dickinson added the comment: Fine by me. Language nitpick: "approximation to" sounds a bit better to my ears than "approximation of" -- ___ Python tracker ___ __

[issue14331] Python/import.c uses a lot of stack space due to MAXPATHLEN

2012-03-16 Thread Brett Cannon
Brett Cannon added the comment: Cursory glance has the patch LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO

2012-03-16 Thread Jason Killen
Jason Killen added the comment: On using a different approach: I weighed an approach like that and decided to go with what I thought was the clean/simple/easy approach. If there were more commands that smptd.py accepted I would have probably gone with more like what you mentioned. Change i

[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO

2012-03-16 Thread R. David Murray
R. David Murray added the comment: When do patches get applied? The general answer is "when someone gets around to it" :) In this particular case the issue 8739 patch is waiting on the resolution of its dependency (logging uses smtpd in its tests, and the 8739 patch breaks the logging test)

  1   2   >