[issue12810] Remove check for negative unsigned value in socketmodule.c

2011-08-21 Thread Joel
New submission from Joel : fixes the following warning: cpython/Modules/socketmodule.c:1748:74: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if (cmsgh == NULL || msg->msg_control == NULL || msg->msg_controllen < 0) -- files: bad_unsigned_c

[issue1215] documentation doesn't say that you can't handle C segfaults from python

2011-08-21 Thread Martin Pool
Martin Pool added the comment: This patch tries to improve the documentation a bit more to address the issue that confused tebeka and to advertise faulthandler. Could someone review or apply it? -- keywords: +patch Added file: http://bugs.python.org/file22989/20110822-1525-signal-doc

[issue12808] Coverage of codecs.py

2011-08-21 Thread Nick Coghlan
Nick Coghlan added the comment: Tennessee, there were a few issues in the original patch - see the attached update (mostly the use of assert statements instead of methods and the overbroad scope of the context manager when checking for an expected exception). However, in getting ready to comm

[issue11657] multiprocessing_{send,recv}fd fail with fds > 256

2011-08-21 Thread Petri Lehtinen
Petri Lehtinen added the comment: Charles-François Natali wrote: > Yeah, I could of course do this myself, but since Petri already > submitted a patch and seemed to be willing to update it with a test, I > thought he might be interested in this (I've also seen he's > participating to core-mentor

[issue12326] Linux 3: code should avoid using sys.platform == 'linux2'

2011-08-21 Thread Georg Brandl
Georg Brandl added the comment: Where's the doc updates for the stable branches? Also, we might think about removing this version number everywhere. -- ___ Python tracker ___ _

[issue10713] re module doesn't describe string boundaries for \b

2011-08-21 Thread Martin Pool
Martin Pool added the comment: > Note, 366 above confirms it's never true for an empty string. The documentation states that \B "is just the opposite of \b" yet re.match(r'\b', '') returns None and so does \B so \B isn't the opposite of \b in all cases. This is also a bit strange if you follow

[issue6484] No unit test for mailcap module

2011-08-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 69cb66ab61cc by Nick Coghlan in branch 'default': Add unit tests for the mailcap module. Patch by Gregory Nofi (closes #6484) http://hg.python.org/cpython/rev/69cb66ab61cc -- nosy: +python-dev resolution: -> fixed stage: patch review -> co

[issue12811] Tabnanny doesn't close its tokenize files properly

2011-08-21 Thread Anthony Briggs
New submission from Anthony Briggs : Unlike Python 2, Python 3 warns when files aren't closed properly, which raises lots of warnings when running tabnanny: ~/devinabox/cpython$ ./python -m tabnanny Lib/ /home/anthony/devinabox/cpython/Lib/tabnanny.py:93: ResourceWarning: unclosed file <_io.Te

[issue10951] gcc 4.6 warnings

2011-08-21 Thread Martin Pool
Martin Pool added the comment: My patch above fixes all the messages so that you get a clean build with the current makefile. -Wuninitialized and 'offset outside constant string' would be worth fixing but I can't reproduce them in Python. I'm personally not so keen on fixing all the signed/u

[issue12811] Tabnanny doesn't close its tokenize files properly

2011-08-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset c5cb0aa5bed6 by Nick Coghlan in branch 'default': Fix #12811 by closing files promptly in tabnanny.check. Patch by Anthony Briggs. http://hg.python.org/cpython/rev/c5cb0aa5bed6 -- nosy: +python-dev ___ P

[issue11657] multiprocessing_{send,recv}fd fail with fds > 256

2011-08-21 Thread Nick Coghlan
Nick Coghlan added the comment: For 3.3, it may be relevant that send/recvmsg are now available via the socket API (see #6560) -- nosy: +ncoghlan ___ Python tracker ___ ___

[issue6560] socket sendmsg(), recvmsg() methods

2011-08-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 37721ee145a2 by Nick Coghlan in branch 'default': Credit patch authors in NEWS for #6560 http://hg.python.org/cpython/rev/37721ee145a2 -- ___ Python tracker __

[issue12812] libffi does not build with clang on amd64

2011-08-21 Thread Joel
New submission from Joel : tl;dr libffi needs to be updated so Python will build with clang on Linux on amd64 libffi, part of ctypes, has a test for PC relative relocations. It assembles a assembler file with CC, and looks for the string "warning" in the output. clang produces harmless warnin

[issue7584] datetime.rfcformat() for Date and Time on the Internet

2011-08-21 Thread Martin Pool
Martin Pool added the comment: Z is well established as meaning "UTC time" so shouldn't be used for "zone not known." rfc 3393 is clear that it's equivalent to +00:00. So the questions seem to be: * should there be an i

[issue12813] uuid4 is not tested if a uuid4 system routine isn't present

2011-08-21 Thread Matt Joiner
New submission from Matt Joiner : The uuid.uuid4 function is not tested if a C system routine is not present, despite that uuid4 has several fallback clauses. This patch will test at least the first fallback. -- components: Library (Lib) files: uuid4-test-no-system-routine-fallback.pat

[issue12814] Possible intermittent bug in test_array

2011-08-21 Thread Nick Coghlan
New submission from Nick Coghlan : Had a weird bug in test_array.test_tofromstring failing on Gentoo by generating too few warning messages: http://www.python.org/dev/buildbot/all/builders/x86%20Gentoo%20Non-Debug%203.x/builds/568/steps/test/logs/stdio http://www.python.org/dev/buildbot/all/buil

<    1   2