[issue10932] distutils.core.setup - data_files misbehaviour ?

2011-04-19 Thread Prashant Kumar
Prashant Kumar added the comment: Sure, patch.diff is a complete one. -- Added file: http://bugs.python.org/file21727/patch.diff ___ Python tracker ___ _

[issue11881] Add list.get

2011-04-19 Thread Raymond Hettinger
Raymond Hettinger added the comment: > operator.getitem could be extended to accept default value That would be relatively harmless. And because it isn't type specific to lists, it would be applicable to other types that might better use cases than lists do. If you want to pursue this, plea

[issue10910] pyport.h FreeBSD/Mac OS X "fix" causes errors in C++ compilation

2011-04-19 Thread Nasos Dousis
Nasos Dousis added the comment: Meador et al, Thanks for your attention to this issue. Just to clarify, I can eliminate the compile errors by prepending #include "Python.h" to any source file with #include Also, my code compiles in Linux, with and without the Python.h header: $ uname -a L

[issue11875] OrderedDict.__reduce__ not threadsafe

2011-04-19 Thread Mario Juric
Mario Juric added the comment: Hi Raymond, Excellent! Many thanks for such a quick fix, this has been bugging us for months! -- ___ Python tracker ___

[issue1294232] Error in metaclass search order

2011-04-19 Thread Daniel Urban
Daniel Urban added the comment: Thanks for the review! I've updated my patch: - renamed it to _PyType_CalculateMetaclass - in __build_class__ call it even when a metaclass is declared - added a test for this case (which fails with my previous patch) However I noticed another problem: the decla

[issue8809] smtplib should support SSL contexts

2011-04-19 Thread Kasun Herath
Kasun Herath added the comment: I did a patch that allows smtplib.SMTP_SSL constructor to accept an optional SSLContext -- keywords: +patch nosy: +kasun Added file: http://bugs.python.org/file21730/smtp_sslcontext.patch ___ Python tracker

[issue11875] OrderedDict.__reduce__ not threadsafe

2011-04-19 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: The call to self.__class__() can break subclasses of OrderedDict for two reasons: - The subclass constructor may have a different signature - Attributes set by the subclass.__init__ are removed from the pickle:: import collections, pickle class Mydict(c

[issue11883] Call connect() before sending an email with smtplib

2011-04-19 Thread Sandro Tosi
New submission from Sandro Tosi : Hi, following up http://mail.python.org/pipermail/docs/2011-April/003742.html here are a couple of patches to call connect() after smtplib.SMTP() and sendmail(). Patches are: 2.7: to be applied in 2.7 and merged into 3.1 3.2: to be applied in 3.2 and merged in

[issue11883] Call connect() before sending an email with smtplib

2011-04-19 Thread Sandro Tosi
Changes by Sandro Tosi : Added file: http://bugs.python.org/file21732/smtp_connect-3.2.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue11863] Enforce PEP 11 - remove support for legacy systems

2011-04-19 Thread STINNER Victor
STINNER Victor added the comment: Python/thread.c contains a reference to a missing file: #ifdef PLAN9_THREADS #include "thread_plan9.h" #endif But I don't see where PLAN9_THREADS is defined. remove_threads.patch removes these 3 lines. -- There is also an unused file: Python/thread_wince.c.

[issue9896] Introspectable range objects

2011-04-19 Thread Daniel Urban
Daniel Urban added the comment: Thanks, I've corrected my patch. -- Added file: http://bugs.python.org/file21733/range_attrs_3.patch ___ Python tracker ___ __

[issue11875] OrderedDict.__reduce__ not threadsafe

2011-04-19 Thread Daniel Urban
Changes by Daniel Urban : -- nosy: +durban ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue11863] Enforce PEP 11 - remove support for legacy systems

2011-04-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Python/thread.c contains a reference to a missing file: > > #ifdef PLAN9_THREADS > #include "thread_plan9.h" > #endif > > But I don't see where PLAN9_THREADS is defined. > > remove_threads.patch removes these 3 lines. > > -- > > There is also an unused fi

[issue11882] test_imaplib failed on x86 ubuntu

2011-04-19 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue11223] interruption of locks by signals not guaranteed when the semaphore implementation is not used

2011-04-19 Thread STINNER Victor
STINNER Victor added the comment: > The path which sets "pthread_version" should be inside "#ifdef > _POSIX_THREADS". > Also, some comments about the doc: > - you need a "versionadded" tag Right, fixed. > - "use_semaphores" should explain that these semaphores are used for > locks; also the al

[issue11223] interruption of locks by signals not guaranteed when the semaphore implementation is not used

2011-04-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I also renamed 'name' key to 'thread', so 'thread' is the name of the > *thread* implementation, and 'lock' is the name of the *lock* > implementation. Not that I want to bikeshed, but I think 'name' was ok (since you get the dict by calling threading._info()

[issue11223] interruption of locks by signals not guaranteed when the semaphore implementation is not used

2011-04-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 383a7301616b by Victor Stinner in branch 'default': Issue #11223: Add threading._info() function providing informations about the http://hg.python.org/cpython/rev/383a7301616b -- ___ Python tracker

[issue11223] interruption of locks by signals not guaranteed when the semaphore implementation is not used

2011-04-19 Thread STINNER Victor
STINNER Victor added the comment: Let's wait 6 hours for "x86 FreeBSD 6.4 3.x": http://www.python.org/dev/buildbot/all/builders/x86%20FreeBSD%206.4%203.x The first build including my fix (383a7301616b) should be: http://www.python.org/dev/buildbot/all/builders/x86%20FreeBSD%206.4%203.x/builds/1

[issue11223] interruption of locks by signals not guaranteed when the semaphore implementation is not used

2011-04-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset bc1c6bd7eeb0 by Victor Stinner in branch 'default': Issue #11223: fix test_dummy_threading, add _dummy_thread.info() http://hg.python.org/cpython/rev/bc1c6bd7eeb0 -- ___ Python tracker

[issue11875] OrderedDict.__reduce__ not threadsafe

2011-04-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset db66eaf353a6 by Raymond Hettinger in branch '2.7': Issue #11875: Alter the previous fix to work better with subclasses http://hg.python.org/cpython/rev/db66eaf353a6 -- ___ Python tracker

[issue11875] OrderedDict.__reduce__ not threadsafe

2011-04-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 408f23b6cec5 by Raymond Hettinger in branch '3.1': Issue #11875: Alter the previous fix to work better with subclasses http://hg.python.org/cpython/rev/408f23b6cec5 New changeset 4e6840477d96 by Raymond Hettinger in branch '3.2': Issue #11875: Alte

[issue8407] expose signalfd(2) and sigprocmask(2) in the signal module

2011-04-19 Thread STINNER Victor
STINNER Victor added the comment: signal_pthread_sigmask.patch: - add signal.pthread_sigmask() function with doc and tests - add SIG_BLOCK, SIG_UNBLOCK, SIG_SETMASK constants - fix #11859: fix tests of test_io using threads and an alarm: use pthread_sigmask() to ensure that only the main thr

[issue11859] test_interrupted_write_text() of test_io failed of Python 3.3 on FreeBSD 7.2

2011-04-19 Thread STINNER Victor
Changes by STINNER Victor : -- dependencies: +expose signalfd(2) and sigprocmask(2) in the signal module ___ Python tracker ___ ___ Py

[issue11882] test_imaplib failed on x86 ubuntu

2011-04-19 Thread R. David Murray
R. David Murray added the comment: This is a repeatable error? What is your system timezone set to? The difference is exactly one half hour. Does the test pass if you change the calendar.timegm call to have '0' or '1' as the last element of the tuple instead of '-1'? -- nosy: +bel

[issue8407] expose signalfd(2) and sigprocmask(2) in the signal module

2011-04-19 Thread STINNER Victor
STINNER Victor added the comment: Oh, I forget to read again http://codereview.appspot.com/1132041. Here is an updated patch reusing some tests and with a better documentation. -- Added file: http://bugs.python.org/file21736/signal_pthread_sigmask-2.patch _

[issue8944] test_winreg.test_reflection_functions fails on Windows Server 2003

2011-04-19 Thread Brian Curtin
Brian Curtin added the comment: I no longer have access to a Server 2003 machine and I don't remember this happening the last few times I worked on that OS so it may have been fixed. If this occurs for anyone else, feel free to reopen. -- resolution: -> rejected stage: needs patch ->

[issue11873] test_regexp() of test_compileall failure on "x86 OpenIndiana 3.x"

2011-04-19 Thread R. David Murray
Changes by R. David Murray : -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue10540] test_shutil fails on Windows after r86733

2011-04-19 Thread Brian Curtin
Brian Curtin added the comment: This hasn't been an issue for quite some time, and I suspect the follow-up work on symbolic and hard links and their supporting functions corrected any problems in this area. -- resolution: -> works for me stage: needs patch -> committed/rejected statu

[issue1294232] Error in metaclass search order

2011-04-19 Thread Nick Coghlan
Nick Coghlan added the comment: This last point sounds like an error in PEP 3115 rather than an error in the implementation - as the exception says, the metaclass of a derived class must be the same as or a subclass of the metaclasses of all of its bases. Since that rule applies recursively, and

[issue11619] On Windows, don't encode filenames in the import machinery

2011-04-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset e4e92d68ba3a by Victor Stinner in branch 'default': Close #11619: write_compiled_module() doesn't encode the filename http://hg.python.org/cpython/rev/e4e92d68ba3a -- resolution: -> fixed stage: -> committed/rejected status: open -> close

[issue11619] On Windows, don't encode filenames in the import machinery

2011-04-19 Thread STINNER Victor
STINNER Victor added the comment: > c) parse_source_module() > => covered by the issue #10785. Issue #10785 didn't change parse_source_module(): it does still encode the filename. We need Unicode version of PyParser_ASTFromFile() and PyAST_Compile(): a new version of these functions acceptin

[issue8886] zipfile.ZipExtFile is a context manager, but that is not documented

2011-04-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 83a426e969f5 by Brian Curtin in branch '2.7': Fix #8886. Use context managers throughout zipfile tests. http://hg.python.org/cpython/rev/83a426e969f5 -- nosy: +python-dev ___ Python tracker

[issue8886] zipfile.ZipExtFile is a context manager, but that is not documented

2011-04-19 Thread Brian Curtin
Changes by Brian Curtin : -- resolution: accepted -> fixed stage: patch review -> committed/rejected status: open -> closed versions: -Python 3.1 ___ Python tracker ___ _

[issue8809] smtplib should support SSL contexts

2011-04-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: This sentence is awkward, at best. "Alternative to a private key and a certificate key an optional SSLContext could be specified." I suggest something like: "SSLcontext, also optional, is an alternative to keyfile and certfile; if it is specified, keyfile and

[issue8809] smtplib should support SSL contexts

2011-04-19 Thread david
david added the comment: It should also explain how the context can be used. An example of how to use it to establish a 'secured' connection would be a nice to have. -- ___ Python tracker

[issue10596] modulo operator bug

2011-04-19 Thread Tim Peters
Tim Peters added the comment: Raymond, Mark pointed to the footnote explaining the first result. As to the second, Kahan tried his best, but I'm afraid nobody can make me care about the sign bit on a zero ;-) Whatever Mark thought best is fine by me. --

[issue7549] 2.6.4 Win32 linked to debug DLLs?

2011-04-19 Thread Jonathon Rossi
Jonathon Rossi added the comment: I just encountered this error with an older version (2.6.2) of python on Windows Server 2008 R2. >From looking at the logs it looks like the Customer Experience Improvement >Program (CEIP) functionality is causing this problem because it has a >scheduled tas

[issue8809] smtplib should support SSL contexts

2011-04-19 Thread Kasun Herath
Kasun Herath added the comment: I'm submitting a new patch with changes suggested by Terry. But I feel an example of how to use a SSLContext inside the Docstring of SMTP_SSL constructor is unnecessary since no smtp specific things are done to the passed SSLContext. Any ideas about this sugges

[issue11875] OrderedDict.__reduce__ not threadsafe

2011-04-19 Thread Raymond Hettinger
Raymond Hettinger added the comment: Mario, thanks for the bug report. -- status: open -> closed ___ Python tracker ___ ___ Python-bu

<    1   2