[issue11471] If without else generates redundant jump

2011-03-11 Thread Eugene Toder
Eugene Toder added the comment: Test case (needed some refactoring to avoid duplication). -- Added file: http://bugs.python.org/file21092/if_no_else_test.patch ___ Python tracker __

[issue11466] getpass.getpass doesn't close tty file

2011-03-11 Thread Éric Araujo
Éric Araujo added the comment: If you can write a patch that cleans up the code and closes the files without being too hard to review, it could get committed soon. Then you could adapt your patch on the other bug and defend it. -- ___ Python track

[issue11390] doctest: add cmdline parameters

2011-03-11 Thread Éric Araujo
Changes by Éric Araujo : -- stage: -> needs patch type: -> feature request versions: +Python 3.3 -Python 2.7, Python 3.2 ___ Python tracker ___

[issue5863] bz2.BZ2File should accept other file-like objects.

2011-03-11 Thread Antoine Pitrou
Antoine Pitrou added the comment: Patch posted for review at http://codereview.appspot.com/4274045/. Still have to do a review though :) -- ___ Python tracker ___ __

[issue11466] getpass.getpass doesn't close tty file

2011-03-11 Thread Steffen Daode Nurpmeso
Steffen Daode Nurpmeso added the comment: On Fri, Mar 11, 2011 at 09:51:32PM +, Éric Araujo wrote: > If you can write a patch that cleans up the code and closes the > files without being too hard to review I'll try to do so tomorrow. -- ___ Pyt

[issue11418] Method's global scope is module containing function definition, not class.

2011-03-11 Thread R. David Murray
R. David Murray added the comment: If you do a "def foo" in module bar.py, and have a class FooFoo in bar.py, and do: FooFoo.myfoo = foo and foo refers to an unbound variable, that variable will be looked up in bar.py's global name space. If instead the 'def foo' is in a module parrot.py, a

[issue10716] Modernize pydoc to use CSS

2011-03-11 Thread Ezio Melotti
Ezio Melotti added the comment: I added a few comments for ccs_v3.diff on rietveld. -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue11447] test_pydoc refleak

2011-03-11 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue11432] webbrowser.open on unix fails.

2011-03-11 Thread Éric Araujo
Éric Araujo added the comment: Is this a webbrowser or subprocess bug? Please add the corresponding expert from http://docs.python.org/devguide/experts to the nosy list. -- nosy: +eric.araujo versions: +Python 3.1 ___ Python tracker

[issue11462] Peephole creates duplicate and unused constants

2011-03-11 Thread Raymond Hettinger
Raymond Hettinger added the comment: Sorry Eugene. As the person who designed, implemented, and maintains the peephole optimizer, I need to reject the patch. If better constant folding is wanted, the work needs to be done with AST, not with bytecode. I would welcome a patch. Thomas, thanks

[issue10936] Simple CSS fix for left margin at docs.python.org

2011-03-11 Thread Ezio Melotti
Ezio Melotti added the comment: There's #4965 for that. Last time I tried there was some problem with it, maybe I'll try again in future. -- ___ Python tracker ___

[issue11472] upload command fails to read auth information from .pypirc

2011-03-11 Thread Jason R. Coombs
New submission from Jason R. Coombs : It appears that distutils isn't loading the authentication information from .pypirc. I ran this test on Python 3.2 64-bit on Windows. PS C:\Users\jaraco\projects\hgtools> python -m pdb setup.py sdist upload > c:\users\jaraco\projects\hgtools\setup.py(7)() -

[issue11462] Peephole creates duplicate and unused constants

2011-03-11 Thread Eugene Toder
Eugene Toder added the comment: Thomas, can you clarify, does loading interns all constants in co_consts, or do you mean that they are mostly small numbers and the like? Without interning I think that in-memory size difference is even bigger than on-disk, as you get one entry in tuple and the

[issue11473] upload command no longer accepts repository by section name

2011-03-11 Thread Jason R. Coombs
New submission from Jason R. Coombs : It appears that with Python 3.2 (Windows 64-bit), the distutils upload -r command no longer accepts the repository section name, but instead only attempts to parse it as a URL. This is a regression from Python 2.7. PS C:\Users\jaraco\projects\hgtools> pyth

[issue11473] upload command no longer accepts repository by section name

2011-03-11 Thread Jason R. Coombs
Changes by Jason R. Coombs : -- versions: +Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue11403] Add some generated files in PC/ to .hgignore.

2011-03-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset f040a34102de by Antoine Pitrou in branch '3.1': Issue #11403: add some MSVC-generated files to .hgignore http://hg.python.org/cpython/rev/f040a34102de New changeset b2a6d1a5e2cf by Antoine Pitrou in branch '3.2': Merge #11403 http://hg.python.org/c

[issue11403] Add some generated files in PC/ to .hgignore.

2011-03-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset 350b956b3600 by Antoine Pitrou in branch '2.7': Issue #11403: add some MSVC-generated files to .hgignore http://hg.python.org/cpython/rev/350b956b3600 -- ___ Python tracker

[issue11403] Add some generated files in PC/ to .hgignore.

2011-03-11 Thread Antoine Pitrou
Antoine Pitrou added the comment: Committed, thank you! -- nosy: +pitrou resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue11432] webbrowser.open on unix fails.

2011-03-11 Thread Gregory P. Smith
Gregory P. Smith added the comment: subprocess in 3.2 bug from the looks of it. not sure if 2.7 or 3.1 are impacted at all, i'll remove them from the list after confirming. -- assignee: -> gregory.p.smith ___ Python tracker

[issue11244] Negative tuple elements produce inefficient code.

2011-03-11 Thread Raymond Hettinger
Raymond Hettinger added the comment: Eugene's patch looks like a correct fix to the regression. I'll review further in the next couple of days. Antoine, we need to further discuss your checkin to the peephole optimizer. I believe it was inappropriate. -- assignee: mark.dickinson ->

[issue11244] Negative tuple elements produce inefficient code.

2011-03-11 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Eugene's patch looks like a correct fix to the regression. No, it's orthogonal. -- ___ Python tracker ___ __

[issue11244] Negative tuple elements produce inefficient code.

2011-03-11 Thread Eugene Toder
Eugene Toder added the comment: Yes, my patch doesn't fix the regression, only a special case of -0. -- ___ Python tracker ___ ___ Py

[issue11464] Call Mac API Crash via ctypes

2011-03-11 Thread Ronald Oussoren
Ronald Oussoren added the comment: This is almost certainly not a bug in Python, but in the code in this issue. CGEventGetLocation() is a function that returns a CGPoint, while ctypes assumes that function returns value of C type int. The effect of this is that ctypes will create the wrong s

[issue9319] imp.find_module('test/badsyntax_pep3120') causes segfault

2011-03-11 Thread STINNER Victor
STINNER Victor added the comment: I'm working on #3080 which changes the import machinery to use Unicode instead of byte strings, and so it will be possible to fix this issue correctly. -- ___ Python tracker _

[issue3080] Full unicode import system

2011-03-11 Thread STINNER Victor
STINNER Victor added the comment: See also #9319: when this issue will be fixed, it will be easier to fix #9319. -- ___ Python tracker ___ ___

[issue10665] Expand unicodedata module documentation

2011-03-11 Thread STINNER Victor
STINNER Victor added the comment: > The patch contains non-ascii chars that should be avoided (they break `make > pdf`). What is the error? Can't you fix the PDF generator instead? -- ___ Python tracker

[issue1271] Raw string parsing fails with backslash as last character

2011-03-11 Thread Graham Wideman
Graham Wideman added the comment: @Glenn Linderman: I too am usually quick to assume that "innocent fixes" may have serious unforeseen impacts, but in this case I'm not convinced. What would matter is to enumerate the current behavior, and of that what would be changed. You seem to have ha

[issue1271] Raw string parsing fails with backslash as last character

2011-03-11 Thread R. David Murray
R. David Murray added the comment: If I'm remembering the discussion I read correctly, what the parser does is to parse the a regular string and a raw string in exactly the same way, but in the raw string case, it does not do the subsequent escape sequence replacement pass on the parsed strin

[issue11464] Call Mac API Crash via ctypes

2011-03-11 Thread yufun
yufun added the comment: thanks Ned and Ronald, I totally agree with you, I think it's a 32/64 issue. But, I'm not clear about the 32 and 64 bit in Python and don't know how to do let my code works, could you please explain more detail about that? -- _

[issue11350] __setitem__()'s problem of dbm.dumb object pointed out by comments

2011-03-11 Thread R. David Murray
R. David Murray added the comment: Well, I don't think we are going to add an abort method in order to write a unit test, though it isn't completely out of the question. However, I've now looked at the code and the other comments in the file, and it is clear that great care is taken to allow

[issue11049] add tests for test.support

2011-03-11 Thread R. David Murray
R. David Murray added the comment: Gah. I always check to see if the patch uploaded before I delete my working copy, but this time I didn't :( :( I guess I'll come back to this during the sprints. -- ___ Python tracker

[issue1271] Raw string parsing fails with backslash as last character

2011-03-11 Thread Glenn Linderman
Glenn Linderman added the comment: @Graham: seems like the two primary gotchas are trailing \ and \" \' not removing the \. The one that tripped me up the most was the trailing \, but I did get hit with \" once. Probably if Python had been my first programming language that used \ escapes,

[issue1271] Raw string parsing fails with backslash as last character

2011-03-11 Thread R. David Murray
R. David Murray added the comment: Well, it's still the case that the Python raw string syntax isn't going to change to not escape the quotes, because that would break far too many existing applications that depend on them being escaped. So a new string literal type would seem to be the only

[issue11283] incorrect pattern in the re module docs for conditional regex

2011-03-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset 06cca90ff105 by orsenthil in branch 'default': Fix issue11283 - Clarifying a re pattern in the re module docs for conditional regex http://hg.python.org/cpython/rev/06cca90ff105 -- nosy: +python-dev ___

[issue9298] binary email attachment issue with base64 encoding

2011-03-11 Thread R. David Murray
R. David Murray added the comment: Unfortunately we don't have enough history information to determine who wrote the original _bencode function, although very likely it was Barry. As for the test, that seems to have been written during the python3 translation to make sure that the behavior i

[issue11049] add tests for test.support

2011-03-11 Thread R. David Murray
Changes by R. David Murray : -- assignee: -> r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue11462] Peephole creates duplicate and unused constants

2011-03-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Eugene, how does your optimization differ from the one proposed in issue2493? -- nosy: +belopolsky ___ Python tracker ___ ___

[issue11283] incorrect pattern in the re module docs for conditional regex

2011-03-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset d676601fee6f by Senthil Kumaran in branch '3.1': Fix issue11283 - Clarifying a re pattern in the re module docs for conditional regex http://hg.python.org/cpython/rev/d676601fee6f -- ___ Python tracker

[issue11283] incorrect pattern in the re module docs for conditional regex

2011-03-11 Thread Senthil Kumaran
Senthil Kumaran added the comment: Okay, fixed in all relevant branches. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue11462] Peephole creates duplicate and unused constants

2011-03-11 Thread Eugene Toder
Eugene Toder added the comment: Alexander, my patch does 2 optimizations: doesn't insert a new constant if one already exist and removes unused constants after peephole is done. You patch seems to do only the latter. It's very similar, from a quick look at your patch: - My patch doesn't introd

[issue968430] error flattening complex smime signed message

2011-03-11 Thread R. David Murray
Changes by R. David Murray : -- versions: +Python 2.7, Python 3.2, Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue706263] print raises exception when no console available

2011-03-11 Thread Santoso Wijaya
Santoso Wijaya added the comment: This is indeed reproducible in Python 2.7. The following unittest will expose it. However, patching sys.std* to None will break `print` statements to raise AttributeError in pythonw.exe programs, though it won't mysteriously break only after printing 4 kbytes

[issue11462] Peephole creates duplicate and unused constants

2011-03-11 Thread Raymond Hettinger
Raymond Hettinger added the comment: Please cease development of this patch. It has been rejected. The peephole optimizer should be considered somewhat off-limits at this point and any further development efforts directed at an AST optimizer. -- resolution: -> rejected

[issue11462] Peephole creates duplicate and unused constants

2011-03-11 Thread Eugene Toder
Eugene Toder added the comment: Raymond, you can be assured that I'm not developing this patch, unless I'm told it has chances to be accepted. I don't like to waste my time. On a related note, your review of my other patches is appreciated. -- ___

[issue11467] urlparse.urlsplit() regression for paths consisting of digits

2011-03-11 Thread Bastian Kleineidam
Bastian Kleineidam added the comment: To make the previous comment more precise: URLs where the scheme specific part begins with a digit are affected. -- ___ Python tracker ___

[issue11463] IncompleteRead: IncompleteRead(168 bytes read)

2011-03-11 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes, please ensure that server is returning a proper HTTP response. Test it against browser or curl and see if they work. If they work, then it needs to be investigated as why 'http.client' is not working. -- assignee: -> orsenthil nosy: +orsenthil

<    1   2