[issue9549] Remove sys.setdefaultencoding()

Marc-Andre Lemburg added the comment: Antoine Pitrou wrote: > > New submission from Antoine Pitrou : > > The use of sys.setdefaultencoding() has always been discouraged, and it has > become a no-op in py3k (the encoding is hard-wired to utf-8 and changing it > raises an error). It is time to

[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

Antoine Pitrou added the comment: > I think "cannot be copied" is an exaggeration It seems that the purpose is to allow local modifications to Modules/Setup. Otherwise, I don't know why the Makefile would print an elaborate message when the file exists. If this possibility is never used then,

[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

Martin v. Löwis added the comment: Am 09.08.2010 22:43, schrieb Antoine Pitrou: > > Antoine Pitrou added the comment: > >> I think "cannot be copied" is an exaggeration > > It seems that the purpose is to allow local modifications to > Modules/Setup. Otherwise, I don't know why the Makefile

[issue3592] Patch to add imp.get_codingspec()

Changes by Brett Cannon : -- resolution: -> out of date status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue1644818] Allow built-in packages and submodules as well as top-level modules

Brett Cannon added the comment: Import is explicitly exempt from the moratorium. But since the moratorium expires starting with Python 3.3 it really doesn't matter since this change will not go into 3.2. -- ___ Python tracker

[issue9548] locale can be imported at startup but relies on too many library modules

Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue9421] configparser.ConfigParser's getint, getboolean and getfloat don't accept `vars`

Łukasz Langa added the comment: Patch included. New type-related unit tests have shown undesirable behaviour of read_dict() when the given option values are not strings. Support for numbers, booleans and Nones is likely to be expected so this change was introduced. `default' can hold a non-s

[issue6751] Default return value in ConfigParser

Łukasz Langa added the comment: This issue is superseded by #9421. -- resolution: -> duplicate status: open -> closed superseder: -> configparser.ConfigParser's getint, getboolean and getfloat don't accept `vars` ___ Python tracker

[issue9516] sysconfig: $MACOSX_DEPLOYMENT_TARGET mismatch: now "10.3" but "10.5" during configure

Sridhar Ratnakumar added the comment: We build ActivePython 2.7 on Mac as follows: $ export MACOSX_DEPLOYMENT_TARGET=10.5 $ ./configure --enable-framework --enable-universalsdk=/Developer/SDKs/MacOSX10.5.sdk/ --with-universal-archs=intel $ make (the environment variable is also used

[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

Senthil Kumaran added the comment: On Mon, Aug 09, 2010 at 08:57:31PM +, Martin v. Löwis wrote: > I still fail to see the bug - it's by design that later build steps are > not executed if earlier build steps failed. It would be possible to let > the slaves start over with an entirely new che

[issue9548] locale can be imported at startup but relies on too many library modules

Marc-Andre Lemburg added the comment: Antoine Pitrou wrote: > > Antoine Pitrou added the comment: > > Attached patch fixes the issue by creating a separate "_bootlocale" module, > used at bootstrap, which doesn't import collections, functools and friends. I don't think that's the right way

[issue7467] The zipfile module does not check files' CRCs, including in ZipFile.testzip

Antoine Pitrou added the comment: Actually, there are two places where the internal buffer is trimmed from consumed data: self._readbuffer = self._readbuffer[self._offset:] + data self._offset = 0 At this point, it seems self._crc_offset should also be reset to zero,

[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

Florent Xicluna added the comment: I agree we should run the "clean" step as a finally step, even if "compile error" occurs. It is not required in case of "svn exception", I guess. Btw, the exact command is "make distclean" ("make clean" target does not remove "Modules/Setup"). -- _

[issue8538] Add ConfigureAction to argparse

Jeremiah Jordan added the comment: I think this should be updated so that nargs=0 is allowed, so that you can only do --foo/--no-foo and don't clutter up the help/interface with --foo [FOO] --no-foo=[FOO] You can do this by adding nargs to the ConfigureAction.__init__ and passing that throug

[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

Martin v. Löwis added the comment: > I guess, you missed what we are trying to convey. No, I fully understand what happened. STILL, a) I don't think this is a bug in the buildbot configuration, and b) even if it was, I don't really have the time to investigate that in the coming weeks. Howev

[issue9548] locale can be imported at startup but relies on too many library modules

Antoine Pitrou added the comment: > I don't think that's the right way forward. > > It's much easier to either remove the need to import those > extra modules or defer their import to actual use within > a function. The latter has various issues, such as being overly tedious and potentially ri

[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

Martin v. Löwis added the comment: It turns out that build steps have an alwaysRun flag, which I have now enabled for the 'make clean' step. -- resolution: -> fixed status: open -> closed ___ Python tracker _

[issue9421] configparser.ConfigParser's getint, getboolean and getfloat don't accept `vars`

Changes by Łukasz Langa : Removed file: http://bugs.python.org/file18457/issue9421.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue9421] configparser.ConfigParser's getint, getboolean and getfloat don't accept `vars`

Łukasz Langa added the comment: Patch updated to never type-convert default= arguments. This behaviour is more predictable. -- Added file: http://bugs.python.org/file18458/issue9421.diff ___ Python tracker ___

[issue5950] Make zipimport work with zipfile containing comments

Terry J. Reedy added the comment: Because it adds a feature to the import statement, rather than to a module, or so Dmitry said. But fine with me if it goes in now. -- stage: -> patch review ___ Python tracker __

[issue9253] argparse: optional subparsers

Changes by Michael.Elsdörfer : -- nosy: +elsdoerfer ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue2521] ABC caches should use weak refs

Daniel Stutzbach added the comment: Jack, The change is necessary because "None in WeakSet()" would throw an exception. -- ___ Python tracker ___ ___

[issue5950] Make zipimport work with zipfile containing comments

Terry J. Reedy added the comment: On #1644818, Brett said import statement is exempt from moratorium. -- ___ Python tracker ___ ___ Py

[issue6678] inspect.currentframe documentation omits optional depth parameter

Terry J. Reedy added the comment: Thank you both. I had missed the subtle difference between aliasing and wrapping in this particular case. -- ___ Python tracker ___ ___

[issue9548] locale can be imported at startup but relies on too many library modules

Marc-Andre Lemburg added the comment: Antoine Pitrou wrote: > > Antoine Pitrou added the comment: > >> I don't think that's the right way forward. >> >> It's much easier to either remove the need to import those >> extra modules or defer their import to actual use within >> a function. > > T

[issue9550] BufferedReader may issue additional read, may cause hang when backed by blocking socket

New submission from Jason V. Miller : While reading, BufferedReader can cause an additional read() to the underlying I/O object after the entire upper-layer byte count has been satisfied. This is unnecessary and troublesome in some cases. In the event that the BufferedReader sits on top of a b

[issue9551] ConfigParser.SafeConfigParser.set fails when no value provided

New submission from Łukasz Langa : Title says it all. -- assignee: fdrake files: ConfigParser.diff keywords: easy, needs review, patch, patch messages: 113490 nosy: fdrake, lukasz.langa priority: normal severity: normal stage: patch review status: open title: ConfigParser.SafeConfigParse

[issue8041] No documentation for Py_TPFLAGS_HAVE_STACKLESS_EXTENSION or Py_TPFLAGS_HAVE_VERSION_TAG.

Daniel Stutzbach added the comment: I think if they are mentioned, they should be documented. Removing mention of them would be fine with me. Looking at this again, I think the description of Py_TPFLAGS_DEFAULT is no longer accurate. It reads: "This is a bitmask of all the bits that pertain

[issue9548] locale can be imported at startup but relies on too many library modules

Antoine Pitrou added the comment: > I said "warn about the use of non-builtin modules", not disallow > their use. AFAIK, the purpose of the exercise is to reduce the > number of non-builtin modules being loaded early on during > Python startup. The purpose of the exercise is to avoid, as much a

[issue7467] The zipfile module does not check files' CRCs, including in ZipFile.testzip

Antoine Pitrou added the comment: This is an updated patch with fixed (hopefully) CRC logic in the face of buffering, and additional tests. -- Added file: http://bugs.python.org/file18461/zipcrc.patch ___ Python tracker

[issue9550] BufferedReader may issue additional read, may cause hang when backed by blocking socket

Changes by R. David Murray : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue7467] The zipfile module does not check files' CRCs, including in ZipFile.testzip

Antoine Pitrou added the comment: Nir, want to take a look? -- nosy: +nirai ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue9550] BufferedReader may issue additional read, may cause hang when backed by blocking socket

Antoine Pitrou added the comment: Thanks for caring about such issues. This would also need unit tests and test_io.py (and perhaps a similar change in _pyio.py, although the buffering logic there is different and may not exhibit the issue). -- stage: -> needs patch versions: +Python

[issue3757] threading.local doesn't support cyclic garbage collecting

Antoine Pitrou added the comment: Committed in r83918 (py3k), r83919 (3.1) and r83920 (2.7) after Benjamin ok'ed it on IRC. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed versions: +Python 2.7, Python 3.1 _

[issue9552] ssl build under Windows always rebuilds OpenSSL

New submission from Antoine Pitrou : The build steps for _ssl and _hashlib under Windows always rebuild the same intermediate files, even if no change was recorded since the last build. This makes building the whole project longer than it should be. Here is the (trimmed) log: -- Début de

[issue8685] set(range(100000)).difference(set()) is slow

Andrew Bennetts added the comment: Alexander: yes, they are complementary. My patch improves set.difference, which always creates a new set. issue8425 on the other hand improves in-place difference (via the -= operator or set.difference_update). Looking at the two patches, my patch will no

[issue9548] locale can be imported at startup but relies on too many library modules

Brett Cannon added the comment: Just to comment on the import lock issue when importing from within a function, it is a problem. If an import triggers the launching of a thread which calls these functions that have an import inside of them, deadlock will occur. This has been reported as an is

[issue6915] os.listdir inconsistenly releases the GIL on win32

Antoine Pitrou added the comment: The original patch also modifies attributes_from_dir() and attributes_from_dir_w(), but these are called with the GIL released. Modified patch committed in r83921 (py3k), r83922 (3.1) and r83923 (2.7). Thank you! -- resolution: -> fixed stage: patch

[issue5504] ctypes should work with systems where mmap can't be PROT_WRITE and PROT_EXEC

Antoine Pitrou added the comment: > I do not know why this happens. The failure is in 3.1, and the reason is quite obvious: the patch relies on libffi/src/closures.c, which doesn't exist in the 3.1 copy of libffi. I've reverted your commit in r83924, since you say you won't be able to look at

[issue5504] ctypes should work with systems where mmap can't be PROT_WRITE and PROT_EXEC

Antoine Pitrou added the comment: Correction: the revert was done in r83926. -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue8432] buildbot: test_send_signal of test_subprocess failure

Antoine Pitrou added the comment: Since it only happens on 3.x, a possible culprit is “[svn r78946] Replaces the internals of the subprocess module from fork through exec on POSIX systems with a C extension module”. NB: recent URL of deterministic failure under FreeBSD 6.4: http://www.python.o

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

New submission from Denver Coneybeare : If the COLUMNS environment variable is set to a value other than 80 then test_argparse.py yields 80 failures. The value of the COLUMNS environment variable affects line wrapping of the help output and the test cases assume line wraps at 80 columns. So

[issue9554] test_argparse.py: use new unittest features

New submission from Denver Coneybeare : Some of the unit testing code in test_argparse.py could be modified to take advantage of the new unittest features in Python 2.7 and 3.x. My suggested changes are attached in the patch file test_argparse.py.unittest2.patch One big one is that assertEqua

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

Changes by Denver Coneybeare : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue9554] test_argparse.py: use new unittest features

Changes by Denver Coneybeare : Removed file: http://bugs.python.org/file18463/test_argparse.py.unittest2.patch ___ Python tracker ___ ___ Pytho

[issue9554] test_argparse.py: use new unittest features

Changes by Denver Coneybeare : Added file: http://bugs.python.org/file18464/test_argparse.py.unittest2.patch ___ Python tracker ___ ___ Python-

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

Changes by Denver Coneybeare : Removed file: http://bugs.python.org/file18462/test_argparse.py.COLUMNS.patch ___ Python tracker ___ ___ Python-

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

Changes by Denver Coneybeare : Added file: http://bugs.python.org/file18465/test_argparse.py.COLUMNS.patch ___ Python tracker ___ ___ Python-bu

[issue9553] test_argparse.py: 80 failures if COLUMNS env var set to a value other than 80

Brian Curtin added the comment: Shouldn't the tests calculate line wrapping based on what is set, rather than brute forcing it to be 80? -- nosy: +brian.curtin stage: -> unit test needed versions: +Python 3.2 -Python 3.3 ___ Python tracker

[issue9551] ConfigParser.SafeConfigParser.set fails when no value provided

Fred L. Drake, Jr. added the comment: Patch still requires a test. Sorry if I was unclear in IRC. -- ___ Python tracker ___ ___ Pytho

[issue9405] crash when calling urllib.getproxies() under OSX with subprocess / particular memory usage

Ronald Oussoren added the comment: I agree that this is an annoying bug, and I'm glad that it doesn't occur in the 27-maint branch. I won't close this issue yet though, I'd prefer to add a unittest that demonstrates the problem in 2.7.0 and shows that the problem is fixed afterwords. Basica

[issue9551] ConfigParser.SafeConfigParser.set fails when no value provided

Changes by Łukasz Langa : Removed file: http://bugs.python.org/file18460/ConfigParser.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue9551] ConfigParser.SafeConfigParser.set fails when no value provided

Łukasz Langa added the comment: Patch now includes a unit test. -- Added file: http://bugs.python.org/file18466/ConfigParser.diff ___ Python tracker ___ _

<    1   2