[issue5932] _json: _convertPyInt_AsSsize_t() never raise any error

New submission from STINNER Victor : _convertPyInt_AsSsize_t() always return 1 (success) even on PyInt_AsSsize_t() error because of a ";" after the if... if (*size_ptr == -1 && PyErr_Occurred()); return 1; Attached patch fixes this issue, and add a regression test. -- comp

[issue5933] fix gcc -Wextra warnings (compare signed/unsigned)

New submission from STINNER Victor : Simple patch to fix some gcc warnings (when using gcc -Wall -Wextra). -- components: Library (Lib) files: sign_warning.patch keywords: patch messages: 87192 nosy: haypo severity: normal status: open title: fix gcc -Wextra warnings (compare signed/unsi

[issue5933] fix gcc -Wextra warnings (compare signed/unsigned)

STINNER Victor added the comment: Another patch to fix similar warnings in resource modules. -- Added file: http://bugs.python.org/file13884/sign_warning_resource.patch ___ Python tracker __

[issue5923] turtle.py update: 1.0 --> 1.1

Gregor Lingl added the comment: Here is a patch for the documentation. It may contain some typos and/or inaccuracies. I promise to check it and submit a patch if necessary before final. It contains also the announcement of two new demo scripts, the one beeing round_dance submitted already, the

[issue5923] turtle.py update: 1.0 --> 1.1

Gregor Lingl added the comment: The second demo script just announced -- Added file: http://bugs.python.org/file13886/tdemo_nim.py ___ Python tracker ___

[issue5934] fix gcc warnings: explicit type conversion for uid/gid in posix

New submission from STINNER Victor : Explicit type conversion to fix gcc -Wextra warnings. The patch doesn't change the behaviour, it just makes gcc quiet. -- components: Library (Lib) files: posix_warnings.patch keywords: patch messages: 87196 nosy: haypo severity: normal status: open

[issue5799] Change ntpath functions to implicitly support UNC paths

Eric Smith added the comment: > I've generated a new patch, attached. I don't know why you had trouble > applying. Yeah, I'm not sure what that was about. Part of the patch applied, but not the rest. In any event, the current one applied cleanly. I'm not sure this part of the patch is correct

[issue5643] test__locale fails with RADIXCHAR on Windows

Hirokazu Yamamoto added the comment: Probably this patch works on recent VisualC++. But unfortunately, this code crashes on VisualC++6 debug build. :-( This happens when 2nd arg of setlocale contains "." and the length of substring after "." is longer than 8. It seems to be msvcrtd bug. --

[issue5890] Subclassing property doesn't preserve the auto __doc__ behavior

R. David Murray added the comment: Reviewed by Georg and approved on #python-dev. Committed in r72299, r72301, r72302, and r72304. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue5935] Better documentation of use of BROWSER environment variable

New submission from Edmund Eyles : The documentation for the webbrowser module at http://www.python.org/doc/2.5/lib/module-webbrowser.html refers to the use of the BROWSER environment variable as a means to control which browser is run. However, it makes no mention of how the browser name(s) in

[issue5923] turtle.py update: 1.0 --> 1.1

R. David Murray added the comment: Gregor, I applied my doctest fixups to turtle.rst in the py3k branch in r72307. I've attached an updated version of your docpatch that applies against this new revision. -- nosy: +r.david.murray Added file: http://bugs.python.org/file13889/issue5923.d

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: > You commit to the trunk, then you do "svnmerge merge -r" in the > 3k branch, then "svn commit -F svnmerge-something.txt" (in case of > conflicts, you fix them first, of course). Done in r72306 for trunk and r72309 for 3k. Thanks. > I'm not sure - I think th

[issue5936] Add MSI suport for uninstalling individual versions

New submission from Steven Bethard : With issue5311 now resolved, bdist_msi can generate a single MSI that can install to any number of Python versions (for pure Python modules). Right now, you can only install or uninstall these MSIs, but it would be nice to also provide a "Change" installation.

[issue5799] Change ntpath functions to implicitly support UNC paths

Larry Hastings added the comment: Sweet jumping rhubarb! I didn't know about this "for ...: else:" construct in Python. When I was editing it I thought it was my editor stumbling over a tab, and the "else" went with the "if" *inside* the "for". You're absolutely right that the current code is

[issue5799] Change ntpath functions to implicitly support UNC paths

Larry Hastings added the comment: As promised, a fresh patch. Note that the current formulation of that troublesome loop in relpath() is *very* much on purpose. The removal of the "else" is no longer a bug :) -- Added file: http://bugs.python.org/file13890/lch.ntpath.r72309.diff

[issue5799] Change ntpath functions to implicitly support UNC paths

Larry Hastings added the comment: Sorry for the quick double-patch, but I realized that there was no test for the obverse case, where "path" is / and "curdir" is non-empty. So I threw in some more tests. -- Added file: http://bugs.python.org/file13891/lch.ntpath.r72309.diff.2

[issue5915] PEP 383 implementation

Martin v. Löwis added the comment: Fixed in r72310 http://codereview.appspot.com/52095/diff/30/1013 File Lib/test/test_codecs.py (right): http://codereview.appspot.com/52095/diff/30/1013#newcode1545 Line 1545: b"foo\xa5bar") On 2009/05/04 12:25:43, Antoine Pitrou wrote: > You decode with iso-8

[issue5915] PEP 383 implementation

Martin v. Löwis added the comment: Committed as r72313 -- resolution: -> accepted status: open -> closed ___ Python tracker ___ ___ P

[issue5937] Problems with dbm documentation

New submission from Mitchell Model : There are some problems with the dbm documentation. In the opening section: 1. The comment before the iteration example says that .values() works, but the method is not defined. 2. The statement in the paragraph after the documentation of dbm.open() says th

[issue5935] Better documentation of use of BROWSER environment variable

Tim Golden added the comment: Edmund Eyles wrote: > New submission from Edmund Eyles : > > The documentation for the webbrowser module at > http://www.python.org/doc/2.5/lib/module-webbrowser.html refers to the > use of the BROWSER environment variable as a means to control which > browser is r

[issue5799] Change ntpath functions to implicitly support UNC paths

Larry Hastings added the comment: I stared at it some more. Now I understand what "for ... : else:" was for in the original. The "else: i += 1" ensures that if the "for" loop runs to completion "i" is set to the length of the shorter of the two lists. Anyway, my reimplemented loop accomplishe

<    1   2