[issue1622] zipfile hangs on certain zip files

2008-01-06 Thread Eric Huss
Eric Huss added the comment: Some of this work has already been done, see issue 1189216. You'll obviously need to keep the CRC unpack as signed because the binascii module uses signed values. Some header values are stored as 0x to denote the value is stored in the 64-bit extended fields

[issue1682] Move Demo/classes/Rat.py to Lib/rational.py and fix it up.

2008-01-06 Thread Mark Dickinson
Mark Dickinson added the comment: Some random comments: take with a large pinch of salt (1) In __init__ I think you want something like: self._numerator = int(numerator)//g instead of self._numerator = int(numerator / g) and similarly for the denominator. At the moment I get, for exampl

[issue1682] Move Demo/classes/Rat.py to Lib/rational.py and fix it up.

2008-01-06 Thread Mark Dickinson
Mark Dickinson added the comment: Two more questions: (1) should a Rational instance be hashable? (2) Should "Rational(5,2) == Decimal('2.5')" evaluate to True or False? If Rationals are hashable and 2.5 == Rational(5, 2) == Decimal('2.5') then the rule that objects that compare equal should

[issue1747] issubclass(NotSubclassOfObject, InstanceOfAbcMeta) fails instead of returning False

2008-01-06 Thread Guido van Rossum
Guido van Rossum added the comment: lgtm -- resolution: -> accepted __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubs

[issue1526] DeprecationWarning in zipfile.py while zipping 113000 files

2008-01-06 Thread Guido van Rossum
Guido van Rossum added the comment: I was about to check this in, when I noticed that the test runs for ~16 seconds on my state-of-the-arg hardware. I think that's too long. Perhaps it should only be run when -ulargefile is enabled? __ Tracker <[EMAIL PROTECTED]

[issue1526] DeprecationWarning in zipfile.py while zipping 113000 files

2008-01-06 Thread Alan McIntyre
Alan McIntyre added the comment: Oh thanks, I meant to ask whether or not the run time was too long, but forgot. Only running when -ulargefile is enabled seems fine to me. I can tweak the patch for that if you'd like; moving it to test_zipfile64 should do that, right? __

[issue1741] .pypirc not found on windows

2008-01-06 Thread Guido van Rossum
Guido van Rossum added the comment: Bug day candidate? 2.5.2 backport candidate. -- nosy: +gvanrossum __ Tracker <[EMAIL PROTECTED]> __ ___ Pyth

[issue1745] Backport of PEP 3102 "keyword-only arguments" to 2.6

2008-01-06 Thread Guido van Rossum
Guido van Rossum added the comment: Thanks for tackling this! What line in test_collections.py is calling a function with >255 args? I'm a bit surprised since this has always been disallowed AFAICT. I'd like to see everything related to keyword-only args included in one patch. Hopefully the u

[issue1745] Backport of PEP 3102 "keyword-only arguments" to 2.6

2008-01-06 Thread Guido van Rossum
Changes by Guido van Rossum: -- keywords: +patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue1622] zipfile hangs on certain zip files

2008-01-06 Thread Guido van Rossum
Guido van Rossum added the comment: Alan and Eric, can I depend on you two to review each other's code and let me know when you think the patch is ready to be submitted? __ Tracker <[EMAIL PROTECTED]>

[issue1526] DeprecationWarning in zipfile.py while zipping 113000 files

2008-01-06 Thread Guido van Rossum
Guido van Rossum added the comment: Sounds like a plan. __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue1747] issubclass(NotSubclassOfObject, InstanceOfAbcMeta) fails instead of returning False

2008-01-06 Thread Jeffrey Yasskin
Jeffrey Yasskin added the comment: Committed as r59809. -- status: open -> closed __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing

[issue1623] Implement PEP-3141 for Decimal

2008-01-06 Thread Jeffrey Yasskin
Jeffrey Yasskin added the comment: Much smaller now. 3.0 will need an additional patch beyond the "automatic" forward port. -- versions: +Python 2.6 Added file: http://bugs.python.org/file9083/decimal-3141-just-trunc.patch __ Tracker <[EMAIL PROTECTED]> <

[issue1713877] Expose callback API in readline module

2008-01-06 Thread strank
strank added the comment: I am pretty sure I posted a patch in the sf patch tracker... oh yes, here it is: http://bugs.python.org/issue1744456 I think it still needs some work if you want to make it impossible for users of the API to wreck the interactive prompt. If this possibility is considere

[issue1751] Fast BytesIO implementation + misc changes

2008-01-06 Thread Alexandre Vassalotti
New submission from Alexandre Vassalotti: Finally, here is my C implementation of BytesIO. The code is well tested and include the proper unit tests. The only remaining issues are: - The behavior of the close() method. - The failure of test_profile and test_cProfile. Currently, I have no ide

[issue1751] Fast BytesIO implementation + misc changes

2008-01-06 Thread Alexandre Vassalotti
Changes by Alexandre Vassalotti: Added file: http://bugs.python.org/file9085/add-bytesio-setup.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-l

[issue1751] Fast BytesIO implementation + misc changes

2008-01-06 Thread Alexandre Vassalotti
Changes by Alexandre Vassalotti: Added file: http://bugs.python.org/file9086/swap-initstdio-initsite.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python-

[issue1751] Fast BytesIO implementation + misc changes

2008-01-06 Thread Alexandre Vassalotti
Changes by Alexandre Vassalotti: Added file: http://bugs.python.org/file9087/test_memoryio.py __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mai

[issue1751] Fast BytesIO implementation + misc changes

2008-01-06 Thread Alexandre Vassalotti
Changes by Alexandre Vassalotti: Added file: http://bugs.python.org/file9088/remove-old-stringio-test.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python

[issue1751] Fast BytesIO implementation + misc changes

2008-01-06 Thread Alexandre Vassalotti
Changes by Alexandre Vassalotti: Added file: http://bugs.python.org/file9089/truncate-semantic-change.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python

[issue1751] Fast BytesIO implementation + misc changes

2008-01-06 Thread Alexandre Vassalotti
Changes by Alexandre Vassalotti: Added file: http://bugs.python.org/file9090/io-misc-fixes.patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list

[issue1751] Fast BytesIO implementation + misc changes

2008-01-06 Thread Alexandre Vassalotti
Changes by Alexandre Vassalotti: -- nosy: +brett.cannon __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue1752] logging.basicConfig misleading behaviour

2008-01-06 Thread Max Ischenko
New submission from Max Ischenko: Function logging.basicConfig has a confusing and undocumented behaviour: it does nothing if there are any handlers already present in root logger. It could be more explicit, say, by giving a ValueError in such cases. -- components: Library (Lib) message

<    1   2