[issue9904] Cosmetic issues that may warrant a fix in symtable.h/c

Eli Bendersky added the comment: Thanks for the clarification, Éric -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue9904] Cosmetic issues that may warrant a fix in symtable.h/c

Éric Araujo added the comment: Yep, code cleanup is not done in the stable branches (except as a by-product of a bugfix). -- nosy: +eric.araujo ___ Python tracker ___ __

[issue9904] Cosmetic issues that may warrant a fix in symtable.h/c

Changes by Eli Bendersky : -- resolution: -> fixed status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue9904] Cosmetic issues that may warrant a fix in symtable.h/c

Eli Bendersky added the comment: I committed the fixes to 3.3 (see no reason to backport these). So unless there are objections I will close the issue in a few days. -- stage: needs patch -> commit review status: open -> pending ___ Python tracker

[issue9904] Cosmetic issues that may warrant a fix in symtable.h/c

Roundup Robot added the comment: New changeset b6fe63c914e4 by Eli Bendersky in branch 'default': Issue #9904: fix and clarify some comments + fix indentation in symtable code http://hg.python.org/cpython/rev/b6fe63c914e4 -- nosy: +python-dev ___ Pyt

[issue9904] Cosmetic issues that may warrant a fix in symtable.h/c

Changes by Eli Bendersky : -- stage: -> needs patch versions: +Python 3.3 -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mail

[issue9904] Cosmetic issues that may warrant a fix in symtable.h/c

Nick Coghlan added the comment: +1 for clarifying the comments. Adding comments for the apparently unused fields (as per my last tracker comment) would be good, too. -- ___ Python tracker _

[issue9904] Cosmetic issues that may warrant a fix in symtable.h/c

Terry J. Reedy added the comment: I would say yes (if you are sure changes are correct) unless Nick speaks up to say he wants to review first. -- ___ Python tracker ___

[issue9904] Cosmetic issues that may warrant a fix in symtable.h/c

Eli Bendersky added the comment: Terry, Nick - is it OK to commit a fix for the comments? -- ___ Python tracker ___ ___ Python-bugs-li

[issue9904] Cosmetic issues that may warrant a fix in symtable.h/c

Nick Coghlan added the comment: If I recall correctly, st_nblocks and st_future are there for consistency with the corresponding compiler structures. I believe st_future is also needed whenever a future flag affects the symtable construction (there aren't any at the moment, but a trawl throug

[issue9904] Cosmetic issues that may warrant a fix in symtable.h/c

Terry J. Reedy added the comment: I think this needs at least two patches: one to change comments, another to remove two fields. Can you prepare something? -- nosy: +terry.reedy ___ Python tracker

[issue9904] Cosmetic issues that may warrant a fix in symtable.h/c

Changes by Eli Bendersky : -- title: Cosmetic issues that might be worthy a fix in symtable.h/c -> Cosmetic issues that may warrant a fix in symtable.h/c ___ Python tracker ___