[issue9858] Python and C implementations of io are out of sync

Antoine Pitrou added the comment: I've pushed this to the default branch. Thanks! -- resolution: -> fixed stage: commit review -> resolved status: open -> closed versions: -Python 2.7, Python 3.4 ___ Python tracker

[issue9858] Python and C implementations of io are out of sync

Roundup Robot added the comment: New changeset 962b42d67b9e by Antoine Pitrou in branch 'default': Issue #9858: Add missing method stubs to _io.RawIOBase. Patch by Laura Rupprecht. https://hg.python.org/cpython/rev/962b42d67b9e -- nosy: +python-dev

[issue9858] Python and C implementations of io are out of sync

Antoine Pitrou added the comment: __weakref__ is just an implementation detail of how heap types expose weak references (actually, I'm not sure why it's exposed at all). Laura, thank you for contributing. Your patch looks good to me. -- assignee: gregory.p.smith -> resolution: accepte

[issue9858] Python and C implementations of io are out of sync

Robert Collins added the comment: I think ignoring weakref is wrong: it means the two implementations are different. -- nosy: +rbcollins ___ Python tracker ___ __

[issue9858] Python and C implementations of io are out of sync

Laura Rupprecht added the comment: Can anyone provide feedback on this patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue9858] Python and C implementations of io are out of sync

Laura Rupprecht added the comment: There were originally three methods present in RawIOBase that were not present in PyRawIOBase_Type: 1. readinto 2. write 3. __weakref__ I've created a patch that adds the first two to PyRawIOBase_Type. The python class readinto and write methods raise Unsupp

[issue9858] Python and C implementations of io are out of sync

Changes by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue9858] Python and C implementations of io are out of sync

Gregory P. Smith added the comment: A test has been added as part of issue9859, it is marked with @unittest.skip as the API surface does not yet match. -- nosy: +gregory.p.smith ___ Python tracker _

[issue9858] Python and C implementations of io are out of sync

Mark Lawrence added the comment: Is there anything left to do on this or can it be closed as fixed? -- nosy: +BreamoreBoy versions: +Python 3.4, Python 3.5 -Python 3.1, Python 3.2 ___ Python tracker

[issue9858] Python and C implementations of io are out of sync

Changes by John O'Connor : -- nosy: +jcon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue9858] Python and C implementations of io are out of sync

Benjamin Peterson added the comment: 2010/9/15 Daniel Stutzbach : > > Daniel Stutzbach added the comment: > >> Hmm, none the less other code expects it. > > Does that imply that there's some code that will break on FileIO objects that > are created using a file descriptor instead of a filename

[issue9858] Python and C implementations of io are out of sync

Daniel Stutzbach added the comment: > Hmm, none the less other code expects it. Does that imply that there's some code that will break on FileIO objects that are created using a file descriptor instead of a filename? If so, where? -- ___ Python tr

[issue9858] Python and C implementations of io are out of sync

Benjamin Peterson added the comment: 2010/9/15 Daniel Stutzbach : > > Daniel Stutzbach added the comment: > > Roundup does not play well with Gmail when Gmail is in Rich Format mode ;-) > > That example should have read: > f = io.FileIO(1) f.name > 1 Hmm, none the less other code exp

[issue9858] Python and C implementations of io are out of sync

Daniel Stutzbach added the comment: Roundup does not play well with Gmail when Gmail is in Rich Format mode ;-) That example should have read: >>> f = io.FileIO(1) >>> f.name 1 -- ___ Python tracker _

[issue9858] Python and C implementations of io are out of sync

Changes by Daniel Stutzbach : Removed file: http://bugs.python.org/file18890/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue9858] Python and C implementations of io are out of sync

Daniel Stutzbach added the comment: On Wed, Sep 15, 2010 at 10:51 AM, Benjamin Peterson wrote: > I'm not sure if this pickling stuff matters as long as they both pickle. > I'm not sure either. Do other Python implementations try to maintain a compatible pickle format with CPython? If so, I t

[issue9858] Python and C implementations of io are out of sync

Benjamin Peterson added the comment: 2010/9/15 Daniel Stutzbach : > > Daniel Stutzbach added the comment: > >> These attributes exist; they're just not properties. > > Yes, I see. They're added to the instance in the constructor, so they don't > exist as attributes of the class. Also in that

[issue9858] Python and C implementations of io are out of sync

Daniel Stutzbach added the comment: > These attributes exist; they're just not properties. Yes, I see. They're added to the instance in the constructor, so they don't exist as attributes of the class. Also in that category: BlockingIOError python is missing: ['characters_written'] That lea

[issue9858] Python and C implementations of io are out of sync

Benjamin Peterson added the comment: 2010/9/15 Daniel Stutzbach : > > Daniel Stutzbach added the comment: > > Attached is a script to find all of the mismatches between the C and Python > implementations.  There are several.  Below is the output: > > BufferedRandom python is missing: ['raw'] >

[issue9858] Python and C implementations of io are out of sync

Daniel Stutzbach added the comment: FWIW, I just opened Issue9859: Add tests to verify API match of modules with 2 implementations. -- ___ Python tracker ___ ___

[issue9858] Python and C implementations of io are out of sync

Daniel Stutzbach added the comment: Attached is a script to find all of the mismatches between the C and Python implementations. There are several. Below is the output: RawIOBase C is missing: ['readinto', 'write'] StringIO C is missing: ['name'] StringIO python is missing: ['__getstate__',