[issue964437] idle help is modal

Roger Serwy added the comment: I pulled the latest repo with the patch for 2.7. It works. -- ___ Python tracker ___ ___ Python-bugs-

[issue964437] idle help is modal

Terry J. Reedy added the comment: I was sure I had reverted, but did again, redownloaded, applied, and tested, and all well, so committed and pushed. 2.7 required hand-patching of ', modal' for chunk 5 due to 3rd argument being 'textFile.read()' instead of 'contents'. I presume I got it right

[issue964437] idle help is modal

Roundup Robot added the comment: New changeset 5452c881bd2d by Terry Jan Reedy in branch '2.7': Issue 964437 Make IDLE help window non-modal. http://hg.python.org/cpython/rev/5452c881bd2d New changeset a949956a80cc by Terry Jan Reedy in branch '3.2': Issue 964437 Make IDLE help window non-modal

[issue964437] idle help is modal

Roger Serwy added the comment: Those four lines are present just in case self.root is not initialized. Even if you short-circuit the behavior and set parent=self.top, the patch still works, only that closing the calling EditorWindow instance also closes the help dialog. I tested the patch a

[issue964437] idle help is modal

Terry J. Reedy added the comment: I retried and get same behavior: help closes with closing of edit window and trying to reopen from shell closes idle with about 2 second delay. Does this +if self.root: +parent = self.root +else: +parent = self.top really

[issue964437] idle help is modal

Roger Serwy added the comment: Attached is a reworked patch to handle the nonmodal help dialog. It replaces the decorator _singledialog with a call to a singleton HelpDialog class. The class creates the textView widget using as its parent the root Tk window instance instead of the EditorWindo

[issue964437] idle help is modal

Terry J. Reedy added the comment: Download, tested on W7, 3.2.2. Started help, brought to front, stopped, restarted, in both shell and edit window and all fine *except* when I closed edit window with help attached, which closes help also, and tried to open help in shell, idle 'silently' crash

[issue964437] idle help is modal

Roger Serwy added the comment: I ran reindent and resubmitted the patch. The patch works fine on Ubuntu 11.04. One very subtle design issue with the patch is that the help window is tied to the calling EditorWindow instance. If the editor (or shell) closes, so does the help window, even if ot

[issue964437] idle help is modal

Ned Deily added the comment: Thanks, Roger. I did a quick smoke test of the patch on OS X 10.7 with Cocoa Tk. I didn't see any obvious problems. Of course, it needs to be tested on Windows and with X11 on a Unix platform. Note, that there are some spurious spaces at a few ends-of-lines.

[issue964437] idle help is modal

Roger Serwy added the comment: Attached is an updated version of Guilherme's patch against 3.3a0. It does make the help window non-modal. -- Added file: http://bugs.python.org/file24421/help_nonmodal_updated.patch ___ Python tracker

[issue964437] idle help is modal

Terry J. Reedy added the comment: I agree that modal is a nuisance. Another problem with the help text window is that, on my system, it opens too narrow -- about 2/3rds the width of a shell or edit window. So many line are wrapped. Is this easy to fix and include with this patch, or does it n

[issue964437] idle help is modal

Changes by Ezio Melotti : -- nosy: +terry.reedy stage: -> patch review versions: +Python 3.3 -Python 3.2 ___ Python tracker ___ ___

[issue964437] idle help is modal

Éric Araujo added the comment: Making the help window non-modal sounds like a great change to me. -- nosy: +eric.araujo versions: +Python 3.2 ___ Python tracker ___ ___

[issue964437] idle help is modal

Guilherme Polo <[EMAIL PROTECTED]> added the comment: Hi, This patch makes Help dialog executes as nonmodal. I added a new button at textView.py to demonstrate the behavior, also, I created a decorator called _singledialog at EditorWindow so just one Help window executes at a time, trying to sta