[issue9313] distutils error on MSVC older than 8

Changes by Berker Peksag : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue9313] distutils error on MSVC older than 8

Francis MB added the comment: > Distutils2 is dead. I wasn't aware of that and I'm sorry for that. In that case that issue can IMHO be closed. -- ___ Python tracker ___ _

[issue9313] distutils error on MSVC older than 8

Mark Lawrence added the comment: Distutils2 is dead. -- components: -Distutils2 nosy: +BreamoreBoy, dstufft ___ Python tracker ___ ___

[issue9313] distutils error on MSVC older than 8

Francis MB added the comment: Hi Éric, are the changes to distutils2 applied? could the issue be closed (has resolution:fixed) or is something to be done? -- nosy: +francismb ___ Python tracker

[issue9313] distutils error on MSVC older than 8

Éric Araujo added the comment: Martin: Just applying the same changes to distutils2. -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue9313] distutils error on MSVC older than 8

Martin v. Löwis added the comment: Éric, what forward porting exactly needs to be done? -- ___ Python tracker ___ ___ Python-bugs-list

[issue9313] distutils error on MSVC older than 8

Éric Araujo added the comment: Re-opening to remind myself about the forward-port. -- assignee: ocean-city -> eric.araujo components: -Tests status: closed -> open versions: +3rd party ___ Python tracker _

[issue9313] distutils error on MSVC older than 8

Hirokazu Yamamoto added the comment: > I’ve heard about import deadlock issues, and performance is not an > issue in tests, so there is no reason to import in the function distutils.msvc9compiler imports winreg internally, and it only exists on windows, so importing distutils.msvc9. compile

[issue9313] distutils error on MSVC older than 8

Éric Araujo added the comment: Looks excellent, just import the function at the module scope instead of function scope (I’ve heard about import deadlock issues, and performance is not an issue in tests, so there is no reason to import in the function). Please backport to 3.1 and 2.7 if the bu

[issue9313] distutils error on MSVC older than 8

Changes by Hirokazu Yamamoto : -- assignee: tarek -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue9313] distutils error on MSVC older than 8

Hirokazu Yamamoto added the comment: How about attached patch? I confirmed this both on MSVC8 and MSVC6. -- assignee: -> tarek Added file: http://bugs.python.org/file18863/py3k_skip_in_distutils_test.patch ___ Python tracker

[issue9313] distutils error on MSVC older than 8

Changes by Éric Araujo : -- assignee: tarek -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue9313] distutils error on MSVC older than 8

Éric Araujo added the comment: (Adding distutils2 component so that forward-porting the patch is not forgotten.) -- assignee: -> tarek components: +Distutils2 ___ Python tracker __

[issue9313] distutils error on MSVC older than 8

Éric Araujo added the comment: Wouldn’t it be more accurate to skip the test instead of returning None (falsely indicating success)? -- ___ Python tracker ___ __

[issue9313] distutils error on MSVC older than 8

Hirokazu Yamamoto added the comment: Fixed in r84753(py3k). -- assignee: tarek -> resolution: -> fixed stage: -> committed/rejected status: open -> closed versions: +Python 2.7 ___ Python tracker ___

[issue9313] distutils error on MSVC older than 8

Hirokazu Yamamoto added the comment: Other test functions already have such skips. So I think another skip is acceptable here. But maybe it's better to skip entire msvc9compilerTestCase class (by class decorator). -- ___ Python tracker

[issue9313] distutils error on MSVC older than 8

Éric Araujo added the comment: I don’t know the details of MSVC versions, but the error message seems to mean that this version is not supported, so there is nothing to fix. -- nosy: +loewis, merwok ___ Python tracker

[issue9313] distutils error on MSVC older than 8

New submission from Hirokazu Yamamoto : I got an error while testing py3k on VC6. Here is a patch. == ERROR: test_remove_visual_c_ref (distutils.tests.test_msvc9compiler.msvc9compile rTestCase) --