[issue9292] Dead code in Modules/pyexpat.c

Benjamin Peterson added the comment: r83834 -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker ___ __

[issue9292] Dead code in Modules/pyexpat.c

Fred L. Drake, Jr. added the comment: This patch looks good to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue9292] Dead code in Modules/pyexpat.c

Brian Brazil added the comment: The attached patch removes the dead code, regrtest is happy. -- keywords: +patch nosy: +bbrazil Added file: http://bugs.python.org/file18438/xmlparse_ParseFile-dead-code.patch ___ Python tracker

[issue9292] Dead code in Modules/pyexpat.c

Changes by Antoine Pitrou : -- keywords: +easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue9292] Dead code in Modules/pyexpat.c

Changes by Fred L. Drake, Jr. : -- nosy: +fdrake ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue9292] Dead code in Modules/pyexpat.c

Georg Brandl added the comment: "fp" can probably be just removed? -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-list

[issue9292] Dead code in Modules/pyexpat.c

New submission from Antoine Pitrou : There's some dead code in xmlparse_ParseFile() in Modules/pyexpat.c: the file pointer "fp" is always NULL, and as such the following code can never get entered into: if (fp) { bytes_read = fread(buf, sizeof(char), BUF_SIZE, fp);