[issue9239] zipfile: truncating comment can corrupt the zipfile

Antoine Pitrou added the comment: Thanks, committed! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue9239] zipfile: truncating comment can corrupt the zipfile

Roundup Robot added the comment: New changeset e13c9f99fbae by Antoine Pitrou in branch '3.2': Issue #9239: add tests for modifying zipfile comments in append mode. http://hg.python.org/cpython/rev/e13c9f99fbae New changeset b299b4279e13 by Antoine Pitrou in branch 'default': Issue #9239: add t

[issue9239] zipfile: truncating comment can corrupt the zipfile

Serhiy Storchaka added the comment: > Then the tests may still be added to test_zipfile? Yes, they may. Here is a patch with adapted for 3.3 tests only. -- Added file: http://bugs.python.org/file26216/zipfile_appendmode_comment_tests.patch ___ Pyth

[issue9239] zipfile: truncating comment can corrupt the zipfile

Antoine Pitrou added the comment: > The bug is no longer there. Probably it is fixed in issue14399. Then the tests may still be added to test_zipfile? -- assignee: alanmcintyre -> nosy: +pitrou priority: high -> normal ___ Python tracker

[issue9239] zipfile: truncating comment can corrupt the zipfile

Serhiy Storchaka added the comment: Anyone may close the issue as "out of date"? -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue9239] zipfile: truncating comment can corrupt the zipfile

Serhiy Storchaka added the comment: The bug is no longer there. Probably it is fixed in issue14399. -- nosy: +storchaka ___ Python tracker ___ ___

[issue9239] zipfile: truncating comment can corrupt the zipfile

Changes by Antoine Pitrou : -- stage: -> patch review type: performance -> behavior versions: +Python 3.3 ___ Python tracker ___ ___ P

[issue9239] zipfile: truncating comment can corrupt the zipfile

Changes by Georg Brandl : -- assignee: aimacintyre -> alanmcintyre nosy: +alanmcintyre -aimacintyre ___ Python tracker ___ ___ Python-b

[issue9239] zipfile: truncating comment can corrupt the zipfile

Georg Brandl added the comment: Patch looks good to me. Alan, can you comment? -- assignee: -> aimacintyre nosy: +aimacintyre, georg.brandl priority: normal -> high ___ Python tracker

[issue9239] zipfile: truncating comment can corrupt the zipfile

New submission from Ryan Kelly : If you open a ZipFile in append mode and modify the comment to be shorter than what was originally there, the file will become corrupted. Truncated data from the original comment is left "dangling" at the end of the zipfile. A much more trivial bug discovered