[issue8999] Add Mercurial support to patchcheck

Éric Araujo added the comment: Great, thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue8999] Add Mercurial support to patchcheck

Georg Brandl added the comment: Applied in r85767. -- nosy: +georg.brandl resolution: -> accepted status: open -> closed ___ Python tracker ___ _

[issue8999] Add Mercurial support to patchcheck

Éric Araujo added the comment: > [...] using a simple "hg status" of the working copy will not do the right > thing I think all of these workflows share a step where you have edits in your working directory that are not in the working dir’s parent changeset. Thus, I argue that hg status is h

[issue8999] Add Mercurial support to patchcheck

Brett Cannon added the comment: Good point, Antoine. Then I might leave this patch for now and come back to it when we do the Hg transition. -- assignee: brett.cannon -> ___ Python tracker ___

[issue8999] Add Mercurial support to patchcheck

Antoine Pitrou added the comment: > As for Hg support, enough people seem to run mq on top of svn to make > this a reasonable thing to add now and to change once the transition > occurs. Yes, but the question is what workflow it should assume. If you are running mq for example (or pbranch, or d

[issue8999] Add Mercurial support to patchcheck

Brett Cannon added the comment: So patchcheck is meant for both contributors and committers. I originally wrote it for me, but it helps make sure the patch is in a reasonable state before someone submits a patch. As for Hg support, enough people seem to run mq on top of svn to make this a re

[issue8999] Add Mercurial support to patchcheck

Antoine Pitrou added the comment: The purpose of patchcheck.py is not obvious to me. If it's meant to be used by committers (rather than contributors), than we should wait for the actual hg migration and the definition of our new workflow. Also, we might "need" two separate scripts: one for i

[issue8999] Add Mercurial support to patchcheck

Éric Araujo added the comment: s/usage/order/ *sigh* -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue8999] Add Mercurial support to patchcheck

Éric Araujo added the comment: Updated. I also changed two sets to lists, to retain usage. I’m sure that Mercurial won’t print the same filename twice, and I’m nearly sure Subversion won’t either. Retaining order will make the report a bit more readable. -- Added file: http://bugs.pyt

[issue8999] Add Mercurial support to patchcheck

Changes by Éric Araujo : Removed file: http://bugs.python.org/file17674/hg-support.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue8999] Add Mercurial support to patchcheck

Alexander Belopolsky added the comment: A small suggestion: rather than having bool hg which means Mercurial if true and SVN if false, consider a string valued vc variable with 'svn' for SVN and 'hg' for Mercurial. This way it will be straightforward to add support for other VC systems in t

[issue8999] Add Mercurial support to patchcheck

Changes by Éric Araujo : -- keywords: +needs review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue8999] Add Mercurial support to patchcheck

Éric Araujo added the comment: In the absence of formal testing, a few comments on my patch to help reviewers. 1) If the code is both an svn and hg checkout, hg wins, since it’s not unheard of to use hg on top of svn, whereas the contrary does not make sense to me. 2) The hg status command do

[issue8999] Add Mercurial support to patchcheck

Éric Araujo added the comment: Adding nosy from the other patchcheck bug, hope it doesn’t annoy anyone. -- nosy: +belopolsky, brett.cannon, mark.dickinson, pitrou ___ Python tracker

[issue8999] Add Mercurial support to patchcheck

New submission from Éric Araujo : I got bored of manually changing the svn status command to hg status when testing my patch for #8912, so I made a proper patch once and for all. (Did I already say yay for Mercurial Queues?) -- components: Demos and Tools files: hg-support.diff keyword