[issue8809] smtplib should support SSL contexts

Kasun Herath added the comment: Thanks Antoine -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue8809] smtplib should support SSL contexts

Antoine Pitrou added the comment: Thank you Kasun. I did a couple of minor style fixes (whitespace at end of line, and spaces around the '=' assignment sign). I also added a test for starttls(), since it turns out gmail.com supports it on port 25. -- resolution: -> fixed stage: patch

[issue8809] smtplib should support SSL contexts

Roundup Robot added the comment: New changeset 6737de76487b by Antoine Pitrou in branch 'default': Issue #8809: The SMTP_SSL constructor and SMTP.starttls() now support http://hg.python.org/cpython/rev/6737de76487b -- nosy: +python-dev ___ Python tra

[issue8809] smtplib should support SSL contexts

Kasun Herath added the comment: I added a test to smtpnet and submitting a separate patch for it as my test_smtpnet.py file was old and could have had conflicts. I didn't use keys and certificates for the SSLContext as those would have to be shipped with the source. Looking forward for review

[issue8809] smtplib should support SSL contexts

Kasun Herath added the comment: Yes, I would like to have a try at it -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue8809] smtplib should support SSL contexts

Antoine Pitrou added the comment: Thank you, the patch looks good. A simple test could probably be added to test_smtpnet, along the lines of the existing tests, do you want to tackle that? -- stage: needs patch -> patch review ___ Python tracker

[issue8809] smtplib should support SSL contexts

Kasun Herath added the comment: Thanks for the quick review. I'm submitting a new patch with changes suggested. -- Added file: http://bugs.python.org/file21791/smtp_sslcontext_updated3.patch ___ Python tracker

[issue8809] smtplib should support SSL contexts

Antoine Pitrou added the comment: So, thanks for the new patch. I tested it with my ISP's server and it works fine! Two remaining issues though: - in the SMTP_SSL constructor, you must add the "context" argument at the end of the argument list (after "timeout"), otherwise someone passing "tim

[issue8809] smtplib should support SSL contexts

Antoine Pitrou added the comment: For the record, issue11927 reminds me that test_smtpnet actually has a trivial test for SMTP-over-SSL. -- ___ Python tracker ___ __

[issue8809] smtplib should support SSL contexts

Kasun Herath added the comment: I did another patch based on feedback given. A test for SMTP_SSL wasn't added; will look into it later. Tab character that were present are removed. Also SSLContext support was added to starttls() but it is slightly different from the starttls() implementation

[issue8809] smtplib should support SSL contexts

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue8809] smtplib should support SSL contexts

Antoine Pitrou added the comment: Thanks for the patch. A couple of comments: - it would be nice to have some tests, but of course there are no tests for SMTP_SSL currently. If you are motivated, perhaps you could investigate into adding some. - there are some tab characters in your patch. Ple

[issue8809] smtplib should support SSL contexts

Kasun Herath added the comment: I'm submitting a new patch with changes suggested by Terry. But I feel an example of how to use a SSLContext inside the Docstring of SMTP_SSL constructor is unnecessary since no smtp specific things are done to the passed SSLContext. Any ideas about this sugges

[issue8809] smtplib should support SSL contexts

david added the comment: It should also explain how the context can be used. An example of how to use it to establish a 'secured' connection would be a nice to have. -- ___ Python tracker

[issue8809] smtplib should support SSL contexts

Terry J. Reedy added the comment: This sentence is awkward, at best. "Alternative to a private key and a certificate key an optional SSLContext could be specified." I suggest something like: "SSLcontext, also optional, is an alternative to keyfile and certfile; if it is specified, keyfile and

[issue8809] smtplib should support SSL contexts

Kasun Herath added the comment: I did a patch that allows smtplib.SMTP_SSL constructor to accept an optional SSLContext -- keywords: +patch nosy: +kasun Added file: http://bugs.python.org/file21730/smtp_sslcontext.patch ___ Python tracker

[issue8809] smtplib should support SSL contexts

Changes by R. David Murray : -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue8809] smtplib should support SSL contexts

Antoine Pitrou added the comment: > Is anybody working on this issue? If not, I think it looks like it > might be a nice one for me to tackle. I'll go ahead unless there are > any objections. Nobody is working on it AFAIK. Feel free to give it a try :) -- _

[issue8809] smtplib should support SSL contexts

Thomas Scrace added the comment: Is anybody working on this issue? If not, I think it looks like it might be a nice one for me to tackle. I'll go ahead unless there are any objections. -- nosy: +thomas.scrace ___ Python tracker

[issue8809] smtplib should support SSL contexts

Changes by david : -- nosy: +db ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/o

[issue8809] smtplib should support SSL contexts

Changes by Antoine Pitrou : -- title: smptlib should support SSL contexts -> smtplib should support SSL contexts ___ Python tracker ___ __