[issue8734] msvcrt get_osfhandle crash on bad FD

Antoine Pitrou added the comment: Ok, I've committed the patch in r84506 (3.x), r84507 (3.1) and r84508 (2.7). Thank you! -- resolution: accepted -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue8734] msvcrt get_osfhandle crash on bad FD

Pascal Chambon added the comment: I guess it should, shouldn't it ? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue8734] msvcrt get_osfhandle crash on bad FD

Antoine Pitrou added the comment: Should this be checked in? -- nosy: +pitrou versions: +Python 3.1, Python 3.2 ___ Python tracker ___ ___

[issue8734] msvcrt get_osfhandle crash on bad FD

Amaury Forgeot d'Arc added the comment: The second patch looks good to me. -- resolution: -> accepted stage: patch review -> commit review ___ Python tracker ___ ___

[issue8734] msvcrt get_osfhandle crash on bad FD

Changes by Pascal Chambon : Removed file: http://bugs.python.org/file17369/msvcrt_crash.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue8734] msvcrt get_osfhandle crash on bad FD

Pascal Chambon added the comment: My bad, here is a better patch... -- Added file: http://bugs.python.org/file17382/msvcrt_crash2.patch ___ Python tracker ___ ___

[issue8734] msvcrt get_osfhandle crash on bad FD

Amaury Forgeot d'Arc added the comment: I agree with the fix. However the patch should test for "sys.platform == 'win32'" before importing msvcrt. And there is an extra space on another line. -- nosy: +amaury.forgeotdarc stage: -> patch review ___

[issue8734] msvcrt get_osfhandle crash on bad FD

New submission from Pascal Chambon : In python trunk, _set_invalid_parameter_handler() has been dropped and replaced by custom checking functions, but in msvcrt.get_osfhandle() these checks aren't present, so providing a bad FD leads to a crash. Here is the little fix + a test (added to test_f