[issue8684] improvements to sched.py

Giampaolo Rodola' added the comment: This should now be fixed. Thanks for signaling. -- status: open -> closed ___ Python tracker ___

[issue8684] improvements to sched.py

Roundup Robot added the comment: New changeset 50267d2bb320 by Giampaolo Rodola' in branch 'default': (bug #8684) fix 'fedora without thread buildbot' as per http://bugs.python.org/issue8684 http://hg.python.org/cpython/rev/50267d2bb320 -- ___ Pytho

[issue8684] improvements to sched.py

Charles-François Natali added the comment: This broken the "Fedora without thread buildbot", since sched now requires the threading module: http://www.python.org/dev/buildbot/all/builders/AMD64 Fedora without threads 3.x/builds/1250/steps/test/logs/stdio -- nosy: +neologix status: clo

[issue8684] improvements to sched.py

Changes by Giampaolo Rodola' : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue8684] improvements to sched.py

Roundup Robot added the comment: New changeset f5aed0dba844 by Giampaolo Rodola' in branch 'default': Fix #8684: make sched.scheduler class thread-safe http://hg.python.org/cpython/rev/f5aed0dba844 -- nosy: +python-dev ___ Python tracker

[issue8684] improvements to sched.py

Giampaolo Rodola' added the comment: New patch in attachment. I'll commit it later today. -- nosy: +rhettinger Added file: http://bugs.python.org/file23925/sched-thread-safe.patch ___ Python tracker ___

[issue8684] improvements to sched.py

Antoine Pitrou added the comment: > Versions #2 and #3 have the same cost, so it's better to get rid of > the explicit argument and always use the lock (version #3). > Differences between #1 and #3 suggest that introducing the lock > obviously have a cost though. > It's not too high IMO, but I c

[issue8684] improvements to sched.py

Giampaolo Rodola' added the comment: This is what I get by using bench.py script attached to issue13451: CURRENT VERSION (NO LOCK) test_cancel: time=0.67457 : calls=1 : stdev=0.0 test_empty : time=0.00025 : calls=1 : stdev=0.0 test_enter

[issue8684] improvements to sched.py

Antoine Pitrou added the comment: > Are you suggesting to enable thread-synchronization by default and get > rid of explicit "synchronized" argument? That would be even better indeed, if you find out that there's no significant performance degradation. -- _

[issue8684] improvements to sched.py

Giampaolo Rodola' added the comment: Are you suggesting to enable thread-synchronization by default and get rid of explicit "synchronized" argument? -- ___ Python tracker ___ __

[issue8684] improvements to sched.py

Antoine Pitrou added the comment: I'm not convinced by the decorator approach. Why not simply add "with self.lock" at the beginning of each protected method? It would actually save a function call indirection. -- stage: -> patch review versions: +Python 3.3 -Python 3.2 _

[issue8684] improvements to sched.py

Giampaolo Rodola' added the comment: Updated patch adding a synchronized argument to scheduler class and updating doc is in attachment. -- Added file: http://bugs.python.org/file23903/sched-thread-safe.patch ___ Python tracker

[issue8684] improvements to sched.py

Giampaolo Rodola' added the comment: Looking back at this patch, I think we can extract the thread-synchronization parts and the peek() method, as they're both valuable additions, especially the first one. The very sched doc says: > In multi-threaded environments, the scheduler class has lim

[issue8684] improvements to sched.py

Changes by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue8684] improvements to sched.py

Giampaolo Rodola' added the comment: Josiah are you still interested in this? -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue8684] improvements to sched.py

Giampaolo Rodola' added the comment: sched.py tests have been checked in. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue8684] improvements to sched.py

Changes by R. David Murray : -- dependencies: +sched.py module doesn't have a test suite superseder: sched.py module doesn't have a test suite -> ___ Python tracker ___ _

[issue8684] improvements to sched.py

Giampaolo Rodola' added the comment: Created issue 8687 to address the test suite problem. -- superseder: -> sched.py module doesn't have a test suite ___ Python tracker ___ ___

[issue8684] improvements to sched.py

Giampaolo Rodola' added the comment: What are the enhancements introduced by this patch? A faster cancel() implementation? If so some simple benchmarks showing the speed improvement of cancel() and eventually also other methods like enterabs() and run() would be nice to have. I've noticed ther

[issue8684] improvements to sched.py

Antoine Pitrou added the comment: By the way, the patch lacks docs for new public APIs. -- ___ Python tracker ___ ___ Python-bugs-list

[issue8684] improvements to sched.py

Antoine Pitrou added the comment: This must be retargeted to 3.2. Also, the patch lacks some tests. It seems PEP 8 compliance could be better: function names shouldn't be CamelCased. Is LocalSynchronize() an implementation detail rather than a public API? If so, I think it would be better if i

[issue8684] improvements to sched.py

New submission from Josiah Carlson : This patch is against Python trunk, but it could be easily targeted for Python 3.2 . It is meant to extract the scheduler updates from issue1641 without mucking with asyncore. It's reach is reduced and simplified, which should make maintenance a bit easie