[issue8577] test_distutils fails if srcdir != builddir

Ronald Oussoren added the comment: As r82005 fixed the problem this issue can be closed. -- assignee: ronaldoussoren -> nobody nosy: +nobody status: open -> closed ___ Python tracker ___

[issue8577] test_distutils fails if srcdir != builddir

Ronald Oussoren added the comment: Tarek: I'm not 100% that all my changes in Lib/distutils were backported to 3.1. This last patch definitely wasn't, but isn't also isn't relevant for 3.1. -- ___ Python tracker _

[issue8577] test_distutils fails if srcdir != builddir

Tarek Ziadé added the comment: As I said earlier, I am going to revert Distutils state in py3k so it's like the 3.1 branch. So the changes in distutils/ in py3k that are not backported in 3.1 will be lost. I had a lack of time lately, but I should be able to do it this week. --

[issue8577] test_distutils fails if srcdir != builddir

Ronald Oussoren added the comment: This should be fixed in r82005, this passes all tests both with and without srcdir==builddir -- ___ Python tracker ___ ___

[issue8577] test_distutils fails if srcdir != builddir

Ronald Oussoren added the comment: Sigh. test.test_distutils behaves different when run through regrtest than when run directly. I have a fix, but am running an extended test cycle before committing (that is, both with and without srcdir==builddir) -- ___

[issue8577] test_distutils fails if srcdir != builddir

Antoine Pitrou added the comment: Looks like this just broke the 3.x buildbots. == FAIL: test_get_python_inc (distutils.tests.test_sysconfig.SysconfigTestCase) --

[issue8577] test_distutils fails if srcdir != builddir

Ronald Oussoren added the comment: I've fixed this issue for the 3.2 branch in r81999. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue8577] test_distutils fails if srcdir != builddir

Ronald Oussoren added the comment: I intend to forward port the fix to 3.2 in the near future, to avoid missing real issues when I do updates to the platform support for OSX. -- ___ Python tracker

[issue8577] test_distutils fails if srcdir != builddir

Roumen Petrov added the comment: Hmm, this issue was fixed before. My be restore of 2.6 distutils ignore those fixes. It is good to compare current Lib/distutils/sysconfig.py with version from Dec 2009 . -- nosy: +rpetrov ___ Python tracker

[issue8577] test_distutils fails if srcdir != builddir

Tarek Ziadé added the comment: Fixed in r80649, r80650 I'll merge in the py3k branch once I've reverted distutils there -- ___ Python tracker ___ __

[issue8577] test_distutils fails if srcdir != builddir

Changes by Tarek Ziadé : -- versions: +Python 2.6, Python 3.1, Python 3.2, Python 3.3 ___ Python tracker ___ ___ Python-bugs-list maili

[issue8577] test_distutils fails if srcdir != builddir

Ronald Oussoren added the comment: Yes, sorry about that. The patch in unixcompiler is for issue #7724. -- ___ Python tracker ___ ___

[issue8577] test_distutils fails if srcdir != builddir

Tarek Ziadé added the comment: Yes it's pretty similar to what I've done in my earlier message. No need to call os.path.dirname(get_makefile_filename()), os.path.dirname(sys.executable) is enough. I guess the patch part concerning unixcompiler is unrelated to this issue, right ? --

[issue8577] test_distutils fails if srcdir != builddir

Ronald Oussoren added the comment: Actually attaching the patch might help. With this patch test_distutils passes, without it it doesn't. -- keywords: +patch Added file: http://bugs.python.org/file17147/issue8577.patch ___ Python tracker

[issue8577] test_distutils fails if srcdir != builddir

Ronald Oussoren added the comment: It does work just fine, see the attached patch. -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue8577] test_distutils fails if srcdir != builddir

Changes by Tarek Ziadé : -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/optio

[issue8577] test_distutils fails if srcdir != builddir

Tarek Ziadé added the comment: Ah, found a way: buildir = os.path.dirname(sys.executable) srcdir = os.path.abspath(os.path.join(buildir, get_config_var('srcdir'))) -- ___ Python tracker ___

[issue8577] test_distutils fails if srcdir != builddir

Tarek Ziadé added the comment: This won't work because in the build dir, srcdir is set to ".." in the Makefile located in the buildir, and the tests are run into a subdir : /build/test_python_xxx, so you can't rely on a relative path. For this to work we would need an absolute path for "srcd

[issue8577] test_distutils fails if srcdir != builddir

Ronald Oussoren added the comment: get_config_var('srcdir') should work, with should then be combined with the path to the Makefile, something like: os.path.join( os.path.dirname(os.path.abspath( _get_makefile_filename(), get_config_var('srcdir'))) The path.join is necessary because

[issue8577] test_distutils fails if srcdir != builddir

Tarek Ziadé added the comment: Mmm, the problem is that srcdir is given by the Makefile. So I need to find the Makefile. I don't know how to get these info from a python built in another directory. Investigating... -- ___ Python tracker

[issue8577] test_distutils fails if srcdir != builddir

Tarek Ziadé added the comment: distutils.sysconfig.get_python_inc() uses "os.path.dirname(os.path.abspath(sys.executable))" to find the srcdir. I'll change it to "sysconfig.get_config_var('srcdir')" -- ___ Python tracker

[issue8577] test_distutils fails if srcdir != builddir

New submission from Ronald Oussoren : When I build the trunk with srcdir != builddir test_distutils fails when running tests. To reproduce: * Create a checkout of the trunk and chdir into this * mkdir build * cd build * ../configure * make test This results in a failure for test_distutils ---