[issue8548] Building on CygWin 1.7: PATH_MAX redefined

Berker Peksag added the comment: Thank you for doing issue triage, Masayuki! -- nosy: +berker.peksag resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker __

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

Masayuki Yamamoto added the comment: This issue has been out-of-date since Python 3.4 maintenance became security status. -- ___ Python tracker ___

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

Masayuki Yamamoto added the comment: This issue resolved on default branch in #20597 . In 3.4 branch latest, PATH_MAX seems unused already in Modules/main.c:12 and Python/pythonrun.c:35. I want to cherry-pick #20597 to 3.4 branch. -- nosy: +masamoto ___

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

Roumen Petrov added the comment: Hi Mark, #else before is not solution. See unified diff below as post by Scott Rostrup lack definition Some additional information: a) move outside #ifdef HAVE_FCNTL_H : definition PATH_MAX is not related to control functions on open files (fcntl.h) b) HAVE_FC

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

Changes by Terry J. Reedy : -- nosy: -terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

Changes by Mark Lawrence : -- components: +Windows ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

Changes by Roumen Petrov : -- nosy: +rpetrov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

Mark Lawrence added the comment: main.c has this. #if defined(MS_WINDOWS) || defined(__CYGWIN__) #include #ifdef HAVE_FCNTL_H #include #define PATH_MAX MAXPATHLEN #endif #endif Wouldn't inserting #else before #define fix this issue? -- components: +Build -Installation, Windows nosy:

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

Nicholas DiPiazza added the comment: In Python3.1.2-src/Modules/main.c I actually had to use this to get it to work: #if defined(MS_WINDOWS) || defined(__CYGWIN__) #include #ifdef HAVE_FCNTL_H #include #endif #ifndef HAVE_FCNTL_H #define PATH_MAX MAXPATHLEN #endif #endif -- nosy: +N

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

Scott Rostrup added the comment: I just encountered this error in python 3.1.3 on cygwin 1.7. I used the same fix as jbinder. Old Modules/main.c (line 13): #if defined(MS_WINDOWS) || defined(__CYGWIN__) #include #ifdef HAVE_FCNTL_H #include #define PATH_MAX MAXPATHLEN #endif #e

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

Changes by Florent Xicluna : -- components: +Windows ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

Terry J. Reedy added the comment: None of the developers are much up on Cygwin and I am not sure it is directly supported by the core distribution. If it is not, this should be closed unless you have a specific patch. In any case, you might do better with your question on python-list. Also, P

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

New submission from Jeff Binder : Building Python 3.1.2 on Cygwin 1.7, I got errors in main.c stemming from a warning: PATH_MAX redefined (see attached log). I got around this by commenting out the #define. I don't know if the best solution is #ifndef, #undef, or something else. . . . I know