[issue8155] Incompatible change to test.test_support.check_warnings behaviour

Florent Xicluna added the comment: Fixed with r79049 and r79050. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed versions: +Python 3.2 ___ Python tracker __

[issue8155] Incompatible change to test.test_support.check_warnings behaviour

Nick Coghlan added the comment: Ah, I didn't notice that there were already tests for this in test_warnings (that's what I get for commenting late at night). Updated patch looks good. -- ___ Python tracker __

[issue8155] Incompatible change to test.test_support.check_warnings behaviour

Florent Xicluna added the comment: Patch updated. -- Added file: http://bugs.python.org/file16573/issue8155_check_warnings_quiet_v2.diff ___ Python tracker ___ _

[issue8155] Incompatible change to test.test_support.check_warnings behaviour

Changes by Florent Xicluna : Removed file: http://bugs.python.org/file16572/issue8155_check_warnings_quiet.diff ___ Python tracker ___ ___ Pyt

[issue8155] Incompatible change to test.test_support.check_warnings behaviour

Nick Coghlan added the comment: On a second look, there are a couple of things missing: - the default value didn't actually get changed! - we should add an explicit test that the no argument behaviour doesn't raise a warning by default Since we don't really have an existing test suite for the

[issue8155] Incompatible change to test.test_support.check_warnings behaviour

Florent Xicluna added the comment: I hesitate to do it differently: with check_warnings(('', RuntimeWarning)): ==> translate to check_warnings(('', RuntimeWarning), quiet=False) with check_warnings(): ==> translate to check_warnings(quiet=True) If the developer passes some arguments to the

[issue8155] Incompatible change to test.test_support.check_warnings behaviour

Nick Coghlan added the comment: On a quick read through, the patch looks fine to me. I actually agree it would be nice if we could keep the "quiet=True" default (since it is a better match for the feature set we want in our own tests), but I see the compatibility issue as a deal breaker for t

[issue8155] Incompatible change to test.test_support.check_warnings behaviour

Florent Xicluna added the comment: here come the patch. -- components: +Tests keywords: +easy, patch stage: test needed -> patch review versions: +Python 2.7 Added file: http://bugs.python.org/file16572/issue8155_check_warnings_quiet.diff ___ Python

[issue8155] Incompatible change to test.test_support.check_warnings behaviour

Changes by Eric Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue8155] Incompatible change to test.test_support.check_warnings behaviour

Changes by Nick Coghlan : -- title: Incompoatible change to test.test_support.check_warnings behaviour -> Incompatible change to test.test_support.check_warnings behaviour ___ Python tracker ___