[issue812369] module shutdown procedure based on GC

Changes by Antoine Pitrou : -- superseder: module shutdown procedure based on GC -> Stop purging modules which are garbage collected before shutdown ___ Python tracker ___

[issue812369] module shutdown procedure based on GC

Antoine Pitrou added the comment: Superceded by patch in issue 18214. -- resolution: -> duplicate status: open -> closed superseder: -> module shutdown procedure based on GC ___ Python tracker __

[issue812369] module shutdown procedure based on GC

Nick Coghlan added the comment: In addition to the problem Neil noted with references in extension modules keeping module objects themselves alive, Antoine recently noted that the other major challenge is the reference cycles between module global dictionaries and their contents. As soon as a

[issue812369] module shutdown procedure based on GC

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue812369] module shutdown procedure based on GC

Changes by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue812369] module shutdown procedure based on GC

Changes by Gregory P. Smith : -- assignee: gregory.p.smith -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue812369] module shutdown procedure based on GC

Neil Schemenauer added the comment: It's been quite a long time since I played with this patch so my memory might be a bit fuzzy. As I recall, it sounds good in theory but in practice it doesn't really work. One of the core problems is that many extension modules keep references to Python ob

[issue812369] module shutdown procedure based on GC

Martin v. Löwis added the comment: At the moment, it's like that the status of the patch needs to be reestablished. Does it apply? Does it work? Does the test suite still pass? -- ___ Python tracker _

[issue812369] module shutdown procedure based on GC

Stefan Friesel added the comment: What is the status of this? Does the patch need more reviewing? -- nosy: +Stefan.Friesel ___ Python tracker ___ ___

[issue812369] module shutdown procedure based on GC

Armin Rigo added the comment: Obviously we run atexit code too. There is no point in having atexit if it's not guaranteed to run in a normal shutdown. -- ___ Python tracker _

[issue812369] module shutdown procedure based on GC

Martin v. Löwis added the comment: > (This is just a report about PyPy's situation; I understand that the > situation in CPython is a bit more delicate if CPython is embedded in > a larger process.) I think that would indeed be unacceptable for Python - there is a long-standing expectation that

[issue812369] module shutdown procedure based on GC

Nick Coghlan added the comment: Also, since this issue was last updated, Antoine devised a scheme to test some of the embedding functionality (mainly to test subinterpreters, IIRC). Perhaps that could be harnessed to check GC-based shutdown is working correctly (it might even do it already, w

[issue812369] module shutdown procedure based on GC

Armin Rigo added the comment: Fwiw, the behavior in PyPy is: don't do anything particular at shut-down, just shut down and quit the process. No hacking at module globals to replace them with None, but also no guaranteeing that any __del__ method is ever called. We didn't get a particular bu

[issue812369] module shutdown procedure based on GC

Changes by Florent Xicluna : -- nosy: +flox ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue812369] module shutdown procedure based on GC

Nick Coghlan added the comment: In #14035, Florent pointed out the current behaviour potentially causes problems for some uses of import_fresh_modules() in the test suite (with globals sometimes being set to None if there's no indepenent reference to the module). GC based module cleanup woul

[issue812369] module shutdown procedure based on GC

Antoine Pitrou added the comment: The patch is obviously against 2.x (there are some PyString_Check's on module names, for example). It should be regenerated against 3.x. Also, it would be nice if a test could be devised to check that the shutdown procedure works as expected (I'm not sure how

[issue812369] module shutdown procedure based on GC

Gregory P. Smith added the comment: 0001-update-GC-shutdown-patch.patch looks sane to me at first glance. any other opinions? -- ___ Python tracker ___ __

[issue812369] module shutdown procedure based on GC

Mark Lawrence added the comment: #1545463 has been reopened with comments about being used as a stop gap. Possibly review and implementation of the patch here would be a better option, sorry it's over my head. -- versions: +Python 3.2 ___ Python t

[issue812369] module shutdown procedure based on GC

Changes by Andrea Corbellini : -- nosy: +candrea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue812369] module shutdown procedure based on GC

Mark Lawrence added the comment: issue1545463 has been closed as "won't fix", so wouldn't implementing this patch kill two birds with one stone? -- nosy: +BreamoreBoy ___ Python tracker _

[issue812369] module shutdown procedure based on GC

Changes by cburroughs : -- nosy: +cburroughs ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue812369] module shutdown procedure based on GC

Neil Schemenauer added the comment: It should fix issue1545463 and running a quick test seems to show that it does. -- ___ Python tracker ___ __

[issue812369] module shutdown procedure based on GC

Changes by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mai

[issue812369] module shutdown procedure based on GC

Alexander Belopolsky added the comment: Does this patch fix issue1545463 by any chance? I am away from a development box ATM and cannot test the patch myself. -- nosy: +belopolsky ___ Python tracker ___

[issue812369] module shutdown procedure based on GC

Antoine Pitrou added the comment: Retargetting, and I hope someone can take a look at the patch and give it the green light :-) -- stage: -> patch review type: -> behavior versions: +Python 2.7, Python 3.1 -Python 2.6, Python 3.0 ___ Python tracker

[issue812369] module shutdown procedure based on GC

Neil Schemenauer added the comment: This sounds like a nice idea. The current cleanup procedure in pythonrun.c is pretty lame since it can play havoc with __del__ methods (e.g. if they run after globals have been cleared). I've updated the patch to work with the current SVN head. Probably thi

[issue812369] module shutdown procedure based on GC

Antoine Pitrou added the comment: Looking at the patch, is there any reason it doesn't get rid of the current _PyModule_Clear() implementation to replace it by a call to PyDict_Clear() followed by PyGC_Collect()? (the call to PyGC_Collect could be disabled while finalizing, because there's no us

[issue812369] module shutdown procedure based on GC

Christian Heimes added the comment: Consider this patch for 2.6 and discuss it at the bug day. -- nosy: +tiran versions: +Python 2.6, Python 3.0 -Python 2.4 Tracker <[EMAIL PROTECTED]>