[issue7808] test_bsddb3 leaks references

Jesús Cea Avión added the comment: I have problem getting your changes working in python 3.x. Yes, pybsddb supports py3k. The problem is line "sys.exc_traceback = sys.last_traceback = None", that throws the following error under python 3.x: """ File "/home/pybsddb/build/lib.solaris-2.10-i86

[issue7808] test_bsddb3 leaks references

Jesús Cea Avión added the comment: Patch up-ported to pybsddb 4.8.4. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue7808] test_bsddb3 leaks references

Florent Xicluna added the comment: Jesús, your patch looks good. I prefer your approach. My use of the weakrefs was an ugly workaround, I admit. Maybe the "close()" method in the C module should be in charge of DECREFing the handlers and freeing memory. I did not look further in this direction

[issue7808] test_bsddb3 leaks references

Jesús Cea Avión added the comment: I have spend a few hours trying to understand the issue deeply, and I have an easier to understand version. It is bigger, but explain the issue good enough to use in a production program. Please, Florent, review. It pass the leak test. I rather prefer this

[issue7808] test_bsddb3 leaks references

Florent Xicluna added the comment: > I confirm the leaks in the C code. How do you find them? I've done it manually, disabling some tests, and running "regrtest -R" repeatedly until I isolate the function which is responsible. Then I studied the source code, looking for the missing DECREFs. -

[issue7808] test_bsddb3 leaks references

Ezio Melotti added the comment: You need a debug build of Python to use -R: ./configure --with-pydebug && make See also: http://www.python.org/dev/faq/#how-do-i-create-a-debug-build-of-python -- ___ Python tracker

[issue7808] test_bsddb3 leaks references

Florent Xicluna added the comment: The tool is called regrtest: ~ $ ./python -m test.regrtest -R 2:3: -uall test_bsddb3 Some devs and some buildbots hunt refleaks in the test suite. Even if the test-related refleaks are not important, they may hide real refleaks in the source code. -

[issue7808] test_bsddb3 leaks references

Jesús Cea Avión added the comment: I confirm the leaks in the C code. How do you find them? I see your point with the weakrefs in the unittest, but I don't see why they are so important. We are creating a GC cycle, yes, but the GC will collect it eventually, beside the reference counters bein

[issue7808] test_bsddb3 leaks references

Florent Xicluna added the comment: > Could you explain the changes to the unittest? The reference to "self" in the hooks were preventing the GC of the test case, as far as I understand, because it creates a cycle. When using weak references, there's no more dead cycles. It is my own explanatio

[issue7808] test_bsddb3 leaks references

Jesús Cea Avión added the comment: Florent, Could you explain the changes to the unittest?. I don't understand them. -- ___ Python tracker ___ __

[issue7808] test_bsddb3 leaks references

Changes by Florent Xicluna : -- type: performance -> resource usage ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue7808] test_bsddb3 leaks references

Changes by Florent Xicluna : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue7808] test_bsddb3 leaks references

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue7808] test_bsddb3 leaks references

Florent Xicluna added the comment: Patch updated for latest trunk. -- Added file: http://bugs.python.org/file16183/issue7808_bsddb3_refleak_v2.diff ___ Python tracker ___ ___

[issue7808] test_bsddb3 leaks references

Changes by Florent Xicluna : Removed file: http://bugs.python.org/file16039/issue7808_bsddb3_refleak.diff ___ Python tracker ___ ___ Python-bug

[issue7808] test_bsddb3 leaks references

Changes by Florent Xicluna : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue7808] test_bsddb3 leaks references

Changes by Florent Xicluna : -- components: Extension Modules nosy: flox priority: normal severity: normal status: open title: test_bsddb3 leaks references type: performance versions: Python 2.6, Python 2.7 ___ Python tracker

[issue7808] test_bsddb3 leaks references

New submission from Florent Xicluna : Patch proposed to fix the refleaks. -- keywords: +patch stage: -> patch review Added file: http://bugs.python.org/file16039/issue7808_bsddb3_refleak.diff ___ Python tracker ___