[issue7644] bug in nntplib.body() method with possible fix

2012-02-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thank you! Closing now. -- resolution: -> fixed stage: test needed -> committed/rejected status: open -> closed ___ Python tracker ___

[issue7644] bug in nntplib.body() method with possible fix

2012-02-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset f1401d20bc6d by Antoine Pitrou in branch '3.2': Issue #7644: Add tests for the file argument of NNTP.head() and NNTP.body(). http://hg.python.org/cpython/rev/f1401d20bc6d New changeset 096b31e0f8ea by Antoine Pitrou in branch 'default': Issue #7644

[issue7644] bug in nntplib.body() method with possible fix

2012-02-15 Thread Hynek Schlawack
Hynek Schlawack added the comment: I have also added a test for NTTP.head(), enjoy. -- keywords: +patch Added file: http://bugs.python.org/file24524/nntp-file-test.diff ___ Python tracker __

[issue7644] bug in nntplib.body() method with possible fix

2012-02-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: test_nntplib doesn't seem to exercise the second argument to body() (the file object). Perhaps you want to add a test for that? -- nosy: +pitrou ___ Python tracker ___

[issue7644] bug in nntplib.body() method with possible fix

2012-02-13 Thread Hynek Schlawack
Hynek Schlawack added the comment: Looking into the source code of nntplib, I'd claim this bug isn't valid anymore? At least the file is opened in binary mode now – see Lib/nntplib.py:462 In any case, we have a test suite now. -- nosy: +hynek versions: +Python 3.3 -Python 3.1 ___

[issue7644] bug in nntplib.body() method with possible fix

2010-01-07 Thread R. David Murray
R. David Murray added the comment: Yes, it should be another issue. That said, there are similar (worse, actually) problems with the py3 email package that we are moving toward addressing. There we are planning to have dual APIs. If you want to work on fixing nntplib similarly, that would

[issue7644] bug in nntplib.body() method with possible fix

2010-01-06 Thread Michael Mullins
Michael Mullins added the comment: "('crash' is for the interpreter crashing)" Sorry. "Unless someone feels like creating an nntp test framework..." This sounds like it is beyond me. But given the evidence, specifically the previous line: "file.write(line + b'\n')" ...the module

[issue7644] bug in nntplib.body() method with possible fix

2010-01-06 Thread R. David Murray
R. David Murray added the comment: ('crash' is for the interpreter crashing) Unfortunately there currently are no unit tests for nntplib. Unless someone feels like creating an nntp test framework we may have to commit this fix without a test. -- keywords: +easy nosy: +r.david.murray

[issue7644] bug in nntplib.body() method with possible fix

2010-01-06 Thread Michael Mullins
Changes by Michael Mullins : -- components: +Library (Lib) type: -> crash ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue7644] bug in nntplib.body() method with possible fix

2010-01-06 Thread Michael Mullins
New submission from Michael Mullins : When using NNTP.body(id,file) I get the following repeatable error: Traceback (most recent call last): File "", line 1, in File "nntplib.py", line 436, in body return self.artcmd('BODY {0}'.format(id), file) File "nntplib.py", line 410, in artcmd