[issue7532] Extended slicing with classic class behaves strangely

Mark Dickinson added the comment: Thanks! Applied in r77408. -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list ma

[issue7532] Extended slicing with classic class behaves strangely

Changes by Florent Xicluna : Added file: http://bugs.python.org/file15804/issue7532_wontfix_tests_py3k.diff ___ Python tracker ___ ___ Python-b

[issue7532] Extended slicing with classic class behaves strangely

Changes by Florent Xicluna : Removed file: http://bugs.python.org/file15801/issue7532_wontfix_tests_py3k.diff ___ Python tracker ___ ___ Python

[issue7532] Extended slicing with classic class behaves strangely

Changes by Florent Xicluna : Added file: http://bugs.python.org/file15802/issue7532_bytearray.diff ___ Python tracker ___ ___ Python-bugs-list

[issue7532] Extended slicing with classic class behaves strangely

Florent Xicluna added the comment: Here it is, with some cleaning and simple Bytes/Bytearray tests. And Bytearray tests backported to 2.7. -- Added file: http://bugs.python.org/file15801/issue7532_wontfix_tests_py3k.diff ___ Python tracker

[issue7532] Extended slicing with classic class behaves strangely

Mark Dickinson added the comment: Tests applied to trunk in r77391. Are you interested in producing a py3k version of the patch? -- ___ Python tracker ___ _

[issue7532] Extended slicing with classic class behaves strangely

Mark Dickinson added the comment: Okay, sounds reasonable. Reopening to consider tests. -- assignee: -> mark.dickinson status: closed -> open ___ Python tracker ___ ___

[issue7532] Extended slicing with classic class behaves strangely

Florent Xicluna added the comment: I would suggest to keep the tests, even if the bug is closed. -- Added file: http://bugs.python.org/file15779/issue7532_wontfix_tests.diff ___ Python tracker _

[issue7532] Extended slicing with classic class behaves strangely

Mark Dickinson added the comment: Closing as won't fix. -- resolution: -> wont fix status: open -> closed ___ Python tracker ___ ___

[issue7532] Extended slicing with classic class behaves strangely

Mark Dickinson added the comment: Interesting solution! While the patch itself looks fine to me, I'm not sure I like this solution much. It's fine to use this trick for list or tuple, but implementing it for all old-style classes at once seems a bit dangerous. With this patch, it seems to

[issue7532] Extended slicing with classic class behaves strangely

Changes by flox : Removed file: http://bugs.python.org/file15585/issue7532_classic_getitem.diff ___ Python tracker ___ ___ Python-bugs-list mai

[issue7532] Extended slicing with classic class behaves strangely

flox added the comment: Patch augmented with extensive tests: * Classic class or New-style class * with or without __getslice__ -- Added file: http://bugs.python.org/file15586/issue7532_classic_getitem_v2.diff ___ Python tracker

[issue7532] Extended slicing with classic class behaves strangely

flox added the comment: Mark, Thank you for your analysis. I looked at similar implementation of tp_as_sequence->sq_slice slots in "stringobject.c" (and tuple, list). I've added extra controls before the _PySlice_FromIndices call to let it behave like new-style classes. I have updated the tes

[issue7532] Extended slicing with classic class behaves strangely

Mark Dickinson added the comment: Issue #974635 looks like the same thing. That issue was closed as a duplicate of issue #723806, though to my eyes #723806 doesn't look quite the same. -- ___ Python tracker

[issue7532] Extended slicing with classic class behaves strangely

Mark Dickinson added the comment: Hmm. This doesn't look like something that's easy to fix without affecting existing correct code; given that the behaviour has been around for a while (I'm not sure exactly how long), and that the issue is gone in 3.x, I suspect it may not be worth trying.

[issue7532] Extended slicing with classic class behaves strangely

New submission from flox : See attached example. The Classic class should behave like the New-style class. -- components: Interpreter Core files: case_slice.py messages: 96520 nosy: flox severity: normal status: open title: Extended slicing with classic class behaves strangely type: beh