[issue7385] MemoryView_FromObject crashes if PyBuffer_GetBuffer fails

2010-02-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: Merged in r77918 (py3k) and r77920 (3.1). -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker _

[issue7385] MemoryView_FromObject crashes if PyBuffer_GetBuffer fails

2010-02-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: I've added a missing call to PyBuffer_Release() and committed the patch to trunk (r77916). -- ___ Python tracker ___ __

[issue7385] MemoryView_FromObject crashes if PyBuffer_GetBuffer fails

2010-02-02 Thread Florent Xicluna
Florent Xicluna added the comment: Thanks. -- Added file: http://bugs.python.org/file16112/issue7385_memoryview_v2.diff ___ Python tracker ___ ___

[issue7385] MemoryView_FromObject crashes if PyBuffer_GetBuffer fails

2010-02-02 Thread Florent Xicluna
Changes by Florent Xicluna : Removed file: http://bugs.python.org/file16060/issue7385_memoryview.diff ___ Python tracker ___ ___ Python-bugs-li

[issue7385] MemoryView_FromObject crashes if PyBuffer_GetBuffer fails

2010-02-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: When PyMemoryView_FromObject() doesn't return NULL, you should decref the result. Otherwise, it's "perfect". -- ___ Python tracker ___

[issue7385] MemoryView_FromObject crashes if PyBuffer_GetBuffer fails

2010-01-30 Thread Florent Xicluna
Florent Xicluna added the comment: Removed /* XXX */ code -- Added file: http://bugs.python.org/file16060/issue7385_memoryview.diff ___ Python tracker ___ ___

[issue7385] MemoryView_FromObject crashes if PyBuffer_GetBuffer fails

2010-01-30 Thread Florent Xicluna
Changes by Florent Xicluna : Removed file: http://bugs.python.org/file16058/issue7385_memoryview.diff ___ Python tracker ___ ___ Python-bugs-li

[issue7385] MemoryView_FromObject crashes if PyBuffer_GetBuffer fails

2010-01-30 Thread Florent Xicluna
Florent Xicluna added the comment: Proposed test and fix. Please comment, there's probably room for improvement. -- keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file16058/issue7385_memoryview.diff ___ Python

[issue7385] MemoryView_FromObject crashes if PyBuffer_GetBuffer fails

2010-01-13 Thread Florent Xicluna
Changes by Florent Xicluna : -- nosy: +flox ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue7385] MemoryView_FromObject crashes if PyBuffer_GetBuffer fails

2009-12-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: Nice catch. I wonder whether there's a simple way of cooking up an unit test for this (short of creating a new extension type). -- assignee: -> pitrou nosy: +pitrou priority: -> high stage: -> needs patch versions: +Python 2.7, Python 3.2 __

[issue7385] MemoryView_FromObject crashes if PyBuffer_GetBuffer fails

2009-12-03 Thread Pauli Virtanen
Changes by Pauli Virtanen : -- type: -> crash ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue7385] MemoryView_FromObject crashes if PyBuffer_GetBuffer fails

2009-11-23 Thread Pauli Virtanen
New submission from Pauli Virtanen : In Objects/memoryobject.c:PyMemoryView_FromObject there's a _PyObject_GC_UNTRACK unpaired with corresponding _PyObject_GC_TRACK, which seems to cause a segmentation fault. This can be triggered by calling PyMemoryView_FromObject on an object whose bf_getbuffer