[issue7165] xmlrpc.server assumes sys.stdout will have a buffer attribute

Changes by Martin v. Löwis : -- stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___ ___ Python-bugs-

[issue7165] xmlrpc.server assumes sys.stdout will have a buffer attribute

STINNER Victor added the comment: antoine's patch (fixing this issue) is commited. Can we close this issue? -- nosy: +haypo ___ Python tracker ___ ___

[issue7165] xmlrpc.server assumes sys.stdout will have a buffer attribute

Antoine Pitrou added the comment: > Assigning back to myself to add a comment to the relevant line (i.e. > that relying on the buffer attribute being present is a deliberate > design choice). The remaining question, however, is why it doesn't also rely on stdin.buffer. --

[issue7165] xmlrpc.server assumes sys.stdout will have a buffer attribute

Nick Coghlan added the comment: Fine by me (I was very close to changing the test when I first triggered the problem, but wasn't sure silencing the error was the right thing to do). Assigning back to myself to add a comment to the relevant line (i.e. that relying on the buffer attribute being p

[issue7165] xmlrpc.server assumes sys.stdout will have a buffer attribute

R. David Murray added the comment: Patch applied in r75710. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue7165] xmlrpc.server assumes sys.stdout will have a buffer attribute

Martin v. Löwis added the comment: I agree with Antoine that CGIXML... is right in accessing sys.stdout.buffer; this really needs binary IO. Consequentially, his patch also looks right to me; please apply. -- assignee: -> pitrou resolution: -> accepted __

[issue7165] xmlrpc.server assumes sys.stdout will have a buffer attribute

R. David Murray added the comment: I think Antoine's suggestion is reasonable, and that we should apply the patch to stop the buildbots from failing, but leave this issue open until someone with more xmlrpc knowledge can respond to Nick and Antoine's questions. -- nosy: +r.david.murray

[issue7165] xmlrpc.server assumes sys.stdout will have a buffer attribute

Antoine Pitrou added the comment: Well this is in the CGI implementation, and it's reasonable to assume that CGI will only be used with a real stream. Besides, the encoding used with stdout must be the xmlrpc encoding (probably utf-8), not the default encoding of standard streams on the system,

[issue7165] xmlrpc.server assumes sys.stdout will have a buffer attribute

New submission from Nick Coghlan : The xmlrpc tests were changed to use a StringIO object instead of a temporary file (this change reflects the corresponding change made on the 2.x trunk). The tests then started failing, since xmlrpc.server assumes sys.stdout will provide the buffer attribute, w