[issue6978] compiler.transformer dict key bug d[1,] = 1

Terry J. Reedy added the comment: I am closing this because a) Meador is correct that we do not normally patch deprecated features and b) the current emphasis on 2.7-only patches is security and keeping 2.7 working on current systems. The fix would only benefit 2.7.9+ code or 2.7.9+ and 3.x c

[issue6978] compiler.transformer dict key bug d[1,] = 1

Mark Lawrence added the comment: Can somebody set this to "patch review" and do the honours please. FWIW I don't like "tulplesub" in the patch. -- nosy: +BreamoreBoy ___ Python tracker

[issue6978] compiler.transformer dict key bug d[1,] = 1

Kees Bos added the comment: Added fix for python 2.7, which includes a test (testDictWithTupleKey) for the compiler test (Lib/test/test_compiler.py). -- status: pending -> open Added file: http://bugs.python.org/file18642/compiler-bug-issue6978.patch __

[issue6978] compiler.transformer dict key bug d[1,] = 1

Terry J. Reedy added the comment: This can only be fixed in 2.7, where compiler is deprecated in favor of ast. Compiler is gone in 3.x. Kees, are you planning to update the patch (with no guarantee anyone will apply) or should we close this? -- nosy: +tjreedy status: open -> pending v

[issue6978] compiler.transformer dict key bug d[1,] = 1

Changes by Terry J. Reedy : Removed file: http://bugs.python.org/file14958/compiler.transformer.patch ___ Python tracker ___ ___ Python-bugs-li

[issue6978] compiler.transformer dict key bug d[1,] = 1

Benjamin Peterson added the comment: As I said before, the patch needs a test and should remove those ugly \ from the list comprehension. -- ___ Python tracker ___ _

[issue6978] compiler.transformer dict key bug d[1,] = 1

Kees Bos added the comment: It's available at least since 2.4. We're using it in Pyjamas (pyjs.org) to generate javascript code from python code. If there are better ways to produce python asts, I'd be happy to know that. -- ___ Python tracker

[issue6978] compiler.transformer dict key bug d[1,] = 1

Chuck Rhode added the comment: > I don't see why the compiler module is any better than any of the other > ways that produce reasonable AST. It is available on Python releases older than 2.6? -- ___ Python tracker

[issue6978] compiler.transformer dict key bug d[1,] = 1

Benjamin Peterson added the comment: I don't see why the compiler module is any better than any of the other ways that produce reasonable AST. -- ___ Python tracker ___

[issue6978] compiler.transformer dict key bug d[1,] = 1

Chuck Rhode added the comment: Here are four ways to generate things called in the documentation Abstract Syntax Trees (ASTs). Obviously they are not all the same kind of object: #!/usr/local/bin/python2.6 import sys import compiler import parser import ast STATEMENT = 'd[1,] = 2' print 'l

[issue6978] compiler.transformer dict key bug d[1,] = 1

Meador Inge added the comment: I think this should be closed out, since the compiler package was deprecated in 2.6. -- nosy: +minge ___ Python tracker ___ __

[issue6978] compiler.transformer dict key bug d[1,] = 1

Benjamin Peterson added the comment: The patch should have a test. -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-

[issue6978] compiler.transformer dict key bug d[1,] = 1

Chuck Rhode added the comment: PythonTidy encounters this problem. o http://lacusveris.com/PythonTidy/PythonTidy.python It is unable correctly to render line 694 of test_grammar.py in the Python Test Suite: d[1,] = 2 becomes: d[1] = 2 because the *compiler* module does not return a

[issue6978] compiler.transformer dict key bug d[1,] = 1

Kees Bos added the comment: Sorry. Renamed .bak to .orig ... Here's the patch compiler/transformer.py (against python 2.5) -- Added file: http://bugs.python.org/file15068/transformer.py.patch ___ Python tracker ___

[issue6978] compiler.transformer dict key bug d[1,] = 1

Amaury Forgeot d'Arc added the comment: your patch is no more a diff file (the 'previous' file is empty) -- nosy: +amaury.forgeotdarc ___ Python tracker ___ _

[issue6978] compiler.transformer dict key bug d[1,] = 1

Changes by Kees Bos : Removed file: http://bugs.python.org/file14957/compiler.transformer.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue6978] compiler.transformer dict key bug d[1,] = 1

Kees Bos added the comment: patch which honors O[1:2:3, 4:5:6] -- Added file: http://bugs.python.org/file14958/compiler.transformer.patch ___ Python tracker ___ _

[issue6978] compiler.transformer dict key bug d[1,] = 1

Kees Bos added the comment: I just see that my patch is not correct, since the following is supported by the language: O[1:2:3, 4:5:6] Where O[1:2:3, 4:5:6] == O[slice(1,2,3), slice(4,5,6)] == O.__getitem__((slice(1,2,3), slice(4,5,6))) -- ___ Pyth

[issue6978] compiler.transformer dict key bug d[1,] = 1

New submission from Kees Bos : compiler.parse("d[1] = 1") should have a single tuple as subs >>> compiler.parse("d[1] = 1") Module(None, Stmt([Assign([Subscript(Name('d'), 'OP_ASSIGN', [Const(1)])], Const(1))])) >>> compiler.parse("d[1,] = 2") Module(None, Stmt([Assign([Subscript(Name('d'), 'OP