[issue5800] make wsgiref.headers.Headers accept empty constructor

2014-07-01 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch and review. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ _

[issue5800] make wsgiref.headers.Headers accept empty constructor

2014-07-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset a91f0d4a2381 by Berker Peksag in branch 'default': Issue #5800: headers parameter of wsgiref.headers.Headers is now optional. http://hg.python.org/cpython/rev/a91f0d4a2381 -- nosy: +python-dev ___ Python

[issue5800] make wsgiref.headers.Headers accept empty constructor

2014-07-01 Thread R. David Murray
R. David Murray added the comment: Since we don't need to avoid new language features, using the ternary would be better than using the or. This is exactly the sort of situation the ternary was introduced for: making sure the input really is None before applying the default. Otherwise the pa

[issue5800] make wsgiref.headers.Headers accept empty constructor

2014-07-01 Thread Berker Peksag
Berker Peksag added the comment: Patch updated. If there's no objections, I'll commit this patch in the next couple of days. -- assignee: pje -> berker.peksag stage: patch review -> commit review Added file: http://bugs.python.org/file35814/issue5800_v3.diff ___

[issue5800] make wsgiref.headers.Headers accept empty constructor

2014-06-26 Thread Berker Peksag
Berker Peksag added the comment: Here's a new patch with a whatsnew entry. David, could you review the patch? -- nosy: +r.david.murray Added file: http://bugs.python.org/file35787/issue5800_v2.diff ___ Python tracker

[issue5800] make wsgiref.headers.Headers accept empty constructor

2014-06-22 Thread Mark Lawrence
Mark Lawrence added the comment: Just for the record clicking on "revision 86742" gives "Specified revision r86742 not found". -- ___ Python tracker ___ _

[issue5800] make wsgiref.headers.Headers accept empty constructor

2014-06-22 Thread Berker Peksag
Berker Peksag added the comment: The patch is not committed yet. $ ./python Python 3.5.0a0 (default:979aaa08c067+, Jun 19 2014, 13:01:36) [GCC 4.6.3] on linux Type "help", "copyright", "credits" or "license" for more information. >>> from wsgiref.headers import Headers >>> h = Headers() Traceba

[issue5800] make wsgiref.headers.Headers accept empty constructor

2014-06-22 Thread Mark Lawrence
Mark Lawrence added the comment: This shouldn't be languishing, work has been committed against revision 86742 and there's another patch that apparently just needs a little tweak. -- nosy: +BreamoreBoy ___ Python tracker

[issue5800] make wsgiref.headers.Headers accept empty constructor

2011-03-20 Thread Éric Araujo
Éric Araujo added the comment: I think the doc should say something like “default value is an empty list”, for maximum clarity. -- versions: +Python 3.3 -Python 3.2 ___ Python tracker _

[issue5800] make wsgiref.headers.Headers accept empty constructor

2011-03-13 Thread SilentGhost
SilentGhost added the comment: > Looks good to me. Would you mind committing it then? -- ___ Python tracker ___ ___ Python-bugs-list m

[issue5800] make wsgiref.headers.Headers accept empty constructor

2011-03-06 Thread Phillip J. Eby
Phillip J. Eby added the comment: Looks good to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue5800] make wsgiref.headers.Headers accept empty constructor

2011-03-06 Thread SilentGhost
Changes by SilentGhost : Removed file: http://bugs.python.org/file19804/wsgiref.rst.diff ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue5800] make wsgiref.headers.Headers accept empty constructor

2011-03-06 Thread SilentGhost
Changes by SilentGhost : Removed file: http://bugs.python.org/file19797/headers.py.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue5800] make wsgiref.headers.Headers accept empty constructor

2011-03-06 Thread SilentGhost
Changes by SilentGhost : Removed file: http://bugs.python.org/file19681/test_wsgiref.py.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue5800] make wsgiref.headers.Headers accept empty constructor

2011-03-06 Thread SilentGhost
SilentGhost added the comment: Here's the single-file patch against the revision. -- Added file: http://bugs.python.org/file21016/issue5800.diff ___ Python tracker ___ __

[issue5800] make wsgiref.headers.Headers accept empty constructor

2011-01-15 Thread SilentGhost
Changes by SilentGhost : -- status: open -> languishing ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue5800] make wsgiref.headers.Headers accept empty constructor

2010-11-25 Thread Éric Araujo
Éric Araujo added the comment: LGTM. -- assignee: -> pje ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue5800] make wsgiref.headers.Headers accept empty constructor

2010-11-24 Thread Ramiro Batista da Luz
Ramiro Batista da Luz added the comment: I reviewed the patch. - I applied all the patchs(3 files). - Ran make and make html in the Doc directory. - Ran the test_wsgiref.py - Ran the python interpreter and typed the suggested code: >>> from wsgiref.headers import Headers >>> headers = Head

[issue5800] make wsgiref.headers.Headers accept empty constructor

2010-11-24 Thread SilentGhost
SilentGhost added the comment: Here is the correction for the docs. I would love to see this making it into 3.2 release. -- Added file: http://bugs.python.org/file19804/wsgiref.rst.diff ___ Python tracker

[issue5800] make wsgiref.headers.Headers accept empty constructor

2010-11-24 Thread Dirkjan Ochtman
Changes by Dirkjan Ochtman : -- keywords: +needs review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue5800] make wsgiref.headers.Headers accept empty constructor

2010-11-24 Thread SilentGhost
SilentGhost added the comment: Re-submitting the patch for Lib/wsgiref/headers.py w/o the isinstance change -- keywords: +patch Added file: http://bugs.python.org/file19797/headers.py.diff ___ Python tracker __

[issue5800] make wsgiref.headers.Headers accept empty constructor

2010-11-24 Thread SilentGhost
Changes by SilentGhost : Removed file: http://bugs.python.org/file19680/headers.py.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue5800] make wsgiref.headers.Headers accept empty constructor

2010-11-21 Thread SilentGhost
SilentGhost added the comment: Do I have to resubmit the patch or can you use the existing one? -- ___ Python tracker ___ ___ Python-b

[issue5800] make wsgiref.headers.Headers accept empty constructor

2010-11-21 Thread Phillip J. Eby
Phillip J. Eby added the comment: Yes, please consider the type->isinstance part of the change rejected. I just got done reverting a bunch of those in 3.2. Where WSGI specifies types, it means "type() is", not "isinstance". (The 3.x version of wsgiref does not need to be executable on 2.x v

[issue5800] make wsgiref.headers.Headers accept empty constructor

2010-11-20 Thread Éric Araujo
Éric Araujo added the comment: FTR, note that “svn diff file1 file2...” will give you one file for many edits. It’s easier to review and apply. Regarding the change, I don’t know if wsgiref 3.2 has to be compatible with Python 2.1, which would exclude using the ternary operation. The change

[issue5800] make wsgiref.headers.Headers accept empty constructor

2010-11-20 Thread Ramiro Batista da Luz
Ramiro Batista da Luz added the comment: I applied the patches for wsgiref.headers and test_headers.py, ran the test with runtests.sh test_headers.py and it passed. I also tried the code in the description: >>> from wsgiref.headers import Headers >>> headers = Headers() >>> headers.add_heade

[issue5800] make wsgiref.headers.Headers accept empty constructor

2010-11-20 Thread R. David Murray
Changes by R. David Murray : -- keywords: -patch stage: unit test needed -> patch review versions: -Python 2.7 ___ Python tracker ___ ___

[issue5800] make wsgiref.headers.Headers accept empty constructor

2010-11-20 Thread SilentGhost
SilentGhost added the comment: here is the updated test case -- Added file: http://bugs.python.org/file19681/test_wsgiref.py.diff ___ Python tracker ___ _

[issue5800] make wsgiref.headers.Headers accept empty constructor

2010-11-20 Thread SilentGhost
SilentGhost added the comment: Correct and update patch + update test case -- keywords: +patch nosy: +SilentGhost Added file: http://bugs.python.org/file19680/headers.py.diff ___ Python tracker

[issue5800] make wsgiref.headers.Headers accept empty constructor

2009-06-17 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: Added a pointer from #5801 to here. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue5800] make wsgiref.headers.Headers accept empty constructor

2009-06-17 Thread Tarek Ziadé
Tarek Ziadé added the comment: I have added another issue for PEP 8 compliancy at #5801 -- versions: +Python 3.2 -Python 3.1 ___ Python tracker ___ __

[issue5800] make wsgiref.headers.Headers accept empty constructor

2009-06-17 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: Patch attached. While I was at it, I also removed stupid whitespace and generally made the module more PEP8-compliant. -- nosy: +ptn Added file: http://bugs.python.org/file14311/patch ___ Python tracker

[issue5800] make wsgiref.headers.Headers accept empty constructor

2009-04-21 Thread Daniel Diniz
Changes by Daniel Diniz : -- keywords: +easy stage: -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue5800] make wsgiref.headers.Headers accept empty constructor

2009-04-20 Thread Tarek Ziadé
New submission from Tarek Ziadé : wsgiref.headers.Headers will let you manage a collection of HTTP response headers, but the constructor forces you to provide a list: >>> from wsgiref.headers import Headers >>> headers = Headers([]) >>> headers.add_header('Content-Type', 'text/plain') A l