[issue5499] only accept byte for getarg('c') and unicode for getarg('C')

STINNER Victor added the comment: Ooops, I read converterr("a unicode character", ...), but it should be converterr("an unicode character", ...) ;-) Thanks benjamin.peterson, it will help other issues like #5391 and #5410. -- ___ Python tracker <

[issue5499] only accept byte for getarg('c') and unicode for getarg('C')

Benjamin Peterson added the comment: Fixed in r71013. -- nosy: +benjamin.peterson resolution: -> accepted status: open -> closed ___ Python tracker ___ _

[issue5499] only accept byte for getarg('c') and unicode for getarg('C')

Gregory P. Smith added the comment: good catch. the patch looks correct to me. -- nosy: +gregory.p.smith ___ Python tracker ___ ___ P

[issue5499] only accept byte for getarg('c') and unicode for getarg('C')

Hirokazu Yamamoto added the comment: Note: #5391 and #5410 are depends on this issue. -- ___ Python tracker ___ ___ Python-bugs-list m

[issue5499] only accept byte for getarg('c') and unicode for getarg('C')

Changes by Hirokazu Yamamoto : -- priority: -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5499] only accept byte for getarg('c') and unicode for getarg('C')

Changes by Hirokazu Yamamoto : -- nosy: +ocean-city ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue5499] only accept byte for getarg('c') and unicode for getarg('C')

STINNER Victor added the comment: unicode methods center(), ljust(), rjust() use a callback (convert_uc) to get an unicode character (unicode string of 1 character). If 'C' is fixed, convert_uc() callback can be removed. -- ___ Python tracker

[issue5499] only accept byte for getarg('c') and unicode for getarg('C')

New submission from STINNER Victor : To avoid byte/character mixture, getarg('c') must only accept a byte string of 1 byte and getarg('C') only an unicode string of 1 character. Impacted methods: - datetime.datetime.isoformat(sep), array.array(type, data): don't accept byte anymore - msvcrt.p