[issue5485] pyexpat has no unit tests for UseForeignDTD functionality

Antoine Pitrou added the comment: Ok, I've changed "assertEquals" to "assertEqual" and committed the tests in r87765. Thank you! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed versions: +Python 3.2 -Python 3.3

[issue5485] pyexpat has no unit tests for UseForeignDTD functionality

Antoine Pitrou added the comment: Doc patch committed in r87762. -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing

[issue5485] pyexpat has no unit tests for UseForeignDTD functionality

Sandro Tosi added the comment: Ok, I've changed the version field and refreshed the patch against py3k. -- versions: +Python 3.3 -Python 2.7 Added file: http://bugs.python.org/file20276/issue5485-py3k.patch ___ Python tracker

[issue5485] pyexpat has no unit tests for UseForeignDTD functionality

Martin v. Löwis added the comment: I don't think we should adding tests to 2.7, perhaps unless there are also fixes for it. So targetting 3.3+ only seems reasonable. -- ___ Python tracker _

[issue5485] pyexpat has no unit tests for UseForeignDTD functionality

Sandro Tosi added the comment: Hi all, I think this patch would be nice to be applied, but before start working on it (like adapt it to new code & stuff), I'd like to know if we are really targetting 2.7 or should we instead targer 3.3. Cheers, Sandro -- nosy: +sandro.tosi stage: ->

[issue5485] pyexpat has no unit tests for UseForeignDTD functionality

Jean-Paul Calderone added the comment: Here's a new patch which adds SetParamEntityParsing to the pyexpat library docs and adds another test for external entity reference handling. This is probably all I'll do on this ticket. -- Added file: http://bugs.python.org/file14024/pyexpat.patc

[issue5485] pyexpat has no unit tests for UseForeignDTD functionality

Jean-Paul Calderone added the comment: To clarify, I'll probably work on this patch a bit more later, adding a few more tests for related behavior. -- ___ Python tracker ___

[issue5485] pyexpat has no unit tests for UseForeignDTD functionality

Jean-Paul Calderone added the comment: Here's the version I have now. I don't think it's complete, but it finishes the test started in the previous patch, and the test passes. -- Added file: http://bugs.python.org/file13323/use-foreign-dtd.2.patch _

[issue5485] pyexpat has no unit tests for UseForeignDTD functionality

Martin v. Löwis added the comment: Can you provide an update patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue5485] pyexpat has no unit tests for UseForeignDTD functionality

Jean-Paul Calderone added the comment: Thanks, that helped a bunch. I'm sure it would have taken me a long time to find SetParamEntityParsing(XML_PARAM_ENTITY_PARSING_ALWAYS). Perhaps it would also be good to expand the pyexpat documentation to cover that method and parameter (unless it's ther

[issue5485] pyexpat has no unit tests for UseForeignDTD functionality

Martin v. Löwis added the comment: You need to make two changes: 1. Enable parsing of parameter entities in the first place, e.g. through SetParamEntityParsing(XML_PARAM_ENTITY_PARSING_ALWAYS) 2. Pass a well-formed document, e.g. "" -- nosy: +loewis

[issue5485] pyexpat has no unit tests for UseForeignDTD functionality

New submission from Jean-Paul Calderone : Lacking unit tests for this (documented) functionality makes it harder for alternate Python runtimes to correctly provide it. Plus, if it's not tested, it might not work. I tried to write tests for the feature since I recently used it and thought it wou