[issue5430] imaplib: must not replace LF or CR by CRLF in literals

Change by Irit Katriel : -- versions: +Python 3.10, Python 3.8, Python 3.9 -Python 2.6, Python 2.7 ___ Python tracker ___ ___ Python-

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

Julien Palard added the comment: It looks like a revert of 47404f3e36699786082d0ee6565872d627e1 Which is the fix for https://bugs.python.org/issue723962 which I'm currently reading. -- nosy: +mdk ___ Python tracker

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

Change by Natal Ngétal : -- pull_requests: +10141 stage: test needed -> patch review ___ Python tracker ___ ___ Python-bugs-list maili

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

Cheryl Sabella added the comment: I'm not sure if this is a 2.6/2.7 only issue because the code mentioned in msg86572 still exists, although with a change for #21800 (RFC 6855/UTF-8) applied. For reference, #25591 expanded the test coverage for the imaplib. However, I don't see any tests re

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

Matej Cepl added the comment: Oh, this is 2.6 bug. This should be closed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

Matej Cepl added the comment: > Module imaplib has pretty sparse test code. On that note: would anybody be willing to express in form of (simplified) test case, what's the problem reported here? I am not sure, I follow. -- ___ Python tracker

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

Change by Matej Cepl : -- nosy: +mcepl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

Changes by R. David Murray : -- components: +email nosy: +barry, r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

Rajesh S R added the comment: Am quite new here; just searching hard to contribute, would like to patch this, if I can go ahead. Don't we need to patch the original imaplib code also? just remove the line: self.literal = MapCRLF.sub(CRLF, message) and have: self.literal = message Or am I missi

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

Ron DuPlain added the comment: Module imaplib has pretty sparse test code. There is only 1 test case, for imaplib.Time2Internaldate. trunk/Lib/test/test_imaplib.py The attached patch tests for LF, CR preservation with regard to the IMAP4.append method, but more testing is necessary to make sur

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

Ron DuPlain added the comment: It looks like the IMAP4.append method is responsible for the CRLF substitution (trunk/Lib/imaplib.py). # defined near top of module: MapCRLF = re.compile(r'\r\n|\r|\n') # in append method: self.literal = MapCRLF.sub(CRLF, message) I'll work on a test for it this

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

Changes by Daniel Diniz : -- keywords: +easy stage: -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

Changes by Memeplex : -- title: Must not replace LF or CR by CRLF in literals -> imaplib: must not replace LF or CR by CRLF in literals ___ Python tracker ___ ___