[issue5424] Packed IPaddr conversion tests should be extended

2011-12-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: I have finally committed the patch. Thank you! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue5424] Packed IPaddr conversion tests should be extended

2011-12-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 71e5a083f9b1 by Antoine Pitrou in branch '3.2': Issue #5424: add tests for inet_ntoa, inet_ntop, inet_aton and inet_pton. http://hg.python.org/cpython/rev/71e5a083f9b1 New changeset a3d5f522065f by Antoine Pitrou in branch 'default': Issue #5424: a

[issue5424] Packed IPaddr conversion tests should be extended

2011-12-16 Thread Martin v . Löwis
Martin v. Löwis added the comment: I agree with Antoine: a single test testing that we actually raise exceptions properly should be sufficient. OTOH, the patch doesn't hurt (AFAICT), so I wouldn't mind if it was applied as-is. -- ___ Python tracke

[issue5424] Packed IPaddr conversion tests should be extended

2011-12-16 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +neologix ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue5424] Packed IPaddr conversion tests should be extended

2011-01-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: I'm not sure what the point of this patch is, since it's basically testing operating system behaviour, rather than Python behaviour. I think that we could have a single additional test case for bad inputs and leave it at that. But in any case, here's the origi

[issue5424] Packed IPaddr conversion tests should be extended

2011-01-03 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +exarkun, loewis, pitrou -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue5424] Packed IPaddr conversion tests should be extended

2010-07-09 Thread Mark Lawrence
Mark Lawrence added the comment: Adding tests into test_socket.py for invalid input can't be wrong can it? Patch seems clean but would someone cast a more experienced Mk1 eyeball over it please. -- nosy: +BreamoreBoy stage: -> patch review versions: +Python 3.2 -Python 2.7, Python 3

[issue5424] Packed IPaddr conversion tests should be extended

2009-03-05 Thread Philipp Hagemeister
New submission from Philipp Hagemeister : Currently, the testStringToIPv6 and testIPv6ToStrings tests in Lib/test/test_socket.py only check for variants 1 and 2 (but not 3) from RFC 4291 2.2. Furthermore, there are no assertions that check wrong inputs are appropriately refused in any of the pac