[issue5395] array.fromfile not checking I/O errors

Antoine Pitrou added the comment: Regarding: > The tests run fine 543 tests ok, except I note that all the output is > repeated 6 times, I don't understand this at all. This is normal, all array tests are run once per array type, and 6 different array types are being tested. -- _

[issue5395] array.fromfile not checking I/O errors

Antoine Pitrou added the comment: I've committed the new test in py3k (r83030) and 3.1 (r83033), and the full patch in 2.7 (r83031) and 2.6 (r83032). Thank you! -- resolution: accepted -> fixed stage: commit review -> committed/rejected status: open -> closed versions: +Python 2.6 -Pyt

[issue5395] array.fromfile not checking I/O errors

Antoine Pitrou added the comment: Will polish the patch and commit. -- assignee: -> pitrou resolution: -> accepted stage: patch review -> commit review ___ Python tracker ___ _

[issue5395] array.fromfile not checking I/O errors

Mark Lawrence added the comment: Sorry for the noise, forgot to rebuild the code. The tests run fine 543 tests ok, except I note that all the output is repeated 6 times, I don't understand this at all. -- ___ Python tracker

[issue5395] array.fromfile not checking I/O errors

Mark Lawrence added the comment: With the latest patch on Windows Vista against 2.7 I got 12 EOFError errors instead of IOError. -- nosy: +BreamoreBoy versions: +Python 3.1 ___ Python tracker _

[issue5395] array.fromfile not checking I/O errors

Jan Hosang added the comment: Thanks Aduardo! (I could have sworn I tried that.) I changed the test to reading from a file in 'wb' mode, which raised a EOFError before and now raises IOErrors. -- Added file: http://bugs.python.org/file15055/array_ioerror.patch ___

[issue5395] array.fromfile not checking I/O errors

Eduardo Aguiar added the comment: Another try. I have opened a file for writing, and have tried to read from it: >>> fp = open ('xxx', 'w') >>> fp.read () Traceback (most recent call last): File "", line 1, in IOError: [Errno 9] Bad file descriptor -- __

[issue5395] array.fromfile not checking I/O errors

Jan Hosang added the comment: > Maybe you could create a file without read permission (000) and try > to read from it. I just checked. If I don't have read permissions, I am not able to open the file. When I open a file and change permissions afterwards, I can read the complete file alright.

[issue5395] array.fromfile not checking I/O errors

Eduardo Aguiar added the comment: Maybe you could create a file without read permission (000) and try to read from it. -- ___ Python tracker ___ _

[issue5395] array.fromfile not checking I/O errors

Jan Hosang added the comment: 1&2) I removed the try/except around the import. I have no clue if os might be unavailable. Maybe leave out handling that until we see that breaking. I added the try/except because I saw that in other tests in the same file when importing gc. 3) Done. 4) The EO

[issue5395] array.fromfile not checking I/O errors

Ezio Melotti added the comment: I tried to apply both the patches on the trunk but the tests don't pass. With the latest patch I get an EOFError instead of IOError in the assertRaises. The function I was talking about was test_support.unlink(), but that just removes the file, it doesn't close i

[issue5395] array.fromfile not checking I/O errors

Antoine Pitrou added the comment: Ok, I get it, you want f.close() to always succeed, even if the underlying file descriptor has already been closed. Well, I so no reason to introduce a helper anyway, the following four lines are much more readable and explicit: try: f.close() e

[issue5395] array.fromfile not checking I/O errors

Antoine Pitrou added the comment: There doesn't seem to be any reason to introduce the "expect_exception()" helper, rather than to use a with statement. Am I mistaken? -- nosy: +pitrou stage: test needed -> patch review versions: +Python 2.7, Python 3.2 -Python 2.6

[issue5395] array.fromfile not checking I/O errors

Jan Hosang added the comment: Ezio, I moved the test to a separate method. Also I couldn't find something to close the file if I don't care about errors. I thought an assertRises would be wrong, as I am not debugging files here, so I added a function to call a callable I expect to throw an ex

[issue5395] array.fromfile not checking I/O errors

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue5395] array.fromfile not checking I/O errors

Jan Hosang added the comment: I attached a path for raising IOErrors in fromfile. I also added a testcase which failed before. The test opens a file and closes the file with os.close(fd) without telling the file object, so fromfile doesn't notice it's reading from a file that is actually clo

[issue5395] array.fromfile not checking I/O errors

Changes by Daniel Diniz : -- keywords: +easy priority: -> normal stage: -> test needed ___ Python tracker ___ ___ Python-bugs-list ma

[issue5395] array.fromfile not checking I/O errors

New submission from Eduardo Aguiar : At arraymodule.c (line 1258): nread = fread(item + (Py_SIZE(self) - n) * itemsize, itemsize, n, fp); if (nread < (size_t)n) { Py_SIZE(self) -= (n - nread);