[issue5210] zlib does not indicate end of compressed stream properly

Nadeem Vawda added the comment: This bug (zlib not providing a way to detect end-of-stream) has already been fixed - see issue 12646. I've opened issue 16350 for the unused_data problem. -- resolution: -> out of date stage: test needed -> committed/rejected status: open -> closed super

[issue5210] zlib does not indicate end of compressed stream properly

Changes by Nadeem Vawda : -- nosy: +nadeem.vawda ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue5210] zlib does not indicate end of compressed stream properly

Amaury Forgeot d'Arc added the comment: Hm, I tried a modified version of your first test, and I found another problem with the current zlib library; starting with the input: x = x1 + x2 + HAMLET_SCENE# both compressed and uncompressed data The following scenario is OK: dco.decompress(x) #

[issue5210] zlib does not indicate end of compressed stream properly

Travis H. added the comment: Figured out how to test is_finished attribute of the zlib module properly. -- Added file: http://bugs.python.org/file14764/test_zlib.py.diff ___ Python tracker _

[issue5210] zlib does not indicate end of compressed stream properly

Travis H. added the comment: Diff to tests Implements all suggested changes save one: I wasn't sure how to test that is_finished is clear one byte before the end of the compressed section. Instead, I test that it is clear before I call the compression routine. -- Added file: http://b

[issue5210] zlib does not indicate end of compressed stream properly

Travis H. added the comment: zlibmodule.c.diff Implements all the suggested features, but I'm not exactly sure whether it handles reference counts properly. -- Added file: http://bugs.python.org/file14762/zlibmodule.c.diff ___ Python tracker

[issue5210] zlib does not indicate end of compressed stream properly

Amaury Forgeot d'Arc added the comment: Some comments about the patch: - In zlibmodule.c, the is_finished member should be an int, and converted to a PyObject only when requested. - The test should check that is_finished is False one byte before the compressed part, and becomes True when the d

[issue5210] zlib does not indicate end of compressed stream properly

Travis H. added the comment: Attaching unit test diff Output of "diff -u test_zlib.py~ test_zlib.py" -- Added file: http://bugs.python.org/file14745/zlib_finished_test.txt ___ Python tracker __

[issue5210] zlib does not indicate end of compressed stream properly

Ezio Melotti added the comment: Yes, I think that the right place where to add the tests is Lib/test/test_zlib.py -- ___ Python tracker ___ __

[issue5210] zlib does not indicate end of compressed stream properly

Travis H. added the comment: What kind of tests did you have in mind? Unit tests in python, or something else? -- nosy: +solinym ___ Python tracker ___ _

[issue5210] zlib does not indicate end of compressed stream properly

Ezio Melotti added the comment: Thanks for the patch! Can you provide tests too? -- nosy: +ezio.melotti priority: -> normal stage: -> test needed versions: +Python 2.7, Python 3.2 -Python 3.0 ___ Python tracker _

[issue5210] zlib does not indicate end of compressed stream properly

Travis Hassloch added the comment: Here is a patch which adds a member called is_finished to decompression objects that allows client code to know when it has reached the end of the compressed stream. -- keywords: +patch Added file: http://bugs.python.org/file13056/zlibmodule.diff

[issue5210] zlib does not indicate end of compressed stream properly

New submission from Travis Hassloch : Underlying zlib can determine when it has hit the end of a compressed stream without reading past the end. Python zlib implementation requires that one read past the end before it signals the end by putting data in Decompress.unused_data. This complicates i