[issue5188] telnetlib process_rawq buffer handling is confused

Jack Diederich added the comment: between r71434 and r74217 this should be fixed for 3.2. Marking as closed. -- resolution: -> fixed status: open -> closed ___ Python tracker _

[issue5188] telnetlib process_rawq buffer handling is confused

LazyLogik added the comment: Hello, I am also facing problems in using telnetlib. I think following changes are also required. e.g. on line 442 (if c!= IAC) should be replaced with (if c!= IAC[0]). Similarly line 465 (if cmd in (DO, DONT)) should be replaced with (if cmd in (DO[0], DONT[0])

[issue5188] telnetlib process_rawq buffer handling is confused

Changes by STINNER Victor : -- nosy: -haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue5188] telnetlib process_rawq buffer handling is confused

Jack Diederich added the comment: I assigned this to me. I'll be sprinting on telnetlib. -- assignee: -> jackdied nosy: +jackdied ___ Python tracker ___ ___

[issue5188] telnetlib process_rawq buffer handling is confused

Changes by David Christian : Added file: http://bugs.python.org/file13099/telnetlib.patch ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue5188] telnetlib process_rawq buffer handling is confused

David Christian added the comment: True. It turns out that there are other uses of a bytes string when a byte is required in that same routine. I've patched up those as well. Looks what we really need is a test of this function. I'll work on that as well. ___

[issue5188] telnetlib process_rawq buffer handling is confused

STINNER Victor added the comment: b"\021"[0] can be written 0o21 (or 17 or 0x11). -- nosy: +haypo ___ Python tracker ___ ___ Python-bu

[issue5188] telnetlib process_rawq buffer handling is confused

Changes by David Christian : -- keywords: +patch Added file: http://bugs.python.org/file13062/telnetlib.patch ___ Python tracker ___ __

[issue5188] telnetlib process_rawq buffer handling is confused

David Christian added the comment: The result of this bug is that any callback set via set_option_negotiation_callback will not be called. ___ Python tracker ___ _

[issue5188] telnetlib process_rawq buffer handling is confused

New submission from David Christian : in telnetlib's process_rawq, rawq_getchar() returns a bytes object of length 1. However, that buffer is then compared directly against the variable IAC, which is the integer 255. This is always false, as bytes([255]) != 255. Checked svn and looks like this