[issue5115] Extend subprocess.kill to be able to kill process groups

Gregory P. Smith added the comment: this is part of a chain of other related issues. the interesting thing in the patch in here is the potential feature to have send_signal/terminate/kill be able to optionally kill a process group. the logic as is in the patch in this issue is dangerous as

[issue5115] Extend subprocess.kill to be able to kill process groups

Change by Gregory P. Smith : -- resolution: -> duplicate superseder: -> subprocess.run timeout does not function if shell=True and capture_output=True ___ Python tracker ___

[issue5115] Extend subprocess.kill to be able to kill process groups

Change by Gregory P. Smith : -- pull_requests: -7893 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue5115] Extend subprocess.kill to be able to kill process groups

Change by haizaar : -- nosy: +haizaar ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/

[issue5115] Extend subprocess.kill to be able to kill process groups

Change by Ammar Askar : -- pull_requests: +7893 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue5115] Extend subprocess.kill to be able to kill process groups

Change by Fangyi Zhou : -- nosy: +fangyizhou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue5115] Extend subprocess.kill to be able to kill process groups

Eryk Sun added the comment: Using a Windows job object should be paired with the creation flag CREATE_SUSPENDED. Callers may also need CREATE_BREAKAWAY_FROM_JOB, but setting that creation flag shouldn't be integrated into Popen. The child has to be created suspended to ensure it doesn't spawn

[issue5115] Extend subprocess.kill to be able to kill process groups

Charles-Francois Natali added the comment: Note that the setpgid creation part is now somewhat redundant with Popen's start_new_session flag (which calls setsid). Also, this should probably be an option, since with that patch every subprocess is in its own process group. > I was wondering...

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Xuanji Li : -- nosy: +xuanji ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/m

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Giampaolo Rodola' : -- versions: +Python 3.3 -Python 3.0 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Ernst Sjöstrand : -- nosy: +Ernst.Sjöstrand ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue5115] Extend subprocess.kill to be able to kill process groups

Giampaolo Rodola' added the comment: A strong +1 on adding this feature. I was wondering... what if process A runs a subprocess B which runs a subprocess C. Is C still considered a children of A and gets killed as well? Does os.setpgid() takes care of such a thing? What about Windows instead?

[issue5115] Extend subprocess.kill to be able to kill process groups

STINNER Victor added the comment: erickt: can you fix your patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Giampaolo Rodola' : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/pyt

[issue5115] Extend subprocess.kill to be able to kill process groups

STINNER Victor added the comment: > I suspect that on Windows, TerminateJobObject won't work > with a handle returned by CreateProcess. TerminateJobObject works with CreateJobObject and AssignProcessToJobObject. The following code (from your patch) should call AssignProcessToJobObject (and C

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Thomas Guettler : -- nosy: +guettli ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Brian Curtin : -- priority: -> normal stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Brian Curtin : -- nosy: +brian.curtin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue5115] Extend subprocess.kill to be able to kill process groups

Amaury Forgeot d'Arc added the comment: I suspect that on Windows, TerminateJobObject won't work with a handle returned by CreateProcess. A solution could look like http://www.mobzystems.com/code/killprocesstree.aspx -- nosy: +amaury.forgeotdarc ___

[issue5115] Extend subprocess.kill to be able to kill process groups

Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue5115] Extend subprocess.kill to be able to kill process groups

New submission from Erick Tryzelaar : It would be really handy to add a way to portably kill process groups of a process spawned with subprocess.Popen. My project starts a process, which then starts other long running processes. Because of this process tree, there's no way for me to portably k