[issue5076] bdist_wininst fails on py3k

2009-01-29 Thread Martin v. Löwis
Martin v. Löwis added the comment: > Checked into py3k as r6998; merged to release30-maint as 69099. I hope > I got that right! If you ask whether checking into py3k was the right thing: yes, it was. ___ Python tracker __

[issue5076] bdist_wininst fails on py3k

2009-01-29 Thread Mark Hammond
Mark Hammond added the comment: Checked into py3k as r6998; merged to release30-maint as 69099. I hope I got that right! -- resolution: accepted -> fixed status: open -> closed ___ Python tracker _

[issue5076] bdist_wininst fails on py3k

2009-01-28 Thread Martin v. Löwis
Martin v. Löwis added the comment: This patch is fine, please apply. I wish it wouldn't be necessary to widen char*, but start off with wchar_t from the beginning. AFAICT, this would work fine for argv[1] (there are only two arguments, anyway), but might get complicated for argv[0]. --

[issue5076] bdist_wininst fails on py3k

2009-01-27 Thread Mark Hammond
Mark Hammond added the comment: Attaching an updated patch against the py3k branch which makes no attempt to work on py2k. Added file: http://bugs.python.org/file12886/wininst_py3k.patch ___ Python tracker

[issue5076] bdist_wininst fails on py3k

2009-01-27 Thread Martin v. Löwis
Martin v. Löwis added the comment: > Good question! I'm not really aware of the complexities involved in > merging between the various branches, but given the fairly trivial > nature of the patch I figured there were potential advantages in both > identical source and stubs. I'm happy to work

[issue5076] bdist_wininst fails on py3k

2009-01-27 Thread Mark Hammond
Mark Hammond added the comment: > Is it really useful to be have the same stub for 2.x and 3.x? > I think it would be better if they mutually ignore each > other, and be different. Good question! I'm not really aware of the complexities involved in merging between the various branches, but g

[issue5076] bdist_wininst fails on py3k

2009-01-26 Thread Martin v. Löwis
Martin v. Löwis added the comment: Is it really useful to be have the same stub for 2.x and 3.x? I think it would be better if they mutually ignore each other, and be different. -- nosy: +loewis ___ Python tracker

[issue5076] bdist_wininst fails on py3k

2009-01-26 Thread Mark Hammond
New submission from Mark Hammond : bdist_wininst installers created by py3k fail due to PySys_SetArgv and Py_SetProgramName both being passed 'char *' strings instead of wide strings. The patch is against the svn trunk as currently Python 2.x and 3.x share the same bdist_wininst stub. The patch