[issue4946] Lib/test/test__locale uses is to compare strings

Benjamin Peterson added the comment: Fixed in r68628. -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue4946] Lib/test/test__locale uses is to compare strings

Gabriel Genellina added the comment: Yes, checking object identity is wrong in this case. Your patch looks fine to me. I've found several other "is" comparisons that should not be there -- working on a patch right now. -- nosy: +gagenellina ___ Py

[issue4946] Lib/test/test__locale uses is to compare strings

New submission from Maciek Fijalkowski : this is at least a bad practice. It also might break silently at any point. -- components: Library (Lib), Tests files: out.diff keywords: patch messages: 79846 nosy: fijal severity: normal status: open title: Lib/test/test__locale uses is to compa