[issue4888] misplaced (or misleading) assert in ceval.c

Berker Peksag added the comment: This has been fixed as part of issue 16191: https://hg.python.org/cpython/rev/ac30a1b1cf17#l1.2780 -- nosy: +berker.peksag resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Pyt

[issue4888] misplaced (or misleading) assert in ceval.c

Changes by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue4888] misplaced (or misleading) assert in ceval.c

Changes by Ezio Melotti : -- stage: -> patch review versions: +Python 3.4 -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mail

[issue4888] misplaced (or misleading) assert in ceval.c

Changes by Terry J. Reedy : -- versions: +Python 3.2 -Python 2.6, Python 2.7, Python 3.0, Python 3.1 ___ Python tracker ___ ___ Python-

[issue4888] misplaced (or misleading) assert in ceval.c

Changes by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue4888] misplaced (or misleading) assert in ceval.c

Jeffrey Yasskin added the comment: The assert seems confusing to me because it's overly specific. It causes me to ask, "what's special about WHY_YIELD that why might be set to it?" If I understand the loop correctly, we could rewrite the top as: assert(why != WHY_YIELD); /* These two values ar

[issue4888] misplaced (or misleading) assert in ceval.c

Jim Jewett added the comment: I agree with Raymond. A comment *might* be sufficient, but ... in some sense, that is the purpose of an assert. The loop is reasonably long; it already includes macros which could (but currently don't) change the value, and function calls which might plausibly

[issue4888] misplaced (or misleading) assert in ceval.c

Raymond Hettinger added the comment: I wasn't opposing the patch. Just wanted to look back at why the assertion was put there in the first place. If you want it in, go ahead. -- assignee: rhettinger -> ___ Python tracker

[issue4888] misplaced (or misleading) assert in ceval.c

Guido van Rossum added the comment: I don't see why the refactoring has to maintain the same logic bug as the original. I'm with Skip & Jeffrey. -- nosy: +gvanrossum ___ Python tracker

[issue4888] misplaced (or misleading) assert in ceval.c

Raymond Hettinger added the comment: IIRC, I think I put this here a long while ago when replacing or removing a corresponding if-test that had always been compiled-in. The assertion was a way of validating that the refactoring and elimination of tests had not broken anything. If that was the

[issue4888] misplaced (or misleading) assert in ceval.c

Jeffrey Yasskin added the comment: Sounds like a fine change to me. -- nosy: +jyasskin ___ Python tracker ___ ___ Python-bugs-list mai

[issue4888] misplaced (or misleading) assert in ceval.c

New submission from Skip Montanaro : There is what I believe is a misplaced - or at least misleading - assert in the while loop following the fast_block_end label. If why != WHY_YIELD before the loop starts I don't see how that relationship could change within the loop. Proposed patch against p