[issue4864] test_msvc9compiler fails on VC6

2009-01-07 Thread Hirokazu Yamamoto
Hirokazu Yamamoto added the comment: Thanks, fixed in r68373. -- resolution: accepted -> fixed status: open -> closed ___ Python tracker ___ _

[issue4864] test_msvc9compiler fails on VC6

2009-01-07 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: The patch is good. -- keywords: -needs review resolution: -> accepted ___ Python tracker ___ ___

[issue4864] test_msvc9compiler fails on VC6

2009-01-07 Thread Hirokazu Yamamoto
Hirokazu Yamamoto added the comment: > I don't like this catch-all approach. I agree with you. Lib/distutils/msvc9compiler.py still only have one top level DistutilsPlatformError, VERSION = get_build_version() if VERSION < 8.0: raise DistutilsPlatformError("VC %0.1f is not supported by th

[issue4864] test_msvc9compiler fails on VC6

2009-01-07 Thread Hirokazu Yamamoto
Changes by Hirokazu Yamamoto : Removed file: http://bugs.python.org/file12629/test_msvc9compiler.patch ___ Python tracker ___ ___ Python-bugs-l

[issue4864] test_msvc9compiler fails on VC6

2009-01-07 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: I don't like this catch-all approach. What if no compiler is installed at all? I suggest to use a test like distutils.msvccompiler.get_build_version() >= 8.0 (this is how msvccompiler imports the msvc9compiler module) -- nosy: +amaury.forgeotd

[issue4864] test_msvc9compiler fails on VC6

2009-01-06 Thread Hirokazu Yamamoto
Changes by Hirokazu Yamamoto : Added file: http://bugs.python.org/file12629/test_msvc9compiler.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue4864] test_msvc9compiler fails on VC6

2009-01-06 Thread Hirokazu Yamamoto
Changes by Hirokazu Yamamoto : Removed file: http://bugs.python.org/file12628/test_msvc9compiler.patch ___ Python tracker ___ ___ Python-bugs-l

[issue4864] test_msvc9compiler fails on VC6

2009-01-06 Thread Hirokazu Yamamoto
New submission from Hirokazu Yamamoto : Currently, test_msvc9compiler fails on VC6 with following message. // Traceback (most recent call last): File "test_distutils.py", line 17, in test_main() File "test_distutils.py", line 13, in test_main