[issue46685] Add additional tests for new features in `typing.py`

Change by Jelle Zijlstra : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue46685] Add additional tests for new features in `typing.py`

Jelle Zijlstra added the comment: New changeset 32e3e0bea613711a8f19003445eebcb05fb75acc by Nikita Sobolev in branch 'main': bpo-46685: improve test coverage of `Self` and `Never` in `typing` (GH-31222) https://github.com/python/cpython/commit/32e3e0bea613711a8f19003445eebcb05fb75acc --

[issue46685] Add additional tests for new features in `typing.py`

miss-islington added the comment: New changeset bde3765a3fd21e2ecf595a57998b285e3045f744 by Miss Islington (bot) in branch '3.9': bpo-46685: cover `TypeError` of `ForwardRef(1)` in `test_typing` (GH-31223) https://github.com/python/cpython/commit/bde3765a3fd21e2ecf595a57998b285e3045f744 ---

[issue46685] Add additional tests for new features in `typing.py`

miss-islington added the comment: New changeset d29bbc22b08551afce24e933f43bfcb6e980cb08 by Miss Islington (bot) in branch '3.10': bpo-46685: cover `TypeError` of `ForwardRef(1)` in `test_typing` (GH-31223) https://github.com/python/cpython/commit/d29bbc22b08551afce24e933f43bfcb6e980cb08 --

[issue46685] Add additional tests for new features in `typing.py`

Change by miss-islington : -- pull_requests: +29400 pull_request: https://github.com/python/cpython/pull/31230 ___ Python tracker ___ __

[issue46685] Add additional tests for new features in `typing.py`

Change by miss-islington : -- nosy: +miss-islington nosy_count: 6.0 -> 7.0 pull_requests: +29399 pull_request: https://github.com/python/cpython/pull/31229 ___ Python tracker _

[issue46685] Add additional tests for new features in `typing.py`

Dong-hee Na added the comment: New changeset d2d1d49eaccaa83eb8873ba15f2fc9562143bc56 by Nikita Sobolev in branch 'main': bpo-46685: cover `TypeError` of `ForwardRef(1)` in `test_typing` (GH-31223) https://github.com/python/cpython/commit/d2d1d49eaccaa83eb8873ba15f2fc9562143bc56 --

[issue46685] Add additional tests for new features in `typing.py`

Change by Nikita Sobolev : -- pull_requests: +29394 pull_request: https://github.com/python/cpython/pull/31223 ___ Python tracker ___ __

[issue46685] Add additional tests for new features in `typing.py`

Jelle Zijlstra added the comment: Thanks for catching these details! Please send a PR. -- ___ Python tracker ___ ___ Python-bugs-li

[issue46685] Add additional tests for new features in `typing.py`

Change by Nikita Sobolev : -- keywords: +patch pull_requests: +29392 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31222 ___ Python tracker ___ _

[issue46685] Add additional tests for new features in `typing.py`

New submission from Nikita Sobolev : New features (like `Self` type and `Never` type), in my opinion, require some extra testing. Things that were not covered: - Inheritance from `Self`, only `type(Self)` is covered: https://github.com/python/cpython/blob/c018d3037b5b62e6d48d5985d1a37b91762fb