[issue45743] Cleanup and simplify setup.py

2021-11-09 Thread Christian Heimes
Christian Heimes added the comment: New changeset 6a1cc8bf8a0d88af9c7891c6577508ae9f70e3ef by Christian Heimes in branch 'main': bpo-45743: Remove workaround for zlib CVE from 2002 (GH-29457) https://github.com/python/cpython/commit/6a1cc8bf8a0d88af9c7891c6577508ae9f70e3ef -- _

[issue45743] Cleanup and simplify setup.py

2021-11-09 Thread Christian Heimes
Christian Heimes added the comment: New changeset 8fefaad242f45b3bd97e000a00f2aac16d935315 by Christian Heimes in branch 'main': bpo-45743: -Wl,-search_paths_first is no longer needed (GH-29464) https://github.com/python/cpython/commit/8fefaad242f45b3bd97e000a00f2aac16d935315 -- __

[issue45743] Cleanup and simplify setup.py

2021-11-08 Thread Ned Deily
Ned Deily added the comment: >> 1) __APPLE_USE_RFC_3542 should have been in socketmodule.c from the start, >> not sure why it was added in setup.py. > FTR, it was added by me in bpo-35569, GH-19526. I moved the check to setup.py > because Ned made me do it :P Yeah, well, it seemed like a go

[issue45743] Cleanup and simplify setup.py

2021-11-08 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > 1) __APPLE_USE_RFC_3542 should have been in socketmodule.c from the start, > not sure why it was added in setup.py. FTR, it was added by me in bpo-35569, GH-19526. I moved the check to setup.py because Ned made me do it :P https://github.com/python/cpy

[issue45743] Cleanup and simplify setup.py

2021-11-08 Thread Ronald Oussoren
Ronald Oussoren added the comment: 1) __APPLE_USE_RFC_3542 should have been in socketmodule.c from the start, not sure why it was added in setup.py. 2) as you and Ned noticed -search_paths_first has been the default for a long while, we can just drop it and anyone building on ancient systems

[issue45743] Cleanup and simplify setup.py

2021-11-08 Thread Christian Heimes
Christian Heimes added the comment: New changeset 24af9a40a8f85af813ea89998aa4e931fcc78cd9 by Christian Heimes in branch 'main': bpo-45743: Move __APPLE_USE_RFC_3542 into socketmodule.c (GH-29456) https://github.com/python/cpython/commit/24af9a40a8f85af813ea89998aa4e931fcc78cd9 --

[issue45743] Cleanup and simplify setup.py

2021-11-08 Thread Christian Heimes
Change by Christian Heimes : -- pull_requests: +27718 pull_request: https://github.com/python/cpython/pull/29464 ___ Python tracker ___

[issue45743] Cleanup and simplify setup.py

2021-11-07 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue45743] Cleanup and simplify setup.py

2021-11-07 Thread Christian Heimes
Christian Heimes added the comment: For reference: https://opensource.apple.com/source/ld64/ld64-242/doc/man/man1/ld.1.auto.html > search_paths_first > This is now the default (in Xcode4 tools). When processing -lx the linker > now searches each directory > in its library search paths for `

[issue45743] Cleanup and simplify setup.py

2021-11-07 Thread Christian Heimes
Christian Heimes added the comment: Thanks for the detailed explanation, Ned. Much appreciated! For non-Mac users: macOS 10.6 was released in 2009 and 10.9 in 2013. IMHO it is reasonable to ask people to provide their own copies of libraries on older system. We also require OpenSSL 1.1.1, wh

[issue45743] Cleanup and simplify setup.py

2021-11-07 Thread Ned Deily
Ned Deily added the comment: It seems to me that some (most?) of the macOS-specific workarounds in setup.py were added to make it easy to build with the system-provided copies of the third-party libraries, like zlib and sqlite3 and openssl. At least one of the workarounds, search_paths_first

[issue45743] Cleanup and simplify setup.py

2021-11-07 Thread Christian Heimes
Change by Christian Heimes : -- pull_requests: +27712 pull_request: https://github.com/python/cpython/pull/29457 ___ Python tracker ___

[issue45743] Cleanup and simplify setup.py

2021-11-07 Thread Christian Heimes
Change by Christian Heimes : -- keywords: +patch pull_requests: +27710 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29456 ___ Python tracker ___

[issue45743] Cleanup and simplify setup.py

2021-11-07 Thread Christian Heimes
Change by Christian Heimes : -- keywords: +patch, patch pull_requests: +27710, 27711 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29456 ___ Python tracker _

[issue45743] Cleanup and simplify setup.py

2021-11-07 Thread Christian Heimes
New submission from Christian Heimes : Motivated by deprecation of distutils, I like to move more logic and checks from setup.py into configure.ac. Eventually I like to get rid of setup.py. The file contains a bunch of complicated checks and macOS-specific adjustments that I cannot verify on