[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

Changes by Antoine Pitrou : -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed versions: -Python 3.2 ___ Python tracker ___ __

[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

Roundup Robot added the comment: New changeset 142c62a490ce by Antoine Pitrou in branch 'default': Issue #4555: All exported C symbols are now prefixed with either "Py" or "_Py". http://hg.python.org/cpython/rev/142c62a490ce -- nosy: +python-dev ___ P

[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

Antoine Pitrou added the comment: This very simple patch should certainly be applied. -- assignee: -> dmalcolm stage: patch review -> commit review versions: +Python 2.7 -Python 2.6 ___ Python tracker _

[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

Martin v. Löwis added the comment: I'd like to focus this issue; it has been open long enough, and deserves to get closed once the original issue is resolved - which was that "make smelly" reports symbols. I think dmalcolm's patch is quite a good start for that. It may well be that other modul

[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

Changes by Antoine Pitrou : -- stage: test needed -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

Christian Heimes added the comment: For Python 3.3 and 3.4 make smelly still lists two exported symbols. asdl_int_seq_new asdl_seq_new Do we have to check the modules, too? Some of them like _ctypes and _decimal export a lot of symbols. Here is a small shell snippet for Makefile. for MOD

[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

Dave Malcolm added the comment: Patch to py3k which adds the "_Py" prefix to the four listed symbols. With this, the output from "make smelly" is clean (odorless, perhaps?). However, adding _Py does seem to go against this comment in Include/asdl.h: /* It would be nice if the code generated by

[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

Changes by Alexander Belopolsky : -- title: Smelly exports -> Smelly exports (global symbols in python not prefixed with Py or _Py) ___ Python tracker ___ ___

[issue4555] Smelly exports

Dave Malcolm added the comment: py3k is much cleaner than python 2, due to the change in the module API. Here's "make smelly"'s output on a recent py3k checkout: nm -p libpython3.2.a | \ sed -n "/ [TDB] /s/.* //p" | grep -v "^_*Py" | sort -u; \ _add_one_to_index_C _add_one_to_i

[issue4555] Smelly exports

Dave Malcolm added the comment: Re: msg #77350: > I propose to simply filter out init[_a-z]+ from the set of "bad" > symbols. I'm attaching a patch (to trunk) to Makefile.pre.in which filters out such symbols. Relevant part of output of "make smelly" on my svn build with this patch: nm -p li

[issue4555] Smelly exports

Antoine Pitrou added the comment: In trunk: _add_one_to_index_C _add_one_to_index_F asdl_int_seq_new asdl_seq_new init_ast init_codecs initerrno initgc initimp initposix initpwd initsignal init_sre init_symtable initthread initxxsubtype initzipimport In py3k: _add_one_to_index_C _add_one_to_i

[issue4555] Smelly exports

Antoine Pitrou added the comment: #5591 is a duplicate of this. -- nosy: +doko, pitrou ___ Python tracker ___ ___ Python-bugs-list mai

[issue4555] Smelly exports

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: There is no proposed patch yet, so removing 2.5.3 from the target versions. -- versions: -Python 2.5.3 ___ Python tracker <[EMAIL PROTECTED]> __

[issue4555] Smelly exports

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: I guess you *could* change the name of extensions that become builtin modules. However, I think it is not worth the trouble, especially since PEP 3121 solves the problem for good, for Python 3. I propose to simply filter out init[_a-z]+ from

[issue4555] Smelly exports

Marc-Andre Lemburg <[EMAIL PROTECTED]> added the comment: For Python 2.x you cannot change the "main" function name of C extensions, since this is used by the Python import mechanism. -- nosy: +lemburg ___ Python tracker <[EMAIL PROTECTED]>

[issue4555] Smelly exports

Changes by Martin v. Löwis <[EMAIL PROTECTED]>: -- priority: high -> normal ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-l

[issue4555] Smelly exports

Christian Heimes <[EMAIL PROTECTED]> added the comment: I just suggest that somebody should look into it. I neither know how critical the issue is nor how to change them. This bug report serves as a reminder. ___ Python tracker <[EMAIL PROTECTED]>

[issue4555] Smelly exports

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Are you suggesting that the init* functions in Python 2.6 should not longer be exported? Why? And how? -- nosy: +loewis ___ Python tracker <[EMAIL PROTECTED]> __

[issue4555] Smelly exports

New submission from Christian Heimes <[EMAIL PROTECTED]>: I just found about the smelly build target. It checks for smelly exports. $ make smelly [...] nm -p libpython2.6.a | \ sed -n "/ [TDB] /s/.* //p" | grep -v "^_*Py" | sort -u; \ asdl_int_seq_new asdl_seq_new init_ast init_