[issue45238] Fix debug() in IsolatedAsyncioTestCase

2021-09-22 Thread Łukasz Langa
Łukasz Langa added the comment: Thanks, Serhiy! ✨ 🍰 ✨ -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue45238] Fix debug() in IsolatedAsyncioTestCase

2021-09-22 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset e06b0fddf69b933fe82f60d78a0f6248ca36a0a3 by Łukasz Langa in branch '3.9': [3.9] bpo-45238: Fix unittest.IsolatedAsyncioTestCase.debug() (GH-28449) (GH-28522) https://github.com/python/cpython/commit/e06b0fddf69b933fe82f60d78a0f6248ca36a0a3 -

[issue45238] Fix debug() in IsolatedAsyncioTestCase

2021-09-22 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset 44396aaba9b92b3a38a4b422a000d1a8eb05185a by Łukasz Langa in branch '3.10': [3.10] bpo-45238: Fix unittest.IsolatedAsyncioTestCase.debug() (GH-28449) (GH-28521) https://github.com/python/cpython/commit/44396aaba9b92b3a38a4b422a000d1a8eb05185a ---

[issue45238] Fix debug() in IsolatedAsyncioTestCase

2021-09-22 Thread Łukasz Langa
Change by Łukasz Langa : -- pull_requests: +26913 pull_request: https://github.com/python/cpython/pull/28522 ___ Python tracker ___ _

[issue45238] Fix debug() in IsolatedAsyncioTestCase

2021-09-22 Thread Łukasz Langa
Change by Łukasz Langa : -- pull_requests: +26912 pull_request: https://github.com/python/cpython/pull/28521 ___ Python tracker ___ _

[issue45238] Fix debug() in IsolatedAsyncioTestCase

2021-09-22 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset ecb6922ff2d56476a6cfb0941ae55aca5e7fae3d by Serhiy Storchaka in branch 'main': bpo-45238: Fix unittest.IsolatedAsyncioTestCase.debug() (GH-28449) https://github.com/python/cpython/commit/ecb6922ff2d56476a6cfb0941ae55aca5e7fae3d -- nosy: +

[issue45238] Fix debug() in IsolatedAsyncioTestCase

2021-09-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It turned out be more complicated than I expected. We need to keep the even loop after getting exception in debug() for having ability to run doCleanup() etc. The option is to close the even loop in __del__. But we should ensure that it is closed before ru

[issue45238] Fix debug() in IsolatedAsyncioTestCase

2021-09-18 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +26852 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28449 ___ Python tracker ___

[issue45238] Fix debug() in IsolatedAsyncioTestCase

2021-09-18 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Currently debug() does not work in IsolatedAsyncioTestCase subclasses. It runs synchronous code (setUp(), tearDown(), synchronous tests and cleanup functions), but does not run any asynchronous code (asyncSetUp(), asyncTearDown(), asynchronous tests and